Page MenuHomeSchine - Phabricator

Starmade | Sector change moves players in gravity/alignment
Closed, FinishedPublic

Description

Happens in gravity and with grappling hook.

  • Sector change >20km/h
  • Jump drive
  • Warp gates
  • /change_sector / admin warp sometimes too, but rather rarely

They all make astronauts jump 3-4 blocks upwards, causing them to get stuck in narrow corridors or get pushed outside the ship. (Most likely happens for npc's too but they show other issues, hard to test it out)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19626 (Dev)
Category
Engine
First occurrence (version)
0.14
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 2 2015, 8:46 PM
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.14.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19242.
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Low.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJun 2 2015, 8:46 PM
lancake changed the task status from Open to In Queue (Game).Jun 2 2015, 8:47 PM
AndyP changed the task status from In Queue (Game) to Open.
AndyP added a subscriber: AndyP.Jun 2 2015, 9:03 PM
AndyP changed the task status from Open to In Queue (Game).

confirmed

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 2 2015, 9:06 PM
Restricted Application removed a project: Starmade. · View Herald TranscriptJun 3 2015, 4:15 PM
schema added a subscriber: schema.Jun 11 2015, 10:56 PM
schema changed the task status from In Queue (Game) to Open.

Can't reproduce in SP. Tried with 2 clients on a 3 block ship, I couldn't get the other client to move. It may be MP issue only

Restricted Application edited projects, added Issue Navigation; removed Game Development. · View Herald TranscriptJun 11 2015, 10:56 PM
lancake changed the task status from Open to In Queue (Game).Jun 19 2015, 11:30 AM

I can still reproduce it in singleplayer and multiplayer, with 1 and 2 clients.

How to reproduce:

  1. place down shipcore, some power and some thrust
  2. get in the ship, fly to a sector border, around 300 meter before you cross it, leave the ship (you're auto aligned)
  3. let yourself glide till you cross the sector. do shift + scroll out to see your character move
  4. when entering a new sector you'll see that your character moved a few blocks, this can 50-100 meter if you're in small corridors.

gif with client 1 as pilot, client 2 aligned on top of the core.

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 19 2015, 11:30 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 8:54 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP added a comment.Aug 27 2015, 9:48 PM

this in fact reopens T215 now, looks like it got worse recently, could not fly around with another player aligned to a small shuttle anymore.
They constantly fall off, when switching sectors.

AndyP added a subscriber: SpaceKing.
AndyP raised the priority of this task from Low to High.
AndyP added a commit: Restricted Diffusion Commit.Aug 27 2015, 9:52 PM

as of ver 0.19412 crossing sector borders while aligned to a ship and not sitting will move the aligned player a few meters with each crossing until eventually the player is disaligned and free from the ships influence.

also it seems attempting to sit on the ship after these attempts will warp the player a few sectors away but not sure what determines where the player is warped to.

video
https://youtu.be/UuKHtN9dap4

log stuff

lancake claimed this task.Sep 21 2015, 10:48 AM
schema changed the task status from In Queue (Game) to Resolved.Nov 4 2015, 3:52 PM

Might be resolved with the "players not falling out of ships" fix. needs qa

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 4 2015, 3:52 PM

-QA Testing-

Not fixed unfortunately. I noticed that it always seems to jump you in the same direction if you stay on the same begin position (and don't change your ship). I blocked the position I always jumped to with blocks and the game did check for collision and just moved me downwards this time. Every sector crossing afterwards caused my astronaut to always jump to that new position.

lancake changed Last tested (version) from 0.19242 to 0.19480 (Dev).Nov 5 2015, 5:54 PM
schema added a comment.Nov 5 2015, 6:01 PM

Ahh, it still does the "check for collision" thing on jumping.

spunkie changed the task status from Resolved to In Queue (Game).Nov 7 2015, 8:28 AM

Was testing T428 in 0.19485 and this bug happens and got a double character update error. This happened on the test server so you probably have the logs already.
https://youtu.be/aJByEd2x_os

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptNov 7 2015, 8:28 AM
spunkie changed Last tested (version) from 0.19480 (Dev) to 0.19538 release.Jan 6 2016, 8:12 AM
spunkie claimed this task.
spunkie reassigned this task from spunkie to lancake.
Ithirahad added a subscriber: Ithirahad.EditedMar 1 2016, 9:27 PM

Players will now get teleported pretty far forward on sector crossing... Only way to avoid this is to sit in a chair while travelling. Usually with smaller ships this will result in simply teleporting into space and falling off of your ship. With larger ones, you can end up stuck inside systems or other blocks far from where you were.

lancake changed the task status from In Queue (Game) to Resolved.Mar 3 2016, 8:41 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 3 2016, 8:41 PM
icky added a subscriber: icky.Mar 3 2016, 10:27 PM

im still seeing some movement during sector changes. if the ship is right side up in the universe then your character will jump up a block or so and fall back to where you were standing. but if the ship is upside down in the universe then your character will go down into the floor so your upper half is sticking out of the block you were standing on.

In T8#45150, @Ithirahad wrote:

Players will now get teleported pretty far forward on sector crossing... Only way to avoid this is to sit in a chair while travelling. Usually with smaller ships this will result in simply teleporting into space and falling off of your ship. With larger ones, you can end up stuck inside systems or other blocks far from where you were.

In T8#45565, @icky wrote:

im still seeing some movement during sector changes. if the ship is right side up in the universe then your character will jump up a block or so and fall back to where you were standing. but if the ship is upside down in the universe then your character will go down into the floor so your upper half is sticking out of the block you were standing on.

Could reproduce what icky said, more or less. Sometimes it happens, sometimes it doesn't and even then it's only a block or 2.
When you're in gravity though it's usually a little bit worse if you warp through the floor, then you just fall out completely.

Can't reproduce what Ithirahad said, don't really know what you mean with "pretty far forward" unless that's a few blocks.

That was before the fix. I haven't tested it since then.

lancake closed this task as Closed.Apr 2 2016, 3:08 PM

-QA Testing-

I really can't find any angle anymore that moves my player on sector change. At large speeds, forcing your players into walls seems to give you a small bump (unrelated to sector change) so maybe that's what icky experienced.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 2 2016, 3:08 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.19538 release to 0.19626 (Dev).Apr 2 2016, 3:09 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:50 PM