Quality check the following new feature:
Align or be in control of a ship that is moving.
Logout and login again at a later time.
Result until now:
New proposed behavior:
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Unknown Object (Maniphest Task) | ||||
| Resolved | spunkie | T428 Feature QA: Stay attached to ship while being logged out |
will do that with @Gamel tomorrow
we will go through every possible combination and cover all details for QA testing.
Working for most situations, however, the implemented mechanic requires the "ship" to not move in the time between
"login" and "spawn".
If someone is piloting the ship, the "client logging in" will be "fake-aligned", the client shows alignment, but the server drop the pilot in space.
(confirmed by moving to another sector, and teleporting, the other client did not follow)
So possibly needs a "teleport to the entity" right before spawning to not make the server discard the alignment.
-QA Testing-
Partial fix?
The logged out player is still aligned to the ship but when he comes back hes about 5 blocks back from where he logged out, if the ship is moving when he logs in. No sector border crossing is necessary for the shift to occur just the ship needs to be moving.
The 5 block shift backwards is not too bad but there are plenty ship designs where this would result in a player getting stuck in the utility spaces.
not only is this bad for low ranking faction members without permissions, but can also be abused by boarders attempting to bypass walls without use of a torch.
https://youtu.be/Lc40rMiEfL4
Fixed for the most part. Possibly still happening when logging out while sitting. However, collision avoidance is now functional and the player can also hit the up key