Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1546

Starmade | Faction's roleID is not consistent with faction_mod_members parameter
Confirmed task for development, TrivialPublic
Actions

Description

Expected:
/faction_mod_member Wolfe 4

/faction_list_members 10035
RETURN: [SERVER, [ADMIN COMMAND] [SUCCESS] Libretarian Alliance: {EpicBeard=>FactionPermission [playerUID=EpicBeard, roleID=1], Jtkenney_1=>FactionPermission [playerUID=Jtkenney_1, roleID=1], SnowMaster=>FactionPermission [playerUID=SnowMaster, roleID=1], Wolfe=>FactionPermission [playerUID=Wolfe, roleID=4], zachary=>FactionPermission [playerUID=zachary, roleID=2], zack=>FactionPermission [playerUID=zack, roleID=0]}, 0]

Actual:
/faction_mod_member Wolfe 4

/faction_list_members 10035
RETURN: [SERVER, [ADMIN COMMAND] [SUCCESS] Libretarian Alliance: {EpicBeard=>FactionPermission [playerUID=EpicBeard, roleID=1], Jtkenney_1=>FactionPermission [playerUID=Jtkenney_1, roleID=1], SnowMaster=>FactionPermission [playerUID=SnowMaster, roleID=1], Wolfe=>FactionPermission [playerUID=Wolfe, roleID=3], zachary=>FactionPermission [playerUID=zachary, roleID=2], zack=>FactionPermission [playerUID=zack, roleID=0]}, 0]

Rationale:
A faction's roleID should match integer used in mod_member command. To behave as-if 0=1, 1=2, 2=3, 3=4, and 4=5 is not only an expected behavior, it's just downright confusing.

Could this also be contributing to T149 ?

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.198.147
Category
Engine
First occurrence (version)
0.198.147
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Tester information (Internal use only)

/faction_list_members shows roleID going from 0 to 4
/faction_mod_member xxx y has role going from 1 to 5

It's indeed slightly confusing so just changing 1 of the 2 should be good enough.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptJun 8 2016, 6:13 PM
erthparadine updated the task description. (Show Details)Jun 8 2016, 6:14 PM
lancake added a subscriber: lancake.Jun 8 2016, 9:37 PM
lancake claimed this task.

-validated-

A small inconsistency, trivial stuff though.

lancake shifted this object from the S1 Public space to the S3 Starmade space.Jun 8 2016, 9:42 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.198.147.
lancake changed Category from none/unspecified to Engine.
lancake set First occurrence (version) to 0.198.147.
lancake moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake renamed this task from Faction's roleID is not consistent with /faction_mod_members integer to Faction's roleID is not consistent with faction_mod_members parameter.
lancake triaged this task as Trivial priority.
lancake changed the task status from Open to In Queue (Game).Jun 8 2016, 10:54 PM

-confirmed-

Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptJun 8 2016, 10:54 PM
lancake moved this task from Unclassed to Issue affecting current release on the Starmade board.Aug 9 2016, 6:11 PM
lancake raised the priority of this task from Trivial to Release Blocker.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptAug 9 2016, 6:11 PM
lancake lowered the priority of this task from Release Blocker to Trivial.Aug 25 2016, 6:56 PM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:25 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:25 PM
AndyP edited projects, added Engine (Configuration); removed Engine.Mar 15 2017, 6:45 PM
AndyP moved this task from Backlog / Unclassed to Beta on the Engine (Configuration) board.
AndyP moved this task from Configuration to Commands on the Engine board.Mar 15 2017, 7:54 PM
AndyP edited projects, added Engine (Commands); removed Engine (Configuration).
Restricted Application edited projects, added Engine; removed Engine (Commands). · View Herald TranscriptMar 15 2017, 7:54 PM
AndyP edited projects, added Engine (Commands); removed Engine.Mar 15 2017, 7:56 PM