Page MenuHomeSchine - Phabricator

Starmade | Faction role ID is 0-4 while the command that sets it uses 1-5 as the parameter
Closed, DuplicatePublic

Description

As title:
/faction_mod_member takes 1-5 as a parameter for the faction role while the faction role ID is 0-4
This may not be the biggest issue ever but is sloppy coding and makes it harder for server admins to understand what they are doing.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.334
Category
Engine
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Create and join faction
  2. Do /faction_list_member {name} {fac_id} and note your role ID
  3. Do /faction_mod_member {name} {number 1-5}
  4. Do step 2 again, role ID does not match parameter value from step 3

Event Timeline

33Cav created this task.Feb 26 2018, 1:51 AM
lancake claimed this task.

-Rejected-

Duplicate, merging tasks.

lancake shifted this object from the S1 Public space to the S3 Starmade space.Mar 11 2018, 7:02 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake lowered the priority of this task from Normal to Trivial.
Restricted Application edited projects, added Engine; removed Issue Navigation. · View Herald TranscriptMar 11 2018, 7:02 PM