Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1485

Starmade | Typo in logs
Closed, RejectedPublic
Actions

Description

See first word in first line:

[2016-05-25 15:12:18] [VERION] loading version from install dir: ./
[2016-05-25 15:12:18] [VERSION] VERSION: 0.198.133
[2016-05-25 15:12:18] [VERSION] BUILD: 20160524_224903

added from merged -> [SREVER]

[2016-05-23 21:28:39] [SREVER] FACTION BLOCK ADDED TO SpaceStation[ENTITY_SPACESTATION_Cant touch this(80585)]((0, 0, 0))[s2; Hash80585; id 153868712]; resetting faction!
[2016-05-23 21:30:10] [SREVER] FACTION BLOCK ADDED TO SpaceStation[ENTITY_SPACESTATION_Tomatart the great(80832)]((0, 0, 0))[s2; Hash80832; id 154018291]; resetting faction!
[2016-05-23 21:33:46] [SREVER] FACTION BLOCK REMOVED FROM SpaceStation[ENTITY_SPACESTATION_Event Horizion HQ_-86_20_20(80921)]; resetting faction !!!!!!!!!!!!!!
[2016-05-23 21:33:48] [SREVER] FACTION BLOCK ADDED TO SpaceStation[ENTITY_SPACESTATION_Event Horizion HQ_-86_20_20(80921)]((-768, 0, 0))[s2; Hash-14492104; id 157483413]; resetting faction!
[2016-05-23 21:34:06] [SREVER] FACTION BLOCK ADDED TO Ship[D-23434151](79917)((0, 0, 0))[s205; Hash79917; id 152233749]; resetting faction!
[2016-05-23 21:34:26] [SREVER] FACTION BLOCK REMOVED FROM Ship[D-23434151](79917); resetting faction !!!!!!!!!!!!!!
[2016-05-23 21:34:28] [SREVER] FACTION BLOCK ADDED TO Ship[D-23434151](79917)((0, 0, 0))[s204; Hash79917; id 152233749]; resetting faction!
[2016-05-23 21:36:04] [SREVER] FACTION BLOCK ADDED TO SpaceStation[ENTITY_SPACESTATION_The end is near(81691)]((0, 0, 0))[s2; Hash81691; id 163696285]; resetting faction!
[2016-05-23 21:38:48] [SREVER] FACTION BLOCK REMOVED FROM Ship[D-23434151](79917); resetting faction !!!!!!!!!!!!!!
[2016-05-23 21:39:23] [SREVER] FACTION BLOCK REMOVED FROM SpaceStation[ENTITY_SPACESTATION_Event Horizion HQ_-86_20_20(80921)]; resetting faction !!!!!!!!!!!!!!
[2016-05-23 21:50:56] [SREVER] FACTION BLOCK REMOVED FROM Ship[Furon Homerl200](82313); resetting faction !!!!!!!!!!!!!!
[2016-05-23 22:01:22] [SREVER] FACTION BLOCK ADDED TO Ship[D-23434151](79917)((0, 0, 0))[s261; Hash79917; id 152233749]; resetting faction!
[2016-05-23 22:40:03] [SREVER] FACTION BLOCK REMOVED FROM Ship[D-23434151](79917); resetting faction !!!!!!!!!!!!!!

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
uncertain
Category
Typos/Content
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Tester information (Internal use only)

Additional info

errors on the left > suggested fix on the right

Do a text search of what is on the left of ">" to find all instances.

DUIPLICATE > DUPLICATE

sucessfull > successful

Blueptrint > Blueprint

[SQL] Fetching connection (may take some if game crashed on the run before) > [SQL] Fetching connection (may take some time if game crashed on the run before)

SenableGameState > SendableGameState

[CLIENT] not logged int to server: discarding pong > [CLIENT] not logged into server: discarding pong

SECTORPROXMITY > SECTORPROXIMITY

[RESOURCE] EQUEUING ALL RESOURCES! >[RESOURCE] ENQUEUING ALL RESOURCES!

omnious > ominous

dissapear > disappear

ExaustPlum > ExhaustPlume

SimpeStarField > SimpleStarField

EFFECT IS NOT CUTTENTLY ACTIVE null > EFFECT IS NOT CURRENTLY ACTIVE null

[message] should be [MESSAGE]

Message's tag are in lowercase instead of being in upper case like all other tags.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptMay 25 2016, 4:08 PM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.May 26 2016, 5:48 AM
SmilingDemon updated the task description. (Show Details)
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Category from none/unspecified to Typos/Content.
SmilingDemon claimed this task.
SmilingDemon triaged this task as Trivial priority.
SmilingDemon merged a task: T1486: Typo: [SREVER] should be [SERVER].May 26 2016, 5:51 AM
SmilingDemon updated the task description. (Show Details)
SmilingDemon added a subscriber: SmilingDemon.

-Feedback-

what is the significant problem with the second typo ?

erthparadine added a comment.May 26 2016, 6:39 AM

Any sort of log parsing gets more complicated, if we can't depend upon the tags; wouldn't it be more accurate for [SREVER] to instead match other similar entries and say [SERVER] instead?

Croquelune added a comment.May 26 2016, 2:28 PM

T1157 - Typos in File name and config files

erthparadine added a comment.May 26 2016, 2:29 PM

Thinking about this more...another way of looking at this, is that logs are spammed with all kinds of junk or otherwise uninteresting information at times. For instance T1484 is a perfect illustration of completely useless log spam, an issue that's happening this very moment.

Other times, there's [CC] entries that we often can't do anything about, the persistent nullPointer shield error that has stuck around for months (T1384), or the bored player looking to chat up a spider (T1399). We're talking the need to parse dozens of log entries per second, and doing so without bogging the server down is difficult if we're sorting on whole-lines. Being able to depend upon some consistency in log tags is incredible useful.

SmilingDemon changed the task status from Open to In Queue (Game).May 26 2016, 4:37 PM

-Confirmed-

Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptMay 26 2016, 4:37 PM
erthparadine added a comment.May 30 2016, 5:08 PM

Typo: CUTTENTLY should be CURRENTLY

This is amongst more odd log entries...trying to isolate causes of current lag, but logs are not being helpful:

[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: object local update of 882 objects took 74
[2016-05-30 16:50:27] [UNIVERSE] WARNING: Sector UPDATE took 157; sectors updated: 318
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: UNIVERSE update took 157
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] EFFECT IS NOT CUTTENTLY ACTIVE null
[2016-05-30 16:50:27] EFFECT IS NOT CUTTENTLY ACTIVE null
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: object local update of Ship[MX101 Hades 30052016](2127) took 104
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] [SERVER][RAIL] collision time limit reached. Returning to last possible
[2016-05-30 16:50:27] [SERVER][RAIL] collision time limit reached. Returning to last possible
[2016-05-30 16:50:27] [SERVER][RAIL] collision time limit reached. Returning to last possible
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: object local update of 882 objects took 180
[2016-05-30 16:50:27] [UNIVERSE] WARNING: Sector UPDATE took 157; sectors updated: 318
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: UNIVERSE update took 157
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] [SERVER][RAIL] collision time limit reached. Returning to last possible
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: object local update of 882 objects took 99
[2016-05-30 16:50:27] [UNIVERSE] WARNING: Sector UPDATE took 155; sectors updated: 318
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: UNIVERSE update took 155
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:27] [SERVER][UPDATE] WARNING: object local update of 882 objects took 87
[2016-05-30 16:50:28] [UNIVERSE] WARNING: Sector UPDATE took 157; sectors updated: 318
[2016-05-30 16:50:28] [SERVER][UPDATE] WARNING: UNIVERSE update took 157
[2016-05-30 16:50:28] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:28] EFFECT IS NOT CUTTENTLY ACTIVE null
[2016-05-30 16:50:28] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:28] [SERVER][UPDATE] WARNING: object local update of Ship[MX101 Hades 30052016](2127) took 104
[2016-05-30 16:50:28] PDLDLKDJLKDJLKDJLKDJLKDJDLKJD
[2016-05-30 16:50:28] [SERVER][UPDATE] WARNING: object local update of 882 objects took 172

The PDLDLKDJLKDJLKDJLKDJLKDJDLKJD string is already covered by T1484

SmilingDemon merged a task: T1742: Spelling errors/ missing words in log file.Jul 27 2016, 9:10 PM
SmilingDemon edited Tester information (Internal use only). (Show Details)
SmilingDemon added a subscriber: spunkie.
SmilingDemon edited Tester information (Internal use only). (Show Details)Jul 27 2016, 9:15 PM
Croquelune added a comment.Aug 3 2016, 5:51 PM

typo in log.txt

[2016-08-03 00:07:12] [CLIENT][CHAT] [message] [SERVER]: XXXX a rejoint la partie.

[message] should be [MESSAGE]

Message's tag are in lowercase instead of being in upper case like all other tags.

SmilingDemon edited Tester information (Internal use only). (Show Details)Aug 3 2016, 7:13 PM
schema changed the task status from In Queue (Game) to Resolved.Aug 10 2016, 6:07 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 10 2016, 6:07 PM
lancake edited Tester information (Internal use only). (Show Details)Aug 11 2016, 2:27 PM
erthparadine added a comment.Sep 19 2016, 5:05 PM

Not resolved, note 1st line:

[VERION] loading version from install dir: ./StarMade/
[VERSION] VERSION: 0.199.217
[VERSION] BUILD: 20160910_183953
SmilingDemon added a comment.Sep 19 2016, 5:20 PM

@erthparadine ... not supposed to be fixed ... all those typos where moved to an outside excel sheet (or something like that) ... at least it was the plan to do that.

erthparadine added a comment.Sep 19 2016, 5:22 PM

Ah, Schema's response on August 10th confused me. Thanks for clarifying.

lancake added a subscriber: lancake.Sep 19 2016, 8:41 PM
lancake closed this task as Rejected.

Wasn't completely fixed, moved typos/content mistakes to a google sheet.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptSep 19 2016, 8:41 PM
Restricted Application added a project: Typos. · View Herald TranscriptMar 10 2017, 6:12 PM