Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1399

Starmade | Talking to spiders causes nullPointer
Closed, FinishedPublic
Actions

Description

This universe is barely three days old...

In our universe, the spider was found in a derelict station at 49, 1, 1843 ...players had purchased and made it home.

[2016-05-02 23:23:34] [DIALOG] CONVERSATION PARTNER: AIComCreature[(ENTITY_CREATURE_1462231393141_0)(16807)]
[2016-05-02 23:23:34] [DIALOG] LOADING: aiState[NULL_PROGRAM]

[2016-05-02 23:23:34] javax.script.SimpleBindings@1079c842
[2016-05-02 23:23:34] aiState[NULL_PROGRAM]

[2016-05-02 23:23:34] DialogSystem instantiated aiState[NULL_PROGRAM]

[2016-05-02 23:23:34] org.schema.game.common.data.player.dialog.DialogSystem@53da8f5a
[2016-05-02 23:23:34] [LUA] ARGUMENTS for hookFunc: []
[2016-05-02 23:23:34] org.luaj.vm2.LuaError: script:23 bad argument: userdata expected, got string
[2016-05-02 23:23:34]   at org.luaj.vm2.LuaValue.argerror(Unknown Source)
[2016-05-02 23:23:34]   at org.luaj.vm2.LuaValue.checkuserdata(Unknown Source)
[2016-05-02 23:23:34]   at org.luaj.vm2.lib.jse.JavaMethod$Overload.call(Unknown Source)
[2016-05-02 23:23:34]   at org.luaj.vm2.LuaClosure.execute(Unknown Source)
[2016-05-02 23:23:34]   at org.luaj.vm2.LuaClosure.call(Unknown Source)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.DialogSystem.load(SourceFile:51)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.PlayerConversation.createOnServer(SourceFile:305)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.PlayerConversationManager.handleClientHail(SourceFile:189)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.PlayerConversationManager.handleUpdate(SourceFile:120)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.PlayerConversationManager.updateOnActive(SourceFile:81)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.PlayerState.updateLocal(SourceFile:1324)
[2016-05-02 23:23:34]   at org.schema.game.server.controller.GameServerController.update(SourceFile:1284)
[2016-05-02 23:23:34]   at org.schema.schine.network.server.ServerController.run(SourceFile:256)
[2016-05-02 23:23:34]   at java.lang.Thread.run(Thread.java:745)
[2016-05-02 23:23:34] [CONVERSATION][LUA] PlS[J_Triggs [triggjo2]; id(1388)(9)f(10311)] -> AIPlayer(Spider, 16807): SCRIPT FINISHED CREATING: creature-general.lua
[2016-05-02 23:23:34] java.lang.NullPointerException
[2016-05-02 23:23:34]   at obfuscated.aqJ.getStateCurrent(SourceFile:110)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.PlayerConversation.updateServer(SourceFile:73)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.PlayerConversation.update(SourceFile:57)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.dialog.PlayerConversationManager.updateOnActive(SourceFile:91)
[2016-05-02 23:23:34]   at org.schema.game.common.data.player.PlayerState.updateLocal(SourceFile:1324)
[2016-05-02 23:23:34]   at org.schema.game.server.controller.GameServerController.update(SourceFile:1284)
[2016-05-02 23:23:34]   at org.schema.schine.network.server.ServerController.run(SourceFile:256)
[2016-05-02 23:23:34]   at java.lang.Thread.run(Thread.java:745)
[2016-05-02 23:23:34] [SERVER] Exception catched
[2016-05-02 23:23:34] [SERVER][UPDATE] WARNING: object local update of 1653 objects took 91
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [190]] to RegisteredClient: ErthParadine (34) [Erth Paradine]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Sir_Rob_DSM (36) [Sir_Rob_DSM]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Ick (48) [Nick AShby]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Samil (10) [Samil]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: J_Triggs (9) [triggjo2]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Nocturna (20) [Nocturna]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Raptor_One_5 (47) [JonCN]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Gnatg (3) [Gnatg]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Adaptivdeath (38) [adaptivedeath]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Ender (41) [Magmaf451]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: MLG (31) [paxtonc]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: TheGeek007 (46) [TheGeek007]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Cuyoya2 (14) [Cuyoya]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Feyy (30) [Fey Zeal]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: EpicLeveler (27) [tjoli1]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: eliteman45 (7) [eliteman45]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Frost (37) [FrostMan]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: zhen (42) [zhen]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: imnapr (44) [imnapr]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: spocklin (45) [spocklin]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: ErthParadine (34) [Erth Paradine]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Wolfe (8) [lordWolfe]connected: true
[2016-05-02 23:23:35] [SEND][SERVERMESSAGE] [SERVERMSG (type 3): [373, NullPointerException]] to RegisteredClient: Glandalf_TheBrown (40) [Glandalf_TheB

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.198.139
Category
Engine
First occurrence (version)
0.197.51
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Find spider
  2. Strike up a conversation
  3. Server throws a nullPointer error (spamming all logged-in players once every 5 seconds).
Tester information (Internal use only)

New logs from the test server:

log.txt.059 KBDownload

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptMay 2 2016, 11:44 PM
erthparadine updated the task description. (Show Details)May 3 2016, 12:05 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.May 3 2016, 2:03 AM
AndyP updated the task description. (Show Details)
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
AndyP added a subscriber: AndyP.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.
AndyP triaged this task as High priority.

-Validated-

AndyP changed Affected Gamemode(s) from none/unspecified to Serverside.May 3 2016, 2:05 AM
AndyP changed Category from none/unspecified to Engine.
Chandler claimed this task.May 3 2016, 1:53 PM
Ithirahad added a subscriber: Ithirahad.EditedMay 5 2016, 1:48 PM

If this is just a Lua script error, this might be a good time to fix Lua script error handling in general, not just this script. One script crash should not spam everyone with a nullpointer until the server restarts.

lancake added subscribers: Chandler, lancake.May 14 2016, 10:01 PM
lancake claimed this task.

-Confirmed-

Taking over and pushing in queue.
New logs from the test server:

log.txt.059 KBDownload

lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.May 14 2016, 10:01 PM
lancake edited Steps to reproduce. (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Affected Gamemode(s) from Serverside to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.197.53.
lancake set First occurrence (version) to 0.197.51.
lancake changed the task status from Open to In Queue (Game).May 14 2016, 10:09 PM
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptMay 14 2016, 10:09 PM
schema changed the task status from In Queue (Game) to Resolved.Jun 4 2016, 6:27 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 4 2016, 6:27 PM
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jun 4 2016, 8:28 PM
lancake closed this task as Closed.

-QA Testing-

Can talk with them again without crashing, yay!

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 4 2016, 8:28 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.197.53 to 0.198.139.Jun 4 2016, 8:28 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:13 PM