Page MenuHomeSchine - Phabricator

Starmade | Typos in File name and config files
Closed, FinishedPublic

Description

I was looking for the parameter which is handling the background so I opened the settings.cfg file, then the search module with CTRL+F and typed BACKGROUND, I was surprised that the search found nothing. I have eventually found it manually line 121 with this ortho :

G_USE_HIGH_QUALITY_ACKGROUND =

"ackground" should be correct "background" since most of users would instinctively search as me "back" in the module in order to find the parameter.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
v. 0.19556
Category
Typos/Content
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

  1. Open your settings.cfg
  2. Look at line 121

the name of lastClientStartVerion.txt in the games install folder should be lastClientStartVersion.txt


in /logs the file graphcisinfo.txt should be graphicsinfo.txt

Tester information (Internal use only)

typo is there

how ever ... the settings.cfg itself isnt required to be manually searched for anything because the settings should be handled through the games menu.

its developers decision to spent time and effort to change it or not


found in settings.cfg:

C_MOUSE_BUTTOM_SWITCH = false //Switch build/remove mouse buttons
c_mouse_BUTTON_switch

G_MAX_SEGEMENTSDRAWN = 10000 //Max segments Drawn at once (view distance)
g_max_SEGMENTSdrawn

G_DRAW_EXHAUST_PLUMS = true //Draw thruster plums
g_draw_exhaust_PLUMES

G_DRAW_BACKGOUND = true //Background Image
g_draw_BACKGROUND

G_FRUSTUM_CULLTING = true
g_frustum_CULLING

G_FRAMRATE_FIXED = 30 //Limit Framerate (30, 60, 120, 240, or -1 for unlimited),
g_FRAMERATE_fixed

G_DEUBG_LINE_DRAWING_ACTIVATED = false
g_DEBUG_line_drawing_activated

N_SERVERTIME_UPDATE_FREQUENCE = 10000
n_servertime_update_FREQUENCY

G_USE_HIGH_QUALITY_ACKGROUND = true
g_use_high_quality_BACKGROUND

G_USE_TWO_COMPENENT_SHADER = false
g_use_two_COMPONENT_shader

And not sure about this one, but it seems like it ought to be g_water_USES_mipmaps:
G_WATER_USER_MIPMAPS = false


Here are some more from server.cfg:

PLANET_SPECIAL_REGION_PROPABILITY
planet_special_region_PROBABILITY

MAX_SIMULTANIOUS_EXPLOSIONS
max_SIMULTANEOUS_explosions

USE_OLD_GENRATED_PIRATE_STATIONS
use_old_GENERATED_pirate_stations

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
G_USE_HIGH_QUALITY_ACKGROUND = true

Event Timeline

Croquelune updated the task description. (Show Details)Feb 17 2016, 7:55 AM
Croquelune changed Category from none/unspecified to Typos/Content.
Croquelune edited Serverconfig (server.cfg). (Show Details)
Croquelune edited Clientconfig (settings.cfg). (Show Details)
Croquelune changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Croquelune changed Reproducible from uncertain to Yes.
Croquelune set Last tested (version) to v. 0.19556.
Croquelune edited Steps to reproduce. (Show Details)
Croquelune added a subscriber: Croquelune.
Croquelune created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptFeb 17 2016, 7:55 AM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.Feb 17 2016, 7:24 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon set Task Type to Bug.
SmilingDemon set OS-Specific to No.
SmilingDemon set Hardware-Specific to No.
SmilingDemon set Video Card Vendor to uncertain.
SmilingDemon triaged this task as Trivial priority.
SmilingDemon changed the task status from Open to In Queue (Game).Feb 17 2016, 7:30 PM

-validated-
-confirmed-

how ever ... the settings.cfg itself isnt required to be manually searched for anything because the settings should be handled through the games menu.

its developers decision to spent time and effort to change it or not

Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptFeb 17 2016, 7:30 PM
SmilingDemon edited Tester information (Internal use only). (Show Details)Feb 17 2016, 7:30 PM

its developers decision to spent time and effort to change it or not

Yes. But it would be definitely more mods friendly (I guess some peoples would create some launcher's skins, etc.).

SmilingDemon edited Steps to reproduce. (Show Details)
SmilingDemon added a subscriber: SmilingDemon.
SmilingDemon renamed this task from Typo ACKGROUND instead of BACKGROUND in settings.cfg to Typos in File name and config files.
Valck added a subscriber: Valck.Jul 14 2016, 2:13 PM

found in settings.cfg:

C_MOUSE_BUTTOM_SWITCH = false //Switch build/remove mouse buttons
c_mouse_BUTTON_switch

G_MAX_SEGEMENTSDRAWN = 10000 //Max segments Drawn at once (view distance)
g_max_SEGMENTSdrawn

G_DRAW_EXHAUST_PLUMS = true //Draw thruster plums
g_draw_exhaust_PLUMES

G_DRAW_BACKGOUND = true //Background Image
g_draw_BACKGROUND

G_FRUSTUM_CULLTING = true
g_frustum_CULLING

G_FRAMRATE_FIXED = 30 //Limit Framerate (30, 60, 120, 240, or -1 for unlimited),
g_FRAMERATE_fixed

G_DEUBG_LINE_DRAWING_ACTIVATED = false
g_DEBUG_line_drawing_activated

N_SERVERTIME_UPDATE_FREQUENCE = 10000
n_servertime_update_FREQUENCY

G_USE_HIGH_QUALITY_ACKGROUND = true
g_use_high_quality_BACKGROUND

G_USE_TWO_COMPENENT_SHADER = false
g_use_two_COMPONENT_shader

And not sure about this one, but it seems like it ought to be g_water_USES_mipmaps:
G_WATER_USER_MIPMAPS = false

Valck added a comment.Jul 14 2016, 2:17 PM

its developers decision to spent time and effort to change it or not

Yes. But it would be definitely more mods friendly (I guess some peoples would create some launcher's skins, etc.).

That, and the variables are read and written from code, so it may be more maintenance friendly and less error prone to correct these things early on, especially once more than one developer works at it.

thanks for the list .. will add them to the info above

SmilingDemon edited Tester information (Internal use only). (Show Details)Jul 14 2016, 2:59 PM
SmilingDemon raised the priority of this task from Trivial to Low.
Valck added a comment.EditedJul 14 2016, 4:13 PM

Here are some more from server.cfg:

PLANET_SPECIAL_REGION_PROPABILITY
PLANET_SPECIAL_REGION_ PROBABILITY

MAX_SIMULTANIOUS_EXPLOSIONS
MAX_ SIMULTANEOUS_EXPLOSIONS

USE_OLD_GENRATED_PIRATE_STATIONS
USE_OLD_ GENERATED_PIRATE_STATIONS

SmilingDemon edited Tester information (Internal use only). (Show Details)Jul 14 2016, 6:33 PM
Valck added a comment.EditedJul 17 2016, 4:47 PM

FactionConfig(Template).xml:

<PenatlyPerDistanceUnitFromHomeBase>
<PenaltyPerDistanceUnitFromHomeBase>


blockBehaviorConfig.xml (and its derivatives):

<ShieldDockTrasferLimit>
<ShieldDock TransferLimit>

<ShipRebootTimeMultiplyerPerMass>
<ShipRebootTime MultiplierPerMass>

<IntertiaPow>
<InertiaPow>

STATUS_ARMOR_HP_ABSORBTION_BONUS
STATUS_ARMOR_HP_ ABSORPTION_BONUS

<DefensiveBaseMultiplicator> (not a typo, but inconsistent use of multiplier/multiplicator)
<DefensiveBase Multiplier>

in several comments, copy/paste:
<!-- 0 tu turn off nerf-->
<!-- 0 to turn off nerf-->


mainConfig.xml:

<ExaustPlum filename="exaustplum">
<Exhaust Plume filename="exhaustplume">

<Meelee>
<Melee>

<Type>aracnic</Type>
<Type>arachnid</Type>

schema changed the status of subtask T1420: Typo in FactionConfig.xml and FactionConfigTemplate.xml from In Queue (Game) to Resolved.Aug 10 2016, 6:50 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 10 2016, 6:51 PM
lancake closed this task as Closed.

-QA Testing-

Most of these were fixed, the few that weren't are written down in a separate doc. Tasks like these are confusing especially since many keep adding errors/typos that were already mentioned somewhere else.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptAug 11 2016, 3:47 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
Restricted Application added a project: Typos. · View Herald TranscriptMar 10 2017, 6:17 PM