Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1420

Starmade | Typo in FactionConfig.xml and FactionConfigTemplate.xml
Closed, FinishedPublic
Actions

Description

Which one should it be?
Penatly
or
Penalty

From a vanilla build:

~$ grep -r PerDistanceUnitFromHomeBase StarMade/
StarMade/data/config/FactionConfig.xml:			<PenatlyPerDistanceUnitFromHomeBase>2</PenatlyPerDistanceUnitFromHomeBase>
StarMade/customFactionConfig/FactionConfigTemplate.xml:			<PenatlyPerDistanceUnitFromHomeBase>2</PenatlyPerDistanceUnitFromHomeBase>
~$ grep -r FromCenterMult StarMade/
StarMade/data/config/FactionConfig.xml:			<PenaltyFromCenterMult>10</PenaltyFromCenterMult>
StarMade/customFactionConfig/FactionConfigTemplate.xml:			<PenaltyFromCenterMult>10</PenaltyFromCenterMult>

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.144
Category
Typos/Content
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

Open FactionConfig.xml
search for "Penatly"

Open FactionConfigTemplate.xml
search for "Penatly"

Tester information (Internal use only)

dont know if the typo does matter, but should be corrected because it would surely cause problem if someone corrects it in the custom faction config by chance

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects
Search...

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptMay 12 2016, 10:39 PM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.May 13 2016, 4:28 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon edited Steps to reproduce. (Show Details)
SmilingDemon edited Tester information (Internal use only). (Show Details)
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Single and Multi.
SmilingDemon changed Reproducible from uncertain to Yes.
SmilingDemon set Last tested (version) to 0.197.53.
SmilingDemon changed Category from none/unspecified to Typos/Content.
SmilingDemon renamed this task from Typo in vanilla config to Typo in FactionConfig.xml and FactionConfigTemplate.xml.
SmilingDemon changed the task status from Open to In Queue (Game).May 13 2016, 4:31 PM

-Validated-
-Confirmed-

Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptMay 13 2016, 4:31 PM
SmilingDemon moved this task from Unclassed to Issue affecting current release on the Starmade board.May 13 2016, 4:31 PM
SmilingDemon triaged this task as High priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptMay 13 2016, 4:31 PM
schema changed the task status from In Queue (Game) to Resolved.Aug 10 2016, 6:50 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 10 2016, 6:50 PM
erthparadine added a comment.Aug 10 2016, 8:33 PM

Will the server automatically make these corrections in existing config files, or should admins be made aware of manual adjustments at the next update?

lancake added a subscriber: lancake.Aug 11 2016, 3:06 PM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed. On update the file typo gets adjusted so no need to manually change something.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptAug 11 2016, 3:06 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.197.53 to 0.199.144.Aug 11 2016, 3:06 PM
erthparadine added a comment.EditedAug 13 2016, 12:15 AM
In T1420#70718, @lancake wrote:

-QA Testing-
Fix confirmed. On update the file typo gets adjusted so no need to manually change something.

That is incorrect. It in fact makes no attempt to update an existing customFactionConfig/FactionConfig.xml

Aug 12 20:59:16 stars SMPrd: org.schema.common.ConfigParserException: FactionPointGalaxy-> BasicValues -> PenatlyPerDistanceUnitFromHomeBase: No appropriate f
ield found for tag: PenatlyPerDistanceUnitFromHomeBase
Aug 12 20:59:16 stars SMPrd: (FixSuggestion: check your xml config files)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.common.data.player.faction.config.FactionConfig.parse(SourceFile:201)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.common.data.player.faction.config.FactionConfig.load(SourceFile:93)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.common.data.player.faction.config.FactionConfig.load(SourceFile:51)
Aug 12 20:59:16 stars SMPrd: #011at obfuscated.afg.<init>(SourceFile:123)
Aug 12 20:59:16 stars SMPrd: #011at obfuscated.Yw.<init>(SourceFile:139)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.server.controller.GameServerController.initializeServerState(SourceFile:1673)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.schine.network.server.ServerController.startServerAndListen(SourceFile:364)
Aug 12 20:59:16 stars SMPrd: #011at obfuscated.Uh.run(SourceFile:1448)
Aug 12 20:59:16 stars SMPrd: #011at java.lang.Thread.run(Thread.java:745)
Aug 12 20:59:16 stars SMPrd: [IO][COPY] FILE FROM /opt/prodStarmade/StarMade/./data/config/FactionConfig.xml to /opt/prodStarmade/StarMade/./customFactionConfig/FactionConfigError.xml
Aug 12 20:59:16 stars SMPrd: [IO][COPY] FILE FROM /opt/prodStarmade/StarMade/./customFactionConfig/FactionConfigTemplate.xml to /opt/prodStarmade/StarMade/./data/config/FactionConfig.xml
lancake added a comment.EditedAug 13 2016, 10:37 AM
In T1420#71045, @erthparadine wrote:
In T1420#70718, @lancake wrote:

-QA Testing-
Fix confirmed. On update the file typo gets adjusted so no need to manually change something.

That is incorrect. It in fact makes no attempt to update an existing customFactionConfig/FactionConfig.xml

Aug 12 20:59:16 stars SMPrd: org.schema.common.ConfigParserException: FactionPointGalaxy-> BasicValues -> PenatlyPerDistanceUnitFromHomeBase: No appropriate f
ield found for tag: PenatlyPerDistanceUnitFromHomeBase
Aug 12 20:59:16 stars SMPrd: (FixSuggestion: check your xml config files)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.common.data.player.faction.config.FactionConfig.parse(SourceFile:201)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.common.data.player.faction.config.FactionConfig.load(SourceFile:93)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.common.data.player.faction.config.FactionConfig.load(SourceFile:51)
Aug 12 20:59:16 stars SMPrd: #011at obfuscated.afg.<init>(SourceFile:123)
Aug 12 20:59:16 stars SMPrd: #011at obfuscated.Yw.<init>(SourceFile:139)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.game.server.controller.GameServerController.initializeServerState(SourceFile:1673)
Aug 12 20:59:16 stars SMPrd: #011at org.schema.schine.network.server.ServerController.startServerAndListen(SourceFile:364)
Aug 12 20:59:16 stars SMPrd: #011at obfuscated.Uh.run(SourceFile:1448)
Aug 12 20:59:16 stars SMPrd: #011at java.lang.Thread.run(Thread.java:745)
Aug 12 20:59:16 stars SMPrd: [IO][COPY] FILE FROM /opt/prodStarmade/StarMade/./data/config/FactionConfig.xml to /opt/prodStarmade/StarMade/./customFactionConfig/FactionConfigError.xml
Aug 12 20:59:16 stars SMPrd: [IO][COPY] FILE FROM /opt/prodStarmade/StarMade/./customFactionConfig/FactionConfigTemplate.xml to /opt/prodStarmade/StarMade/./data/config/FactionConfig.xml

I was talking about the data/config/FactionConfig.xml file which is always updated so if a custom one is being used, you'll indeed need to manually change it. I should have clarified about that, my bad.
EDIT: Same goes for the template.

Restricted Application added a project: Typos. · View Herald TranscriptMar 10 2017, 6:13 PM