Page MenuHomeSchine - Phabricator
Create Task
Maniphest T684

Starmade | Shop permission resets to All possibly when server restarts
Closed, FinishedPublic
Actions

Description

I play on starside and have a shop on my homebase that resets permission to all. I am not sure if it is connected to a server restart but that seems likely.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.199.511
Category
Tradenetwork/Shops
First occurrence (version)
0.198.xxx
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. spawn a station block
  2. /force_save
  3. put a shop block on it
  4. in the shop options tab, change permissions (I used ALLIES CAN SHOP and ALLIED OWNED SHOP)
  5. unload/load that sector or restart the server

Should be back to what it was at the very start.

Tester information (Internal use only)

Not fixed, see Steps to Reproduce

Event Timeline

Jarraff updated the task description. (Show Details)Sep 20 2015, 12:17 AM
Jarraff edited Serverconfig (server.cfg). (Show Details)
Jarraff edited Clientconfig (settings.cfg). (Show Details)
Jarraff added a subscriber: Jarraff.
Jarraff created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 20 2015, 12:17 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Sep 21 2015, 11:00 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "All Users".
AndyP set Task Type to Bug.
AndyP set Category to Engine.
AndyP set Affected Gamemode(s) to Multiplayer.
AndyP set Reproducible to uncertain.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
AndyP added a subscriber: AndyP.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.
AndyP triaged this task as Normal priority.

-Validated-

spunkie claimed this task.Sep 22 2015, 12:44 AM
spunkie added a comment.Sep 22 2015, 3:50 PM

-Confirmed-

Reproduced on the official test server no restart involved.

Set the shop to faction only then admin tped 4 sectors away and waited for a faction point event, came back permissions were still in place. Tped 4 sectors away again and this time logged out, came back about 10 minutes later, checked shop it was reset to "All". Reset the permissions and logged out without tping away, came back 30 minutes later shop still had permissions set to faction. Tped away and logged out, logged on and tped back, shop was set to all permission.

spunkie changed the task status from Open to In Queue (Game).Sep 22 2015, 3:50 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptSep 22 2015, 3:50 PM
AndyP added a comment.Sep 22 2015, 7:01 PM

So as short way:

Login near a "faction only" shop,
teleport away, teleport back
and it is set to all?

(tp away and back was within one minute? so the sector did not get unloaded? or were you "away" when an autosave occurs)

Chandler added a subscriber: Chandler.Sep 22 2015, 7:26 PM

This has been the case for months if not years. I have never been able to get the perms to stick on the shop..And I could have sworn there was already a case open on it..

AndyP added a comment.Sep 24 2015, 9:43 PM

We never had those issues, and I know back in the beginning of buy-by-block times there was a problem with this and you could bypass it, it always saved, so it has to be broken recently (last 3-6 months) not much longer.

HerrSticks added a subscriber: HerrSticks.Nov 4 2015, 10:01 PM

Occasionally it seems that the shops will also delete the owner, and then assign the first person to interact with it as owner.

I have no idea how to reproduce it and it happens very infrequently. However it has happened 4 times to me with player owned shops now.

Sorry I cannot provide more information.

plusnine added a subscriber: plusnine.EditedNov 4 2015, 10:07 PM

To my memory, shop owning has never failed me. In fact, I've seen strange things like shops loading from blueprint load with with their owners still listed from when they were saved.

However, I believe Chandler is correct: the faction-restriction toggle vs. all vs. owner has never managed to stick for me, in a year of checking at least every release.

HerrSticks added a comment.EditedNov 4 2015, 10:57 PM

I've noticed the owners loading from blueprints as well.

However, as I stated on 4 occasions now I will be an owner of a shop that I have never previously visited.

I fly up, hit B and then I'm the displayed the owner...

I never claimed any ownership, nor was it given to me by another player.

AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:13 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:13 PM
schema added a subscriber: schema.Mar 12 2017, 5:54 PM
schema changed the task status from In Queue to Resolved.

Fixed with NPC/Trading update

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 12 2017, 5:54 PM
lancake added a subscriber: lancake.Mar 13 2017, 11:03 AM
lancake changed the task status from Resolved to In Queue.

-QA Testing-

Not fixed, updated the Steps to Reproduce section.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 13 2017, 11:03 AM
lancake edited Steps to reproduce. (Show Details)Mar 13 2017, 11:05 AM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.199.483.
lancake changed Category from Engine to Tradenetwork/Shops.
lancake set First occurrence (version) to 0.198.xxx.
lancake added a subscriber: spunkie.
lancake claimed this task.
Restricted Application edited projects, added Tradenetwork; removed Engine. · View Herald TranscriptMar 13 2017, 11:05 AM
lancake edited Steps to reproduce. (Show Details)Mar 13 2017, 11:07 AM
AndyP moved this task from Backlog / Unclassed to Alpha on the Tradenetwork board.Mar 15 2017, 4:12 PM
AndyP edited projects, added Game Development (Alpha); removed Game Development.
schema added a commit: Restricted Diffusion Commit.Apr 5 2017, 12:32 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application added a project: Quality Assurance. · View Herald TranscriptApr 5 2017, 12:32 PM
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Apr 10 2017, 1:51 PM

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 0.199.483 to 0.199.511.Apr 10 2017, 1:51 PM
lancake closed this task as Closed.Apr 28 2017, 1:25 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 28 2017, 1:25 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript