tested in dev ver 0.19401

ship test
results:

1. made a ship equipped with cannon main, damage beam secondary
2. spawned pirate wave of custom ship using /initiate_wave -1 1
3. moved out to 2900 meters which was far enough for pirates to stop engaging
4. approached pirates without radar jammer active and pirates start firing at ~2722 meters (pirate weapon capable of 6000 meters)
5. returned to 2900 meters away from pirates to disengage
6. approached pirates with radar jammer active and pirates start firing at ~1522 meters

https://youtu.be/J7XtUqx1QF4

station test
results:

1. c aligned to station, targeting station for distance measurements
2. began station approach with radar jammer inactive starting at 2000 meters ( "prate"station turrets max range of 2000 meters)
3. turrets begin firing at ~1930 meters
4. returned to 2000 meters turrets no longer firing
5. begin approach with radar jammer active
6. turrets begin firing at ~1910 meters

https://youtu.be/Vpp2og4JuzQ

not sure what author meant by extremely small therefore not sure if this is still a problem

-QA testing-

partial fix confirmed

The damage beam with damage beam secondary is unusually low compared to the other weapons with radar jammer active vs inactive.

In certain instances the pirates will detect and move to a certain distance from you and stop without firing, even though the ai acts like you are there, it will refuse to fire but it seems the radar jammer is not the major factor except in the case of the damage beam with damage beam secondary.

If this requires an ai overhaul then suggested goals;

• Hostile ai should have a detection range that is constant across all weapon types, or if variance is desired, base it upon ship mass/dimensions of the potential target and if ambitious, include whether the target is moving or not.
• Upon detection hostile ai should move till its weapons are in range of target, given that damage pulse range is so short and would result in laggy unnecessary collisions, a minimum distance should be established, but if the target moves within that distance, and into the damage pulse range, the ai should fire the damage pulse, whilst trying to increase distance beyond the min range. This should take care of http://phab.starma.de/T287
• If the hostile ai takes fire from something beyond its detection range it should move toward the direction it took fire from, to prevent situations described in http://phab.starma.de/T286
• I've also noticed that the mothership does not take into account its turret mounted weapons for purposes of movement this ship exhibits the behavior{F3197}
• Ai should check if a weapon has the range to hit a target before firing. Curently if one of the weapons is in range then all weapons are fired.

Radarjammer doesn't really have any purpose anymore regarding AI and their behavior. Not sure what will happen to them so I'll leave this task open for now.

Checked again and it works again like it should so putting back in queue