Page MenuHomeSchine - Phabricator

Starmade | Display Module tag powercap & shieldcap have typos
Closed, FinishedPublic

Description

The actual [powerCap] and [shieldCap] should be rename [powercap] and [shieldcap]

This capital C is absolutely senseless and prevent fluid memorization of the tags since [power] and [shield] tags don't have any caps.

I didn't merge with T1307 - Content/typos part 2 because these typos aren't only concerning "Display Help" menu but impact the ingame interaction and can lead to that situation:

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.615
Category
Typos/Content
First occurrence (version)
0.198.135
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Put Display Module
  2. Write [powercap] and [shieldcap]
  3. Tags aren't invoke but [powercap] and [shieldcap] are written in clear instead.
Tester information (Internal use only)

we discussed this a bit further
it should be decided by development
probably best for it to be not case sensitive at all.
so making PowerCap - POWERcap - powerCap basically the same and not breaking any already existing versions while at the same time give the user the choice on how to remember those tags best.
(especialy when there will be more of them in the future)

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptMay 28 2016, 9:44 AM
lancake closed this task as Rejected.
lancake claimed this task.

-rejected-

Maybe it doesn't make sense to you, but it does to me. I think in this case it's just personal preference that matters.

We may change it to lower case if we expand the display variables.

lancake shifted this object from the S1 Public space to the S3 Starmade space.Jun 2 2016, 12:43 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
Restricted Application edited projects, added Starmade; removed Issue Navigation. · View Herald TranscriptJun 2 2016, 12:43 PM

Ok but in this case why the generic [power] and [shield] instead of [Power] and [Shield] ?

Display variables should have only one way to be invoked. Crossbreed situation like this bring just confusion and doesn't facilitate memorization.

all caps = [Power], [Shield], [PowerCap], [ShieldCap] = 1 logic rule to apply = easy memorization (+ bonus easy to read & indentify concept)
no caps = [power], [shield], [powercap], [shieldcap] = 1 logic rule to apply = easy memorization (but less easy to read; i.e. powerregen if one day it show up)
crossbreed situation [power], [shield], [powerCap], [shieldCap] = no logic rule to apply, just a fact to memorize = with memorization not based on any rational rules it will inevitably be more difficult and less spontaneous to invoke variables properly "de tête".

SmilingDemon reopened this task as In Queue (Game).
SmilingDemon claimed this task.

-Confirmed-
we discussed this a bit further
it should be decided by development
probably best for it to be not case sensitiv at all.
so making PowerCap - POWERcap - powerCap basically the same and not breaking any already existing versions while at the same time give the user the choice on how to remember those tags best.
(especialy when there will be more of them in the future)

Restricted Application added a project: Game Development. · View Herald TranscriptJun 2 2016, 5:15 PM
SmilingDemon edited Tester information (Internal use only). (Show Details)Jun 2 2016, 5:16 PM
SmilingDemon moved this task from Unclassed to Issue affecting current release on the Starmade board.
SmilingDemon triaged this task as Low priority.

probably best for it to be not case sensitiv at all.

Glad to see that my remark wasn't meaningless. :) Your advocated solution sounds good since it should please all sides and preserve reliabitiy between old-new system.
With just 4 variables it's not really a big deal right now nor a developping priority anyway, it was rather in anticipation of possible new variables. A coherent name system is always better than a chaotic one.

AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:21 PM
Restricted Application added a project: Typos. · View Herald TranscriptMar 10 2017, 5:21 PM
AndyP moved this task from Backlog / Unclassed to Beta on the Typos board.Mar 15 2017, 1:15 PM

A bit late to the party, but this isn't a chaotic naming system. It's using lower camel-casing.
First word has lower case letter, any subsequent first letters of other words are capitalized.

likeThisWouldBeLowerCamelCasing

I suppose not caring about caps at all makes more sense then, shouldn't result in any inconsistencies considering you need to put it between [ ] anyway.

lancake added a commit: Restricted Diffusion Commit.Jun 12 2017, 12:31 PM
lancake changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application added a project: Quality Assurance. · View Herald TranscriptJun 12 2017, 12:31 PM

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 0.198.135 to 0.199.615.Jun 22 2017, 3:47 PM
lancake set First occurrence (version) to 0.198.135.
lancake closed this task as Closed.Jun 22 2017, 11:46 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 22 2017, 11:46 PM