Page MenuHomeSchine - Phabricator

Starmade | Entity with docked entities isn't being hit reliably by missiles
Closed, FinishedPublic

Description

While testing another issue we have seen that we could not damage a target ship with missiles reliably.

Out of 5 shots most of the time 3 got ignored completely and shots that did connect, dealt delayed damage together with another missile.

After undocking the docked entities every shot hit perfectly and got counted correctly. As long as entities are docked the shield hit graphics effect is not showing for missile hits either.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19242
Category
Control Block System: Rails/Docking
First occurrence (version)
0.19228
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>
Java Version (32bit)

Event Timeline

lancake updated the task description. (Show Details)Jun 2 2015, 8:57 PM
lancake changed Category from none/unspecified to Control Block System: Rails/Docking.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19228.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19242.
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake edited Java Version (32bit). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJun 2 2015, 8:57 PM
AndyP changed the task status from Open to In Queue (Game).
AndyP changed the task status from In Queue (Game) to Open.
AndyP added a subscriber: AndyP.Jun 2 2015, 9:03 PM
AndyP changed the task status from Open to In Queue (Game).

confirmed

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 2 2015, 9:06 PM
Restricted Application removed a project: Starmade. · View Herald TranscriptJun 3 2015, 4:15 PM
schema added a commit: Restricted Diffusion Commit.Jun 3 2015, 7:33 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 3 2015, 7:33 PM
lancake lowered the priority of this task from High to Normal.
lancake changed the task status from Resolved to In Queue (Game).Jun 10 2015, 9:35 PM

It seems to work better now but far from perfect.

This example was done on a mothership with 1 docked entity, on that docked entity another docked ship.
The missile I fired hit the mothership and its blast radius hit the 2 docked entities, so in total 3 entities got hit.
This missile does 14 400 damage.

There are 2 situations now:

  1. Both docked entities have no shields or below 50% of their max shield HP (so that shield sharing does not kick in and absorb X damage)
    • the mothership received 4800 shield damage (missile damage/number of entities hit == 14 400/3).
    • the next shot inflicted 24 000 shield damage, both shots should do a total of 28 800 damage which is indeed what happens but it seems the value displayed after the first shot is incorrect.
  1. Both docked entities have more than 50% of their shield HP
    • inconsistent behavior, I don't really have a clue what's going on there, sorry :/
    • for my setup, it seemed that each missile inflicted around 10-20% more shield damage than it should do, probably this has to do with the damage getting divided by 3, and also shield sharing kicking in to absorb a part and perhaps this is accumulative, causing you to deal more damage.
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJun 10 2015, 9:35 PM
schema added a commit: Restricted Diffusion Commit.Jun 11 2015, 3:48 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 11 2015, 3:48 PM
lancake changed the task status from Resolved to In Queue (Game).EditedJun 13 2015, 9:29 AM
  • the next shot inflicted 24 000 shield damage, both shots should do a total of 28 800 damage which is indeed what happens but it seems the value displayed after the first shot is incorrect.

This is still the case.
From what I've seen, it is only displaying/dealing accurate damage for every X missiles fired and the amount of missiles required to fire to see the right amount of damage dealt depends on how many docks got hit, I think...

Same missile example as in previous note (14 400 damage per missile)

Example:

  • Every 2 shots my total damage on shields was 28 800 damage which is correct (14 400 * 2), for every shot between that it was around 7 200 damage, which is half of the damage it should do. The 2nd shot dealt then 21 600 damage.
  • Sometimes It's every 3 shots, depending on how many entities you hit with your blast radius.

Note: http://phab.starma.de/T6 and http://phab.starma.de/T9 are pretty much about the same thing now

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJun 13 2015, 9:29 AM
schema added a subscriber: schema.Jun 18 2015, 6:07 PM

hrm, probably not easily fixable without missile redesign. Problem being that missile hit detection hits every shield within the bounding box, even if no block is inside radius. This makes it inaccurate as more docked entities are hit than it seems

AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 8:54 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP edited Java Version (32bit). (Show Details)
lancake claimed this task.Sep 21 2015, 10:48 AM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:23 PM
Restricted Application added a project: CBS: Rails. · View Herald TranscriptMar 10 2017, 5:23 PM
AndyP closed this task as Closed.Mar 11 2017, 10:49 PM

Missile overhaul covered this.
If not, please create a new report with details on how to reproduce.

Restricted Application removed a project: Game Development. · View Herald TranscriptMar 11 2017, 10:49 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript