Page MenuHomeSchine - Phabricator

Starmade | shop upper limit and lower limit do not work
Confirmed task for development, LowPublic

Description

Shop values are out of the expected boundaries.

Example:
Faction module is base price 2000 credits (or dynamic price 1500).

The config suggest that's a maximum of 2000*1.2=2400 credits or 1500*1.2=1800 but in game I saw a faction module with price 2661. Price variations do seem a lot smaller now but it's out of bounds nonetheless.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19247 (Dev)
Category
Tradenetwork/Shops
First occurrence (version)
0.1867
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 8 2015, 9:48 AM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Universe.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.1867.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Low.
lancake changed the task status from Open to In Queue (Game).Jun 8 2015, 2:56 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 8 2015, 2:56 PM
schema added a commit: Restricted Diffusion Commit.Jun 12 2015, 12:09 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 12 2015, 12:09 AM
lancake changed the task status from Resolved to In Queue (Game).Jun 12 2015, 6:53 PM

I checked all new shops. Their prices seem to be all on the maximum allowed value which is for me: Dynamic price * 1.2.
I emptied a few stocks, did /update_shop_prices, even let the sector unload/load again but the price is the same.

Seems that the price scaling does not work but at least it is within expected values.

The setting I used was SHOP_USE_STATIC_SELL_BUY_PRICES = false, which states prices should be dynamic when on false. However it seems to be the opposite, setting this to true makes the prices change again, or at least temporary since /update_shop_prices only worked once...

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJun 12 2015, 6:53 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:30 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
lancake claimed this task.Sep 21 2015, 10:48 AM
lancake mentioned this in Unknown Object (Maniphest Task).Apr 17 2016, 10:39 AM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:10 PM
Restricted Application added a project: Universe. · View Herald TranscriptMar 10 2017, 5:10 PM
AndyP changed Category from Universe to Tradenetwork/Shops.Mar 15 2017, 4:16 PM
Restricted Application edited projects, added Tradenetwork; removed Universe. · View Herald TranscriptMar 15 2017, 4:16 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the Tradenetwork board.Mar 15 2017, 4:16 PM
AndyP edited projects, added Game Development (Alpha); removed Game Development.