Page MenuHomeSchine - Phabricator

Starmade | All weapons don't always hit the 1st entity in line of sight
Closed, FinishedPublic

Description

It seems that docking beams will hit the entity docked on your target even if that docked entity is not visible to you (->targeting a block but hitting the docked ship behind)

(the grey and glass blocks infront are targeted by the docking beam, the yellow blocks behind belong to a second entity docked)

Beam works normal if there isn't anything behind

Beam hitting the docked blocks behind (has nothing to do with the glass blocks, it will pass through as many blocks as there are if the docked entity is in range of the beam)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19484 (Dev)
Category
Control Block System: Rails/Docking
First occurrence (version)
0.19476
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

NuclearFun updated the task description. (Show Details)Sep 20 2015, 6:12 PM
NuclearFun changed the visibility from "Custom Policy" to "Public (No Login Required)".
NuclearFun changed the edit policy from "Task Author" to "All Users".
NuclearFun changed Category from none/unspecified to Control Block System: Rails/Docking.
NuclearFun edited Serverconfig (server.cfg). (Show Details)
NuclearFun edited Clientconfig (settings.cfg). (Show Details)
NuclearFun added a subscriber: NuclearFun.
NuclearFun created this task.
NuclearFun raised the priority of this task from to Needs Triage/Unclassed.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 20 2015, 6:12 PM
NuclearFun updated the task description. (Show Details)Sep 20 2015, 7:50 PM
NuclearFun set Task Type to Bug.
NuclearFun set Affected Gamemode(s) to none/unspecified.
NuclearFun set Reproducible to uncertain.
NuclearFun set OS-Specific to No.
NuclearFun set Hardware-Specific to No.
NuclearFun set Video Card Vendor to uncertain.
Oninoni claimed this task.Sep 21 2015, 1:39 PM
Oninoni added a subscriber: Oninoni.
Oninoni removed Oninoni as the assignee of this task.
Oninoni triaged this task as Normal priority.

-Validated-

spunkie claimed this task.Sep 22 2015, 1:59 PM

-Confirmed-

Not only is the docking beam hitting docked entities behind the mothership, but the core beam is able to activate logic behind it as well.

https://youtu.be/cleN-vdr4YQ

Further testing reveals that cannons and damage beams also bypass mothership to hit docked entities behind it.

https://youtu.be/lOmD5wwfDp8

spunkie changed the task status from Open to In Queue (Game).Sep 22 2015, 2:50 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptSep 22 2015, 2:50 PM

This also applies to power supply and shield supply beams.

spunkie set Last tested (version) to 0.19476 dev.Nov 3 2015, 9:27 PM
spunkie changed Affected Gamemode(s) from none/unspecified to Single and Multi.
spunkie changed Reproducible from uncertain to Yes.
AssIn9 added a subscriber: AssIn9.Nov 4 2015, 4:02 AM
lancake added subscribers: lancake, Comr4de, SchnellBier and 3 others.
lancake renamed this task from Docking beams hitting the docked entity behind to Beams don't hit the 1st entity.
lancake raised the priority of this task from Normal to Release Blocker.
lancake shifted this object from the S1 Public space to the S3 Starmade space.Nov 5 2015, 4:57 PM
lancake changed the edit policy from "All Users" to "Starmade (Project)".
lancake set First occurrence (version) to 0.19476.
lancake changed Last tested (version) from 0.19476 dev to 0.19480 (Dev).
lancake changed the task status from In Queue (Game) to Open.
Restricted Application edited projects, added Issue Navigation; removed Game Development. · View Herald TranscriptNov 5 2015, 4:57 PM

This needs retesting, seems most beams can't hit most targets.

lancake added a comment.EditedNov 5 2015, 5:30 PM

It's an odd bug that doesn't always happen. You can see it easily on planets though if you fire long enough. It also applies for cannons, missiles and pulse but that's sometimes harder to reproduce. Everything mentioned below is done with damage beams.

If 2 entities overlap each other from where you're looking (raycast goes through 2 entities or more) it will almost always think you're aiming + shooting the one behind the entity you're aiming for. You can easily see this with 2 planet plates near their border.

Gif: I start shooting the planet plate on the left (you see damage, debris helps as indication), I start aiming on the other planet plate but the game thinks i'm still shooting the one I started on. I'm still dealing damage to that left plate but I'm obviously shooting through the right plate because of that.

NOTE: For docked entities it's slightly different, the blue beam effect you get on hit is there, the damage numbers also display on the correct block and the beams seem to hit the spot you're aiming on too...but the actual damage is done on the entity behind the docked entity you're shooting at. (Cannons/missiles and pulse don't hit it properly either)
lancake renamed this task from Beams don't hit the 1st entity to Beams/Cannons don't hit the 1st entity.Nov 5 2015, 5:31 PM
lancake changed the task status from Open to In Queue (Game).Nov 5 2015, 5:34 PM
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptNov 5 2015, 5:34 PM
lancake renamed this task from Beams/Cannons don't hit the 1st entity to All weapons don't always hit the 1st entity in line of sight.Nov 5 2015, 5:35 PM
schema added a commit: Restricted Diffusion Commit.Nov 5 2015, 6:52 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 5 2015, 6:52 PM
AssIn9 added a comment.EditedNov 5 2015, 6:57 PM

The beams in my testing, will hit the first entity of a type in its path.

for example, I use power supply beams from docked entity on my ships. The beam will pass through the ship and effect the next docked entity instead of the ship. But when a ship crosses into the path of the beam, it will ignore any docked entity and the ship its docked to and effect the other ship that has crossed into its path.

in current live release.

mclaih added a comment.Nov 5 2015, 9:15 PM

Since the other ticket got merged with this one since the last update the power supply beams are now passing through a lot of entities.
Before 0.19476 the power supply beams were mostly hitting the first block in its way. Sometimes I would see what I assumed was a graphical glitch of the beam passing through the ship but it was very rare even with 96 x 2 alternating power supply beams.
After update 0.19476 I'm getting power supply beams on docked power modules passing through up to 2 sections of main ship (1 section is 40+ layers of jump modules), 2 sections of a docked shield module attached to the main ship only to hit a 3rd section of the shield module. Also sometimes pass through all of that to hit the forward docked weapon modules. Approximately over half of them are passing through at least two sections of main hull.

Some are stopping at the first block of the main ship or shield module they are running through but its completely random by the looks. The same power supply beam will hit the same target per cycle of ticks. But the next activation will randomly ignore various entities in the way.

lancake closed this task as Closed.Nov 6 2015, 9:31 PM

-QA Testing-

Checked every type of weapon and multiple situations where I could reproduce it, not happening anymore => fix confirmed!

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptNov 6 2015, 9:31 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.19480 (Dev) to 0.19484 (Dev).Nov 6 2015, 9:31 PM

One other thing to consider, the mother ship can fire through docked entities.

This will lead to problems where the mother ship falls below 50% shields and attempts to use positioned shield supply beams to protect a docked entity exposed to the exterior.

Another problem would be you are in a turret that overheats and the mothership is firing swarmers, you are inside but the swarmers pass through the wall to kill you.

Not sure if that warrants its own bug report or should reopen this one.

https://youtu.be/-UKZXJWAZHk

Restricted Application added a project: CBS: Rails. · View Herald TranscriptMar 10 2017, 6:25 PM