Page MenuHomeSchine - Phabricator

Starmade | BlockConfigImport.xml loses nested tabs.
Closed, FinishedPublic

Description

If there is a structure tabs(for example
):

<DeathStar>

<MOD>
   <BasicComponents>
      blocks
   </BasicComponents>
   <PirateArmor>
     blocks
   </PirateArmor>
 </MOD>

</DeathStar>

After imports, in game is seen :

<DeathStar>

<BasicComponents>
   blocks
</BasicComponents>
<PirateArmor>
  blocks
</PirateArmor>

</DeathStar>

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
starmade-build_20150820_221933
Category
Blockconfig
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain

Event Timeline

Zeta-X11 updated the task description. (Show Details)Aug 30 2015, 11:18 AM
Zeta-X11 changed Category from none/unspecified to Blockconfig.
Zeta-X11 changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Zeta-X11 changed Reproducible from uncertain to Yes.
Zeta-X11 set Last tested (version) to starmade-build_20150820_221933.
Zeta-X11 edited Serverconfig (server.cfg). (Show Details)
Zeta-X11 edited Clientconfig (settings.cfg). (Show Details)
Zeta-X11 added a subscriber: Zeta-X11.
Zeta-X11 created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 30 2015, 11:18 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 30 2015, 9:42 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
AndyP added a subscriber: AndyP.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.
AndyP triaged this task as Low priority.

-Validated-

An example BlockConfigImport.xml would probably help in this case.

Agree.

Here's an example:

There should be a structure:

<Config> 
	<Element> 
		<DeathStar>
		CUSTOM_ID_003
			<example1>
			CUSTOM_ID_002
				<example2>
				CUSTOM_ID_001
					<example3>
					CUSTOM_ID_000
					</example3>	
				</example2>	
			</example1>
		</DeathStar>
	</Element> 
</Config>

In Game:

plusnine added a subscriber: plusnine.EditedOct 15 2015, 12:09 AM

i also have noticed the ability to create groups in only certain sections of the XML have been removed in recent releases:

several custom groups of blocks in my custom pack ( http://starmadedock.net/content/plusnines-default-pack-extension-for-servers-and-clients.3201/ ) worked, but after some patches those in custom groups inside the "Decoration" and "Terrain" category ceased to appear until i removed their custom group tabs. I am currently able to create new sub-groups within the "Hull" category, however.

blocks placed into groups in the XML that do not supsequently appear in shops are effectively <InShop>false</InShop> - in that they do not appear in shops or creative mode, but still may be spawned via ID / name using the "/give" or "/giveid" admin commands.

This bug report has been in the open queue far to long, I shall take a crack at putting this into queue as no one else seems to want to.

I would like to make note that I personally have no experience with XML files

I would "assume" nested tabs mean a tab within a tab within a tab or something of that nature.

-Feedback-

This bug report was very hard to do but I was able to get nested tabs to work.
Clearly there is something I am missing so I require some more information.

Firstly, I require a full example config file for the release build (I test on dev but will not require you to modify your config to dev)

Secondly I require a detailed example of what you are trying to do to compare to what i've done.

Thirdly can you confirm this is still an issue? are you 100% sure this isn't an XML formatting issue?

As you can see here I was able to get nested tabs to work:


<--- My config file I used to test (note this is for dev build)

Thanks, Zackey.

It has been a few patches since I have tried to put custom groups that were working back in. I will try again on my next texture pack release and report what happens.

It has been a few patches since I have tried to put custom groups that were working back in. I will try again on my next texture pack release and report what happens.

A reminder to format it correctly, His code he posted did not work.

Zeta-X11 added a comment.EditedNov 20 2015, 1:00 PM

BlockConfig.xml <--- My config file I used to test (note this is for dev build)

--This is the result of imports BlockConfigImport.xml?

My


Continues to lose nesting.

And when you restart the game
according to the bug reports http://phab.starma.de/T589
breaks BlockConfig.xml (before the test necessary to make it backup)

Perhaps these bugs are related.

XML is true.

The Test Block Config Import.hml
between
<Block ----------------->
and
</ Block>
You can not fill.
When you import the game fills the missing fields.

Option with fields filled the same tested.
The result is identical.

Tested on version 0.19492.

Still unable to reproduce, Asumming was fixed with the compl

BlockConfig.xml <--- My config file I used to test (note this is for dev build)

--This is the result of imports BlockConfigImport.xml?
My


Continues to lose nesting.
And when you restart the game
according to the bug reports http://phab.starma.de/T589
breaks BlockConfig.xml (before the test necessary to make it backup)

Perhaps these bugs are related.

XML is true.
The Test Block Config Import.hml
between
<Block ----------------->
and
</ Block>
You can not fill.
When you import the game fills the missing fields.
Option with fields filled the same tested.
The result is identical.
Tested on version 0.19492.

Wouldn't this be down to poor XML formatting, I was able to get nested tabs to work perfectly fine provided I formatted it correctly.

Skip through http://www.freeformatter.com/xml-formatter.html .
At the exit:

<Config>
   <Element>
      <example0>
         <Block icon="530" name="CUSTOM_ID_007" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_007">
            <Armour>0</Armour>
         </Block>
         <example1>
            <Block icon="530" name="CUSTOM_ID_006" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_006">
               <Armour>0</Armour>
            </Block>
            <example2>
               <Block icon="530" name="CUSTOM_ID_005" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_005">
                  <Armour>0</Armour>
               </Block>
               <example3>
                  <Block icon="530" name="CUSTOM_ID_004" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_004">
                     <Armour>0</Armour>
                  </Block>
               </example3>
            </example2>
         </example1>
      </example0>
      <DeathStar>
         <Block icon="530" name="CUSTOM_ID_003" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_003">
            <Armour>0</Armour>
         </Block>
         <example1>
            <Block icon="530" name="CUSTOM_ID_002" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_002">
               <Armour>0</Armour>
            </Block>
            <example2>
               <Block icon="530" name="CUSTOM_ID_001" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_001">
                  <Armour>0</Armour>
               </Block>
               <example3>
                  <Block icon="530" name="CUSTOM_ID_000" textureId="33, 33, 33, 33, 33, 33" type="CUSTOM_ID_000">
                     <Armour>0</Armour>
                  </Block>
               </example3>
            </example2>
         </example1>
      </DeathStar>
   </Element>
</Config>

...No, it is the same thing.
No formatting.

Can I see your BlockConfigImport.xml ?

AndyP changed the task status from Open to Feedback.Feb 21 2017, 8:53 PM
Restricted Application added projects: Starmade, Waiting on Author. · View Herald TranscriptFeb 21 2017, 8:53 PM
Restricted Application added a project: Waiting on Author. · View Herald TranscriptMar 10 2017, 5:48 PM
AndyP closed this task as Closed.May 11 2021, 3:06 PM

Waiting for feedback for a long time now.
Cleanup -> Closed

Restricted Application edited projects, added Blockconfig; removed Waiting on Author, Issue Navigation. · View Herald TranscriptMay 11 2021, 3:06 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript