Page MenuHomeSchine - Phabricator
Create Task
Maniphest T580

Starmade | Nullpointer while saveing of Station blueprints from multiplayer to local
Closed, FinishedPublic
Actions

Description

Problem happens with the supplied station and my own Shipyardtest on the testserver.
A simple 3 block station (shop + hull + build block) saves to local without a problem.
A more complex station did also save to local in the last pre release testing (although its logic didnt work after that)

Logpart from my test on testserver

[2015-08-28 19:04:23] [SENDABLESEGMENTVONTROLLER][WRITE] WARNING: segment writing of SpaceStation[ENTITY_SPACESTATION_TradeGuild_1_1_1426018311945(10664)] on Client(27) took: 61 ms (file header: 0ms)
[2015-08-28 19:04:23] [GLFRAME] THROWN: class java.lang.NullPointerException Now Printing StackTrace
[2015-08-28 19:04:23] java.lang.NullPointerException
[2015-08-28 19:04:23] 	at org.schema.game.common.controller.elements.shipyard.ShipyardCollectionManager.getStateByteOnServer(SourceFile:1669)
[2015-08-28 19:04:23] 	at org.schema.game.common.controller.elements.shipyard.ShipyardCollectionManager.toTagStructurePriv(SourceFile:782)
[2015-08-28 19:04:23] 	at org.schema.game.common.controller.elements.ControlBlockElementCollectionManager.toTagStructure(SourceFile:279)
[2015-08-28 19:04:23] 	at org.schema.game.common.controller.elements.UsableControllableElementManager.toTagStructure(SourceFile:552)
[2015-08-28 19:04:23] 	at org.schema.game.common.controller.elements.ManagerContainer.toTagStructure(SourceFile:1266)
[2015-08-28 19:04:23] 	at obfuscated.alc.a(SourceFile:982)
[2015-08-28 19:04:23] 	at obfuscated.alc.a(SourceFile:754)
[2015-08-28 19:04:23] 	at obfuscated.ahX.a(SourceFile:1001)
[2015-08-28 19:04:23] 	at obfuscated.UZ.a(SourceFile:725)
[2015-08-28 19:04:23] 	at org.schema.game.common.data.player.PlayerState.handleBluePrintQueuesClient(SourceFile:3446)
[2015-08-28 19:04:23] 	at org.schema.game.common.data.player.PlayerState.updateLocal(SourceFile:1162)
[2015-08-28 19:04:23] 	at obfuscated.C.a(SourceFile:3058)
[2015-08-28 19:04:23] 	at obfuscated.C.update(SourceFile:1171)
[2015-08-28 19:04:23] 	at obfuscated.aqC.a(SourceFile:1171)
[2015-08-28 19:04:23] 	at obfuscated.aqC.a(SourceFile:1162)
[2015-08-28 19:04:23] 	at obfuscated.C.h(SourceFile:2731)
[2015-08-28 19:04:23] 	at obfuscated.KS.run(SourceFile:92)
[2015-08-28 19:04:23] 	at java.lang.Thread.run(Unknown Source)

Full log of one of these crashes:

log.txt.1356 KBDownload

to reproduce

  1. Load in this station to a Multiplayer server (local dedicated will do)
    Factory und Yard.sment10 KBDownload
  2. try to take a blueprint of it with the save to local option

Note: original reporter claimed it was broken before the shipyard update... i cant confirm that

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.19414 (Dev)
Category
Engine
First occurrence (version)
0.19401
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
User/Reporter/Contact
URL to Starmadedock thread
http://starmadedock.net/threads/cant-create-blueprint-of-station.20615/#post-224858
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

SmilingDemon updated the task description. (Show Details)Aug 28 2015, 5:22 PM
SmilingDemon added projects: Issue Navigation, Starmade.
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Category from none/unspecified to Engine.
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Multiplayer.
SmilingDemon set First occurrence (version) to 0.19401.
SmilingDemon changed Reproducible from uncertain to Yes.
SmilingDemon set Last tested (version) to 0.19412 (Dev).
SmilingDemon edited Serverconfig (server.cfg). (Show Details)
SmilingDemon edited Clientconfig (settings.cfg). (Show Details)
SmilingDemon set URL to Starmadedock thread to http://starmadedock.net/threads/cant-create-blueprint-of-station.20615/#post-224858.
SmilingDemon added a subscriber: SmilingDemon.
SmilingDemon created this task.
SmilingDemon claimed this task.
SmilingDemon raised the priority of this task from to Release Blocker.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptAug 28 2015, 5:22 PM
SmilingDemon changed the task status from Open to In Queue (Game).Aug 28 2015, 5:24 PM

-validate-
-confirmed-

yes .. i know :/

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptAug 28 2015, 5:24 PM
spunkie added a subscriber: spunkie.EditedAug 29 2015, 10:43 PM
spunkie claimed this task.

happens for me too in 0.19414
https://youtu.be/bv_XNvfOxfI

the crash only affects the client that attempts the blueprint save to local. other clients in the sector are not affected unless they too try to blueprint save to local.

logs

graphcisinfo.txt238 BDownload

threaddump159.txt11 KBDownload

threaddump158.txt11 KBDownload

serverlog.txt.0.64 KBDownload

threaddump160.txt27 KBDownload

log.txt.0.8146 KBDownload

log.txt.0.7134 KBDownload

log.txt.0.6289 KBDownload

spunkie set Task Type to Bug.Aug 29 2015, 10:43 PM
spunkie changed Last tested (version) from 0.19412 (Dev) to 0.19414 (Dev).
spunkie set OS-Specific to No.
spunkie set Hardware-Specific to No.
spunkie set Video Card Vendor to uncertain.
spunkie removed spunkie as the assignee of this task.
schema added a commit: Restricted Diffusion Commit.Aug 31 2015, 11:41 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 31 2015, 11:41 PM
Restricted Application added a subscriber: Megacrafter127. · View Herald Transcript
SmilingDemon closed this task as Closed.Sep 1 2015, 5:40 PM

-QA Testing-

Fixed

Shipyard stations can now be saved to local

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptSep 1 2015, 5:40 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP removed SmilingDemon as the assignee of this task.Sep 7 2015, 9:05 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:27 PM