Page MenuHomeSchine - Phabricator

Starmade | Reboot keyboard shortcut doesn't reboot new power reactors
Closed, FinishedPublic

Description

The button 'Y' is set for 'Reboot Systems'
Rebooting through this popup dialogue, doesn't actually reboot the reactor HP.
You have to use the "RECALIBRATE HP" button in the Tree reactor panel.

Note that the old reboot works slightly different, in this case, rebooting through Y should also be denied if it's still on cooldown (for new power reactors). The cooldown could be put as a countdown in the top left corner perhaps: "X secs till you can reboot".

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.282
Category
Control Block System: Functional
First occurrence (version)
0.200.2xx
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. make a new power reactor
  2. damage it
  3. reboot by pressing 'Y'
  4. reactor HP is not changed after it is done.
Tester information (Internal use only)

Rebooting works, but you get no notification if you try to reboot while it's still on cooldown. You can see the popup dialogue appear, you can press OK, and you would think it rebooted.

I suggest to change the "OK" button into a "WAIT X" with the reactor cooldown as seconds, like how the ship core spawn protection works.

Serverconfig (server.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>

Event Timeline

lancake created this task.Jan 3 2018, 8:51 PM
lancake created this object in space S3 Starmade.
lancake created this object with visibility "Public (No Login Required)".
lancake created this object with edit policy "Starmade (Project)".
Restricted Application edited projects, added Issue Navigation, Dev-Return; removed Game Development. · View Herald TranscriptJan 3 2018, 8:51 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Open to In Queue.Jan 3 2018, 8:51 PM
schema added a commit: Restricted Diffusion Commit.Jan 4 2018, 11:23 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJan 4 2018, 11:23 AM
lancake changed the task status from Resolved to In Queue.EditedJan 4 2018, 6:03 PM

-QA Testing-

Rebooting works, but you get no notification if you try to reboot while it's still on cooldown. You can see the popup dialogue appear, you can press OK, and you would think it rebooted.

I suggest to change the "OK" button into a "WAIT X" with the reactor cooldown as seconds, like how the ship core spawn protection works.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJan 4 2018, 6:03 PM
lancake edited Tester information (Internal use only). (Show Details)Jan 4 2018, 6:03 PM
schema added a commit: Restricted Diffusion Commit.Jan 5 2018, 4:31 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJan 5 2018, 4:31 PM
lancake closed this task as Closed.

-QA Testing-

Works fine now, the reboot description itself though is displaying the wrong value for me but that seems to be caused by T2782.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 7 2018, 7:23 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.200.277 to 0.200.282.Jan 7 2018, 7:24 PM