Page MenuHomeSchine - Phabricator

Starmade | Recalibrating HP (rebooting) is instant
Closed, FinishedPublic

Description

If you re-calibrate the HP of your reactor, it is instantly back with nothing preventing you from using it to its fullest.

It should be similar to the current reboot mechanic. X seconds after pressing it before it actually happens, and while that is happening, you have no recharge. Can't build or remove either, and any block damage will bring it out of the reboot timer and you would need to restart it again.

Needs config values for seconds though, based on initial reactor size.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.289
Category
Control Block System: Functional
First occurrence (version)
0.200.2xx
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Tester information (Internal use only)

Saves and loads fine for both rebooting and switching, but I seem to have run into a few more issues:


Odd issue between client and server config.
My client is using custom config with 50-60 second timers. The test server uses default 15 and 10 sec timer.

The timers I'm getting on the test server are the ones from my client though.


The OK button does not display "WAIT (X)" if you have to reboot a overheating ship, by pressing R on the ship core.

Serverconfig (server.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>

Event Timeline

lancake created this task.Dec 22 2017, 2:04 PM
lancake created this object in space S3 Starmade.
lancake created this object with visibility "Public (No Login Required)".
lancake created this object with edit policy "Starmade (Project)".
Restricted Application edited projects, added Issue Navigation, Dev-Return; removed Game Development. · View Herald TranscriptDec 22 2017, 2:04 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Open to In Queue.
schema added a commit: Restricted Diffusion Commit.Dec 29 2017, 1:38 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 29 2017, 1:38 AM
schema added a subscriber: schema.Dec 29 2017, 1:39 AM

since having a delay on same reactor boot would be inconsistent, I added a cooldown value that gets set on any damage.

This means that a reactor can still be switched instantly to another (like intended), but rebooting the same reactor cannot be done when it received any damage.

lancake changed the task status from Resolved to In Queue.Dec 29 2017, 2:17 PM

-QA Testing-

Partial fix, 2 remaining issues:


  1. The reboot time does not get saved on unload/server shut down. You can simply log out/in again (provided you're alone in the sector) and it will instantly be rebooted. For large ships with a reboot of 60-100 seconds, this can be very useful to reduce it all to ~30 seconds

  1. The reboot when not overheating is using the reactor reboot config values. The reboot when it's already overheated uses the old "ShipRebootTime..." values. The reactor reboot config values should be used always.
Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptDec 29 2017, 2:17 PM
lancake edited Tester information (Internal use only). (Show Details)Dec 29 2017, 2:18 PM
lancake changed Last tested (version) from 0.200.269 to 0.200.272.
schema added a commit: Restricted Diffusion Commit.Jan 2 2018, 4:00 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJan 2 2018, 4:00 PM
lancake changed the task status from Resolved to In Queue.Jan 4 2018, 5:22 PM

-QA Testing-

Partial fix, same as before:

The reboot time does not get saved on unload/server shut down. You can simply log out/in again (provided you're alone in the sector) and it will instantly be rebooted.
This goes for both the reboot time of recalibrating HP, and the reactor switch cooldown from when you switch reactors. Tested in SP with 100 second config values for both recalibration and reactor switching.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJan 4 2018, 5:22 PM
lancake edited Tester information (Internal use only). (Show Details)Jan 4 2018, 5:22 PM
lancake changed Last tested (version) from 0.200.272 to 0.200.277.
schema added a commit: Restricted Diffusion Commit.Jan 5 2018, 3:50 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJan 5 2018, 3:50 PM
lancake changed the task status from Resolved to In Queue.Jan 7 2018, 7:30 PM

-QA Testing-

Saves and loads fine for both rebooting and switching, but I seem to have run into a few more issues:


Odd issue between client and server config.
My client is using custom config with 50-60 second timers. The test server uses default 15 and 10 sec timer.

The timers I'm getting on the test server are the ones from my client though.


The OK button does not display "WAIT (X)" if you have to reboot a overheating ship, by pressing R on the ship core.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJan 7 2018, 7:30 PM
lancake edited Tester information (Internal use only). (Show Details)Jan 7 2018, 7:30 PM
lancake changed Last tested (version) from 0.200.277 to 0.200.282.
schema added a commit: Restricted Diffusion Commit.Jan 8 2018, 10:47 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJan 8 2018, 10:47 AM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 13 2018, 6:16 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.200.282 to 0.200.289.Jan 13 2018, 6:17 PM