Page MenuHomeSchine - Phabricator

Starmade | Shield visuals do not work with local shields
Closed, FinishedPublic

Description

The shield effect/ripple you see when you shoot something, does not work with local shields.
ShieldAddOn -> public double handleShieldHit(...) redirects it to the new local shields, but the old visuals were handled further down that method, and is never reached now.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.162
Category
Control Block System: Systems
First occurrence (version)
0.200.144
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. make a local shield (and make sure it has power)
  2. shoot at it with any weapon
  3. no graphical effect
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Nov 4 2017, 2:41 PM
Restricted Application added a project: CBS: Systems. · View Herald TranscriptNov 4 2017, 2:41 PM
schema added a commit: Restricted Diffusion Commit.Nov 6 2017, 10:34 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 6 2017, 10:34 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript

-QA Testing-

Fix confirmed, T2681 does prevent it from triggering for some weapons though.

lancake changed Last tested (version) from 0.200.153 to 0.200.162.Nov 11 2017, 1:07 PM
lancake closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptNov 11 2017, 1:07 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript