Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2391

Starmade | Rail + Storage disconnecting
Closed, FinishedPublic
Actions

Description

When I log out, then back in, alot of my Rails have disconnected from their Storage. Multiple rails connected to one storage block. Sometimes disconnects when logging out-then in, not always. Cant find the pattern

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
199.625
Category
Control Block System: Rails/Docking
First occurrence (version)
199.535a
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
User/Reporter/Contact
Username on Registry
5ilence
Steps to reproduce
  1. create ship/station
  2. have a few rail basics on it
  3. link some rail basics to storage chest
  4. do create docking on any rail block

-> All rail + storage links should be gone

  1. relink them, and do create docking again
  2. links are still fine
Tester information (Internal use only)

-QA Testing-

Partially fixed.
The first time you dock something to a newly loaded structure, it will have its rail + storage links removed.
After relinking though, I'm unable to reproduce it again by docking to it. This false positive only happens once then I imagine?

Adjust steps to reproduce.

java.lang.Exception: WARNING: Irregular block connected to rail speed: (29, 66, 27)[Storage]o[FRONT][active][50hp][BLOCK]; Removing Connection
	at org.schema.game.common.controller.elements.rail.speed.RailSpeedCollectionManager.checkAllConnections(RailSpeedCollectionManager.java:97)
	at org.schema.game.common.controller.elements.rail.speed.RailSpeedElementManager.getRailSpeedForTrack(RailSpeedElementManager.java:53)
	at org.schema.game.common.controller.rails.RailController.handleRailAutoMovementDecision(RailController.java:1195)
	at org.schema.game.common.controller.rails.RailController.update(RailController.java:890)
	at org.schema.game.common.controller.SegmentController.updateLocal(SegmentController.java:2765)
	at org.schema.game.common.controller.SendableSegmentController.updateLocal(SendableSegmentController.java:404)
	at org.schema.game.common.controller.EditableSendableSegmentController.updateLocal(EditableSendableSegmentController.java:1093)
	at org.schema.game.common.controller.Ship.updateLocal(Ship.java:493)
	at org.schema.game.server.controller.GameServerController.update(GameServerController.java:1366)
	at org.schema.schine.network.server.ServerController.run(ServerController.java:275)
	at java.lang.Thread.run(Thread.java:745)

Related Objects

Event Timeline

5ilence created this task.May 13 2017, 9:49 PM
lancake moved this task from New / Unconfirmed to Feedback on the Issue Navigation board.May 14 2017, 7:35 PM
lancake added a subscriber: lancake.
lancake claimed this task.

-Feedback-

Sounds like you're experiencing some form of T2323? In your steps to reproduce you do not mention logic to switch rail connections but I cannot reproduce it with those steps.

lancake shifted this object from the S1 Public space to the S3 Starmade space.May 14 2017, 7:35 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake set First occurrence (version) to 199.535a.
lancake changed the task status from Open to Feedback.
Restricted Application added a project: Waiting on Author. · View Herald TranscriptMay 14 2017, 7:35 PM
5ilence added a comment.May 14 2017, 9:09 PM

Thanks for having a look lancake - Id previously thought it was that issue, so I tested it myself (the first time it happened was on a fleet miner carrier), but I couldnt reproduce it like that either.

It really does seem to happen intermittently, but more often than not. When there are multiple Rails linked to one Store,, Ive found that one will be left connected when the others fall off. Not sure if this is a clue.

Restricted Application edited projects, added Customer responded; removed Waiting on Author. · View Herald TranscriptMay 14 2017, 9:09 PM
Restricted Application changed the task status from Feedback to Open. · View Herald Transcript
5ilence added a comment.May 15 2017, 8:00 AM

Just logged back into the multiplayer server and all Rails have lost their links to all Stores on my station, and on all ships docked to my station. So contrary to what I previously witnessed, its not a couple of Rails, its all of them

lancake moved this task from Feedback to Confirmed on the Issue Navigation board.May 15 2017, 11:02 AM
lancake changed the task status from Open to In Queue.

Thank you for the extra information! It seems if a rail is also being used, it will cause some sort of false positive with invalid links and removes them. Not immediately though but after a restart or unloading/loading the client, they should definitely be gone.

Could also be related to T2323 since both issues are overlapping a bit.
Putting in queue.

lancake edited Tester information (Internal use only). (Show Details)May 15 2017, 11:07 AM
lancake changed Reproducible from uncertain to Yes.
lancake added a comment.EditedMay 15 2017, 11:14 AM

The false positive causing it

java.lang.Exception: WARNING: Irregular block connected to rail speed: (21, 17, 10)[Storage]o[FRONT][active][50hp][BLOCK]; Removing Connection
	at org.schema.game.common.controller.elements.rail.speed.RailSpeedCollectionManager.checkAllConnections(RailSpeedCollectionManager.java:97)
	at org.schema.game.common.controller.elements.rail.speed.RailSpeedElementManager.getRailSpeedForTrack(RailSpeedElementManager.java:53)
	at org.schema.game.common.controller.rails.RailController.handleRailAutoMovementDecision(RailController.java:1196)
	at org.schema.game.common.controller.rails.RailController.update(RailController.java:890)
	at org.schema.game.common.controller.SegmentController.updateLocal(SegmentController.java:2732)
	at org.schema.game.common.controller.SendableSegmentController.updateLocal(SendableSegmentController.java:403)
	at org.schema.game.common.controller.EditableSendableSegmentController.updateLocal(EditableSendableSegmentController.java:1168)
	at org.schema.game.common.controller.Ship.updateLocal(Ship.java:493)
	at org.schema.game.server.controller.GameServerController.update(GameServerController.java:1366)
	at org.schema.schine.network.server.ServerController.run(ServerController.java:275)
	at java.lang.Thread.run(Thread.java:745)
5ilence added a comment.May 15 2017, 8:14 PM

Awesome lancake, glad you could find the cause here! Note: I incorrectly explained the 'steps to reproduce' in the origainal task, line 4 should read 'C the Rail, and V the storage'. Always get that mixed up haha

lancake edited Steps to reproduce. (Show Details)May 15 2017, 11:06 PM
In T2391#100364, @5ilence wrote:

Awesome lancake, glad you could find the cause here! Note: I incorrectly explained the 'steps to reproduce' in the origainal task, line 4 should read 'C the Rail, and V the storage'. Always get that mixed up haha

Yep! Thanks for pointing that out ^^

lancake changed the task status from In Queue to Resolved.May 20 2017, 10:00 AM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMay 20 2017, 10:00 AM
lancake raised the priority of this task from Normal to High.Jun 7 2017, 7:48 PM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptJun 7 2017, 7:48 PM
lancake changed the task status from Resolved to In Queue.Jun 22 2017, 4:47 PM

-QA Testing-

Partially fixed.
The first time you dock something to a newly loaded structure, it will have its rail + storage links removed.
After relinking though, I'm unable to reproduce it again by docking to it. This false positive only happens once then I imagine?

Adjust steps to reproduce.

java.lang.Exception: WARNING: Irregular block connected to rail speed: (29, 66, 27)[Storage]o[FRONT][active][50hp][BLOCK]; Removing Connection
	at org.schema.game.common.controller.elements.rail.speed.RailSpeedCollectionManager.checkAllConnections(RailSpeedCollectionManager.java:97)
	at org.schema.game.common.controller.elements.rail.speed.RailSpeedElementManager.getRailSpeedForTrack(RailSpeedElementManager.java:53)
	at org.schema.game.common.controller.rails.RailController.handleRailAutoMovementDecision(RailController.java:1195)
	at org.schema.game.common.controller.rails.RailController.update(RailController.java:890)
	at org.schema.game.common.controller.SegmentController.updateLocal(SegmentController.java:2765)
	at org.schema.game.common.controller.SendableSegmentController.updateLocal(SendableSegmentController.java:404)
	at org.schema.game.common.controller.EditableSendableSegmentController.updateLocal(EditableSendableSegmentController.java:1093)
	at org.schema.game.common.controller.Ship.updateLocal(Ship.java:493)
	at org.schema.game.server.controller.GameServerController.update(GameServerController.java:1366)
	at org.schema.schine.network.server.ServerController.run(ServerController.java:275)
	at java.lang.Thread.run(Thread.java:745)
Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJun 22 2017, 4:47 PM
lancake edited Steps to reproduce. (Show Details)Jun 22 2017, 4:49 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Last tested (version) from 199.535a to 199.615.
schema added a commit: Restricted Diffusion Commit.Jun 27 2017, 12:56 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJun 27 2017, 12:56 PM
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jun 30 2017, 1:34 PM

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 199.615 to 199.625.Jun 30 2017, 1:34 PM
AndyP moved this task from Confirmed fix to Backlog / Unclassed on the Quality Assurance board.EditedJun 30 2017, 6:48 PM
AndyP changed the task status from Resolved to In Queue.

-QA Testing-

Still disconnects if connected to Load or Unload rail.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJun 30 2017, 6:48 PM
AndyP changed the task status from In Queue to Resolved.Jun 30 2017, 6:56 PM

Nvm, wrong task.

Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJun 30 2017, 6:56 PM
schema added a commit: Restricted Diffusion Commit.Jul 1 2017, 10:50 AM
lancake closed this task as Closed.Jul 7 2017, 12:34 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 7 2017, 12:34 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
schema added a commit: Restricted Diffusion Commit.Jul 17 2017, 10:25 PM
schema reopened this task as Resolved by committing Restricted Diffusion Commit.
Restricted Application added a project: Quality Assurance. · View Herald TranscriptJul 17 2017, 10:25 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the CBS: Rails board.Jul 20 2017, 11:03 PM
lancake closed this task as Closed.Jul 21 2017, 3:54 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 21 2017, 3:54 PM
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 22 2017, 9:55 PM