Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2278

Starmade | Cannot Dock Here
Closed, FinishedPublic
Actions

Description

Trying to dock a turret to a WIP build on the most recent dev build, doesnt dock, error pops up as

"Cannot Dock Here"
Reason: Can Only Dock to a ship that is not docked to itself"

I have no clue what it means, the ship im trying to dock to is not docked to anything o-o

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Serverside
Reproducible
Yes
Last tested (version)
0.199.491
Category
Control Block System: Rails/Docking
First occurrence (version)
0.199.479
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  • spawn core (use autonaming)
  • add raildocker
  • spawn another core station (again allow autonaming to do its job)
  • add rail
  • try to dock the core to the station

Result

Dock denied because of "cannot dock to itself"

  1. make a shipyard design
  2. put a rail basic on it
  3. get a real ship core and put a rail docker on it
  4. dock real ship to design by touching the rail docker with the rail basic
Tester information (Internal use only)

Can dock again ... sec still appears from time to time when you dock but I guess it doesn't matter.
Found another issue while testing this out:

  • you can touch dock any ship to a design/virtual blueprint. The entity will be converted to a design and you'll lose all those blocks of the ship you just docked. No way to undock it afterwards. Only happens with touch docking and there's no popup message asking for confirmation. Trying to beam dock doesn't do anything, no message/warning and nothing happens.

Adjusted steps to reproduce

Related Objects
Search...

StatusAssignedTask
Unknown Object (Maniphest Task)
 ClosedlancakeT2278 Cannot Dock Here
Unknown Object (Maniphest Task)

Event Timeline

Deserea created this task.Mar 11 2017, 3:40 PM
AndyP claimed this task.Mar 11 2017, 6:29 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Mar 11 2017, 6:48 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP edited Steps to reproduce. (Show Details)
AndyP edited Tester information (Internal use only). (Show Details)
AndyP changed Affected Gamemode(s) from Singleplayer to Serverside.
AndyP changed Reproducible from uncertain to Yes.
AndyP changed Last tested (version) from V0.0199.479 to 0.0199.479.
AndyP changed First occurrence (version) from V0.0199.479 to 0.0199.479.
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP moved this task from New / Unconfirmed to Confirmed on the Issue Navigation board.
AndyP renamed this task from DEV BUILD) Cannot Dock Here to Cannot Dock Here.
AndyP changed the task status from Open to In Queue.

-Confirmed-

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptMar 11 2017, 6:49 PM
Restricted Application added a project: CBS: Rails. · View Herald TranscriptMar 11 2017, 6:49 PM
AndyP raised the priority of this task from Normal to High.Mar 11 2017, 6:49 PM
schema added a commit: Restricted Diffusion Commit.Mar 11 2017, 6:52 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 11 2017, 6:52 PM
AndyP changed the task status from Resolved to In Queue.EditedMar 11 2017, 8:16 PM

Docking by beam works again for ships.
Stations still refuse to dock.

Magnetic docking is broken completely.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 11 2017, 8:16 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the CBS: Rails board.Mar 11 2017, 9:17 PM
AndyP edited Steps to reproduce. (Show Details)Mar 11 2017, 9:51 PM
AndyP edited Steps to reproduce. (Show Details)
AndyP edited Steps to reproduce. (Show Details)
AndyP added a subtask: Unknown Object (Maniphest Task).Mar 11 2017, 10:00 PM
AndyP mentioned this in Unknown Object (Maniphest Task).
AndyP added a parent task: Unknown Object (Maniphest Task).Mar 11 2017, 10:20 PM

Side effect of fixing:
{T941}
As other bug is "private" I'll keep this here for reference.

AndyP mentioned this in Unknown Object (Maniphest Task).Mar 11 2017, 10:23 PM
schema added a subscriber: schema.Mar 12 2017, 5:47 PM
schema changed the task status from In Queue to Resolved.

cannot find any problem.

tried beam/magnetic docking:

  • ship -> station OK/OK
  • ship -> ship docked to station OK/OK
  • ship -> ship OK/OK
  • ship -> ship docked on ship OK/OK
  • ship with dock -> ship OK/OK
  • ship with dock -> station OK/OK
Restricted Application added a project: Quality Assurance. · View Herald TranscriptMar 12 2017, 5:47 PM
lancake added subscribers: AndyP, lancake.EditedMar 20 2017, 3:56 PM
lancake changed the task status from Resolved to In Queue.
lancake claimed this task.

-QA Testing-

I cannot reproduce what @AndyP mentioned, docking by beam or magnetic works for ship <-> ship and ship <-> station for me.
This bug is going back in queue for small issues though:

  • Cannot dock here! Reason: Can only dock with a ship that is not docked itself! appears if you beam dock (use the raildocker beam) on a ship's rail. This doesn't appear for station docking or magnetic docking.
  • There is also a spelling mistake in there -> "a ship that is not docked to itself"
  • Can dock again in X sec appears after docking, not sure if this intended since it's something that should be shown when you undock.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptMar 20 2017, 3:56 PM
lancake edited Tester information (Internal use only). (Show Details)Mar 20 2017, 3:56 PM
lancake changed Last tested (version) from 0.0199.479 to 0.199.485.
lancake changed First occurrence (version) from 0.0199.479 to 0.199.479.
lancake edited Tester information (Internal use only). (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
schema added a comment.Mar 21 2017, 3:46 AM

You can only dock a ship that isn't already docked.

schema added a comment.Mar 21 2017, 3:54 AM

sidenote: this only happens if you try to dock on a ship that already has a docked ship elesewhere on it

schema added a commit: Restricted Diffusion Commit.Mar 21 2017, 4:12 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application added a project: Quality Assurance. · View Herald TranscriptMar 21 2017, 4:12 AM
schema added a commit: Restricted Diffusion Commit.Mar 21 2017, 3:22 PM
lancake changed the task status from Resolved to In Queue.EditedMar 22 2017, 12:18 AM

-QA Testing-

Can dock again ... sec still appears from time to time when you dock but I guess it doesn't matter.
Found another issue while testing this out:

  • you can touch dock any ship to a design/virtual blueprint. The entity will be converted to a design and you'll lose all those blocks of the ship you just docked. No way to undock it afterwards. Only happens with touch docking and there's no popup message asking for confirmation. Trying to beam dock doesn't do anything, no message/warning and nothing happens.

Adjusted steps to reproduce

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptMar 22 2017, 12:18 AM
lancake edited Steps to reproduce. (Show Details)Mar 22 2017, 12:19 AM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Last tested (version) from 0.199.485 to 0.199.491.
schema added a commit: Restricted Diffusion Commit.Apr 5 2017, 12:32 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application added a project: Quality Assurance. · View Herald TranscriptApr 5 2017, 12:32 PM
lancake changed the task status from Resolved to In Queue.Apr 14 2017, 4:39 PM

-QA Testing-

Same as before.
I can still dock a real ship to a design through touch/magnetic docking.

Restricted Application edited projects, added QA-Return; removed Quality Assurance. · View Herald TranscriptApr 14 2017, 4:39 PM
schema changed the task status from In Queue to Resolved.Apr 14 2017, 4:45 PM
Restricted Application edited projects, added Quality Assurance; removed QA-Return. · View Herald TranscriptApr 14 2017, 4:45 PM
schema added a commit: Restricted Diffusion Commit.Apr 19 2017, 12:12 PM
lancake closed this task as Closed.Jun 16 2017, 8:11 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 16 2017, 8:11 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed the status of subtask Unknown Object (Maniphest Task) from Resolved to In Queue.Jun 21 2017, 8:45 AM