Page MenuHomeSchine - Phabricator

Starmade | shopkeep can't be respawned
Closed, FinishedPublic

Description

i noticed on the Server FreaksRUs that the shop keep had died , so i tried to re spawn him with the shop, but apparently that isnt working. i also tried to manually spawn one in, that didnt work either. both me and the server owner got into single player and discovered that once the shop keep is killed he cannot be re spawned in.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.614
Category
Crew/NPCs
First occurrence (version)
0.199.132
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. try to use the "respawn shopkeep" function by pressing R on the top decorative block in the spawn shop.
Tester information (Internal use only)

It was working fine before the chunk 32 update. After that it broke.
Most likely the "respawn shopkeep" function is still located at its old block coordinates and wasn't moved to its new position after the chunk 32 update.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

A_Uchiha created this task.Aug 22 2016, 1:35 AM
lancake claimed this task.

-rejected-

You can spawn an NPC and give him the shop keeper script to follow.

  1. /spawn_creature

-> target NPC

  1. /creature_script npc-trading-guild.lua

We probably need to have something to automatically respawn dead npc's for advanced shops. Probably something for later.

lancake shifted this object from the S1 Public space to the S3 Starmade space.Aug 22 2016, 12:14 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake closed this task as Rejected.
lancake triaged this task as Low priority.
Restricted Application removed a project: Issue Navigation. · View Herald TranscriptAug 22 2016, 12:15 PM

the shop keep used to respawn on its own , and there was a block that allowed us to spawn them

AndyP moved this task from Unclassed to Archived on the Starmade board.Aug 26 2016, 10:29 AM
lancake reopened this task as Open.Sep 9 2016, 8:12 PM

apparently you could summon him before.

Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 9 2016, 8:12 PM

-confirmed-

It was working fine before the chunk 32 update. After that it broke.
Most likely the "respawn shopkeep" function is still located at its old block coordinates and wasn't moved to its new position after the chunk 32 update.

lancake edited Steps to reproduce. (Show Details)Sep 19 2016, 9:34 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Last tested (version) from .199.161 to 0.199.223.
lancake set First occurrence (version) to 0.199.132.
lancake renamed this task from Shopkeep to shopkeep can't be respawned.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptSep 19 2016, 9:35 PM

Regarding possible move of shopkeep with Chunk32 update. I can replicate this error on a clean/fresh install, single-player only, latest release. Which would lead me to presume that since the world is created anew in this situation, this bug is not related to a block coordinate move.

AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:20 PM
Restricted Application added a project: AI. · View Herald TranscriptMar 10 2017, 5:20 PM
AndyP changed Category from AI to Engine.Mar 10 2017, 9:37 PM
Restricted Application edited projects, added Engine; removed AI. · View Herald TranscriptMar 10 2017, 9:37 PM
AndyP changed Category from Engine to Crew/NPCs.Mar 15 2017, 6:36 PM
Restricted Application edited projects, added Crew; removed Engine. · View Herald TranscriptMar 15 2017, 6:36 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the Crew board.Mar 24 2017, 11:20 AM
AndyP raised the priority of this task from Low to High.
lancake added a commit: Restricted Diffusion Commit.Jun 10 2017, 3:48 PM
lancake changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 10 2017, 3:48 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 0.199.223 to 0.199.614.Jun 22 2017, 2:25 PM
lancake closed this task as Closed.Jun 22 2017, 11:46 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 22 2017, 11:46 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript