Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1383

Starmade | Setting InShop to false also removes item from creative inventory
Confirmed task for development, LowPublic
Actions

Description

Setting <InShop>false</InShop> for items normally found in shops, results in that item being removed from shops AND creative inventory (e.g. /creative_mode or shipyard "Edit Design").

The expectation is that items would remain available in creative/shipyard inventories.

The underlying goal behind reming various items from inventory is to strengthen a player-run economy; reducing NPC dependency. An alterantive solution, could be adding a function that enables administrators to limit the maximum quantity of an item in all NPC shops.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.197.53
Category
Blockconfig
First occurrence (version)
0.197.51
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
User/Reporter/Contact
Username on Registry
erthparadine
Steps to reproduce

For item listed in the below config file, after applying to a server, you'll notice these items have been removed from all NPC shops (expected), and (unexpected) from shipyards "Edit Design" and from creative mode.

In the file:
customBlockConfig/BlockConfigImport.xml

<Config>

<Element>
        <General>
                <Block icon="17" name="Warhead" textureId="422, 422, 421, 421, 422, 422" type="EXPLOSIVE_ID">
                        <InShop>false</InShop>
                </Block>
                <Block icon="620" name="Transporter Controller" textureId="549, 373, 371, 377, 550, 550" type="TRANSPORTER_CONTROLLER">
                        <InShop>false</InShop>
                </Block>
                <Block icon="621" name="Transporter Module" textureId="543, 544, 545, 545, 545, 545" type="TRANSPORTER_MODULE">
                        <InShop>false</InShop>
                </Block>
        </General>
</Element>

</Config>

Tester information (Internal use only)

Adding another config option <InCreative> should do the trick. currently <InShop> removes it from the shop *and* the creative mode inventory.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptApr 25 2016, 6:57 AM
lancake added a subscriber: lancake.May 6 2016, 5:03 PM
lancake claimed this task.

-Validated-

lancake shifted this object from the S1 Public space to the S3 Starmade space.May 6 2016, 5:04 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.197.53.
lancake changed Category from none/unspecified to Blockconfig.
lancake set First occurrence (version) to 0.197.51.
lancake moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake changed the task status from Open to In Queue (Game).
lancake triaged this task as Low priority.

-Confirmed-

Adding another config option <InCreative> should do the trick. currently <InShop> removes it from the shop *and* the creative mode inventory.

Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptMay 6 2016, 5:05 PM
lancake moved this task from Unclassed to Issue affecting current release on the Starmade board.Aug 9 2016, 6:10 PM
lancake raised the priority of this task from Low to Release Blocker.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptAug 9 2016, 6:10 PM
AndyP lowered the priority of this task from Release Blocker to Low.Aug 22 2016, 6:57 AM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:21 PM
Restricted Application added a project: Blockconfig. · View Herald TranscriptMar 10 2017, 5:21 PM
AndyP moved this task from Backlog / Unclassed to Beta on the Blockconfig board.Mar 11 2017, 8:29 PM