Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1327

Launcher | Interrupting update of old launcher corrupts the file
Closed, FinishedPublic
Actions

Description

I opened my starmade-starter.exe as usual but that time it didn't started well at all :

I got this white screen 2 timeq with absolutely no idea if it was an error message or other thing. I killed the process 2 times but then the 3rd time I tried on box to saw what would happen and eventually the both clients windows appeared.
It was not an error message but the suggestion talking about something like : "You are using the launcher version 1.5 will you update to 1.6 ?"

I said "YES".


It updated "smoothly" until 36% where it blocks pretty long several minutes like 4-5 mn. After that it continued a while until all of sudden it decided to reset around 20%.

Was copy-pasting my screen when during that 2nd row it definetily blocked at 26% + got an error message.

Try launch again the file but was corrupted and unreadable. I deleted it, I don't have starter.exe anymore. (Is it a Schine sneaky move to force me to use the beta-launcher ? :p )

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
Yes
Last tested (version)
15
Category
Launcher
First occurrence (version)
15
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

Use a v15 launcher or older:

StarMade-starter.exe2 MBDownload

  • Start update
  • While it's showing that progress bar, click on the X to close it before it's completed
  • Start the launcher again and update again
  • You'll get an error, press continue and notice the progress bar is stuck
  • Close that progress bar again
  • Start the launcher for the 3rd time and it will be corrupt, the last temp file (which is very incomplete) replaced the real starmade-starter.exe
Tester information (Internal use only)

While downloading/installing the new update, pressing the exit button or ending its process, the temp starmade-starter file you were downloading will not be removed.

The next time you try to update, it seems to conflict with that and refuse to update entirely and give you something like this:


Only option is to stop updating again and this will then finally replace your starmade-starter.exe with the temp file you started downloading.
Making the file corrupt.

Uploaded a v15 starmade-starter.exe to test with:

StarMade-starter.exe2 MBDownload

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

Croquelune updated the task description. (Show Details)Apr 7 2016, 6:48 AM
Croquelune changed Category from none/unspecified to Launcher.
Croquelune edited Serverconfig (server.cfg). (Show Details)
Croquelune edited Clientconfig (settings.cfg). (Show Details)
Croquelune set Last tested (version) to 1.5.
Croquelune added a subscriber: Croquelune.
Croquelune created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptApr 7 2016, 6:48 AM
lancake added a subscriber: lancake.Apr 7 2016, 12:18 PM

-Validated-
-Confirmed-

v16 is required to make it work with the new version numbering, the old launcher still works fine (if you use that version).
I'm not sure why you got that blank screen at first (if it's your first time after booting up your pc, it can take a while) but since you were ending processes, I'm guessing you did that in the middle of an update which seems to corrupt the entire installation.

Download the v16 starter from StarmadeDock manually.

While downloading/installing the new update, pressing the exit button or ending its process, the temp starmade-starter file you were downloading will not be removed.
The next time you try to update, it seems to conflict with that and refuse to update entirely. Only option is to stop updating again and this will then replace your starmade-starter.exe with the temp file you started downloading.

Uploaded a v15 starmade-starter.exe to test with:

StarMade-starter.exe2 MBDownload

lancake claimed this task.Apr 7 2016, 12:18 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.Apr 7 2016, 12:22 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake set Task Type to Bug.
lancake set First occurrence (version) to 15.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake set Affected Gamemode(s) to none/unspecified.
lancake set Reproducible to Yes.
lancake changed Last tested (version) from 1.5 to 15.
lancake edited Steps to reproduce. (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
lancake renamed this task from update launcher from 1.5 to 1.6 by starter.exe file caused corruption and death of that one to Interrupting update of old launcher corrupts the file.
lancake triaged this task as Release Blocker priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptApr 7 2016, 12:22 PM
lancake moved this task from New / Unconfirmed to Confirmed on the Issue Navigation board.Apr 7 2016, 12:22 PM
lancake changed the task status from Open to In Queue (Launcher).
Restricted Application edited projects, added Starmade, Launcher Development; removed Issue Navigation. · View Herald TranscriptApr 7 2016, 12:23 PM
Croquelune added a comment.Apr 7 2016, 3:54 PM
In T1327#50788, @lancake wrote:

I'm not sure why you got that blank screen at first (if it's your first time after booting up your pc, it can take a while) but since you were ending processes, I'm guessing you did that in the middle of an update which seems to corrupt the entire installation.

Me neither, I can only assure it's was produced 3 times only and it was when the "1.5 => 1.6 YES/NO" box popped-up in the 3 case. So we can barely assume it's bound with the pop-up of that window. I'll take that 1.5 again and try it in order to see if the white screen occure again.

Croquelune added a comment.EditedApr 9 2016, 8:01 AM

I had downloaded your starter.exe (thx btw). And updated without apparent problem this time.

But the updating to 1.6 didn't solve the white screen occurrence before/during launcher initialisation it's continue to do it. However it's shorter in time and don't seems produce bugs while it isn't interrupt by pop-up message windows from it.
If a pop-up windows appear for whatever reason (announce, warning or error), the launcher freeze at is moment state with the white screen until you click on the grey part of one of the 2 windows in order to unblock it (and be able to read the both windows and continue operations).
Strangely it's like if the launcher was looking for establish communication with something but have difficulty to do it, so the issue is might link with the registry since it's occuring during the "retreving version" phase and don't happen again after that.

calani added a subscriber: calani.Jul 23 2016, 2:41 AM
calani lowered the priority of this task from Release Blocker to Needs Triage/Unclassed.

Does this apply to the new launcher?
If not, I will close this ticket.

Croquelune added a comment.Jul 23 2016, 3:07 PM

I never got an internet interruption during update with the new launcher. Might worth the try to see how react the launcher/files.

lancake moved this task from Issue affecting current dev-build to Issue affecting current release on the Starmade board.Aug 9 2016, 5:27 PM
lancake triaged this task as Release Blocker priority.
calani added a comment.Aug 9 2016, 7:17 PM

From @lancake's priority increase, is it safe to assume this is also happening with the new launcher?

calani added a commit: Restricted Diffusion Commit.Aug 19 2016, 12:14 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptAug 19 2016, 12:14 AM
SmilingDemon shifted this object from the S3 Starmade space to the S5 Launcher space.Aug 19 2016, 6:39 PM
calani added a comment.Aug 19 2016, 6:59 PM

Fixed for the new launcher.
Legacy launcher unchanged.

lancake closed this task as Closed.Jun 16 2017, 8:12 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 16 2017, 8:12 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript