Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1315

Starmade | shift + v not working for a certain blocks or should not work at all
Confirmed task for development, LowPublic
Actions

Description

Logic and shift + v linking on system blocks works although it only selects the surrounding blocks. It should not work if it doesn't actually do anything (can't turn them off)

shift + v on lights also selects surrounding blocks but nothing more, in this case it should do everything.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.198.141
Category
Logic Gates
First occurrence (version)
0.19624
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. place down any logic block
  2. shift + V link it with a single or more system blocks
Tester information (Internal use only)

Only links the block you're looking at and its neighbours.

Either disable linking completely or make it work like it should, I'm fine with either.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

lancake updated the task description. (Show Details)Apr 4 2016, 8:32 AM
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Needs Triage/Unclassed.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptApr 4 2016, 8:32 AM
lancake claimed this task.Apr 7 2016, 12:36 PM

Shift + V linking any logic block with a system block (shields, thrust, power) causes this crash to happen. Single linking is fine though.
I'm not even sure why this sort of link is allowed since it doesn't seem to do anything?

[2016-04-07 14:29:59] [GLFRAME] THROWN: class java.lang.IllegalArgumentException Now Printing StackTrace
[2016-04-07 14:29:59] java.lang.IllegalArgumentException: Can't access details for this elementCollection. For memory reason it only saves size and bounding box
[2016-04-07 14:29:59] 	at org.schema.game.common.data.element.ElementCollection.getNeighboringCollection(SourceFile:423)
[2016-04-07 14:29:59] 	at obfuscated.dC.d(SourceFile:322)
[2016-04-07 14:29:59] 	at obfuscated.cy.d(SourceFile:309)
[2016-04-07 14:29:59] 	at obfuscated.eR.d(SourceFile:80)
[2016-04-07 14:29:59] 	at obfuscated.cy.d(SourceFile:309)
[2016-04-07 14:29:59] 	at obfuscated.eI.d(SourceFile:118)
[2016-04-07 14:29:59] 	at obfuscated.cy.d(SourceFile:309)
[2016-04-07 14:29:59] 	at obfuscated.ds.d(SourceFile:1080)
[2016-04-07 14:29:59] 	at obfuscated.cy.d(SourceFile:309)
[2016-04-07 14:29:59] 	at obfuscated.dr.d(SourceFile:320)
[2016-04-07 14:29:59] 	at obfuscated.cy.d(SourceFile:309)
[2016-04-07 14:29:59] 	at obfuscated.dg.d(SourceFile:311)
[2016-04-07 14:29:59] 	at obfuscated.cy.d(SourceFile:309)
[2016-04-07 14:29:59] 	at obfuscated.cE.d(SourceFile:135)
[2016-04-07 14:29:59] 	at obfuscated.C.updateStateInput(SourceFile:1365)
[2016-04-07 14:29:59] 	at obfuscated.avF.a(SourceFile:1167)
[2016-04-07 14:29:59] 	at obfuscated.C.h(SourceFile:2866)
[2016-04-07 14:29:59] 	at obfuscated.QI.run(SourceFile:92)
[2016-04-07 14:29:59] 	at java.lang.Thread.run(Unknown Source)
[2016-04-07 14:29:59] [GLFRAME] THROWN: class java.lang.IllegalArgumentExceptionPrinting StackTrace DONE

Full logs:

log.txt.0345 KBDownload

lancake updated the task description. (Show Details)Apr 7 2016, 12:38 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake set Task Type to Bug.
lancake set Category to Logic Gates.
lancake set First occurrence (version) to 0.19624.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake set Affected Gamemode(s) to Single and Multi.
lancake set Reproducible to Yes.
lancake set Last tested (version) to 0.197.2 (Dev).
lancake edited Steps to reproduce. (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
lancake renamed this task from NOT shift + v linking with power reactor crashes your game to logic shift + v linking with system blocks causes crash.
lancake triaged this task as Pre-Release Quality Assurance priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptApr 7 2016, 12:38 PM
lancake moved this task from New / Unconfirmed to Confirmed on the Issue Navigation board.Apr 7 2016, 12:38 PM
lancake changed the task status from Open to In Queue (Game).
lancake lowered the priority of this task from Pre-Release Quality Assurance to High.
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptApr 7 2016, 12:38 PM
lancake mentioned this in Unknown Object (Maniphest Task).Apr 26 2016, 10:13 AM
schema added a commit: Restricted Diffusion Commit.May 1 2016, 4:40 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMay 1 2016, 4:40 PM
lancake changed the task status from Resolved to In Queue (Game).Jun 4 2016, 9:48 PM

-QA Testing-

Only links the block you're looking at and its neighbours.

Either disable linking completely or make it work like it should, I'm fine with either.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJun 4 2016, 9:48 PM
lancake edited Tester information (Internal use only). (Show Details)Jun 4 2016, 9:49 PM
lancake changed Last tested (version) from 0.197.2 (Dev) to 0.198.141.
lancake updated the task description. (Show Details)Feb 3 2017, 12:09 AM
lancake merged a task: T2201: SHIFT-V on lights doenst work.
lancake added a subscriber: happahappa.
lancake renamed this task from logic shift + v linking with system blocks causes crash to shift + v not working for a certain blocks or should not work at all.
lancake lowered the priority of this task from High to Low.
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:07 PM
Restricted Application added a project: Logic. · View Herald TranscriptMar 10 2017, 5:07 PM
AndyP moved this task from Backlog / Unclassed to Beta on the Logic board.Mar 15 2017, 2:22 PM