Page MenuHomeSchine - Phabricator

Starmade | Entities undocking fully or partially after log back in.
Closed, FinishedPublic

Description

Logging back after logging out for two minutes to find astro kicked off his ship.

The fleet is at the "move to" sector as ordered, just one problem all the ships in the fleets turrets and other docked entities have detached or disappeared and are floating around the location where I logged off on the ship.

The detached entites are factionless and are not part of the fleet.

This has happened twice and common factor is player logging out and back in.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.19616 (Dev)
Category
Engine
First occurrence (version)
0.19592
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. use a big ship with turrets/docks at the front and at the back (Eion class carrier 43 is a good one to try out)
  2. use a fleet move order to a faraway sector OR spawn in a copy of that ship on a sector border
  3. both should end up with docks overlapping sectors and most of these will end up misaligned
Tester information (Internal use only)

The issue is that ships can be in 2 sectors at once, the docked entities that are not in the same sector as the main ship core have a chance to end up docked, in the wrong sector. Causing them to be non physical yet they still are attached to the main ship just in the wrong sector.

We had this issue when trying to dock to something in a different sector than you were originally, that is fixed now yet the stuff mentioned before still happens unfortunately.

There is however a behavior chance. If this happens, and then you make the main ship cross a sector, those misaligned entities become aligned again to the main ship and everything is fine. So perhaps this check isn't called immediately after loading and only on sector changes after that?

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Phocian updated the task description. (Show Details)Mar 5 2016, 4:43 PM
Phocian changed Category from none/unspecified to Engine.
Phocian set First occurrence (version) to 0.19592.
Phocian edited Serverconfig (server.cfg). (Show Details)
Phocian edited Clientconfig (settings.cfg). (Show Details)
Phocian added a subscriber: Phocian.
Phocian created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptMar 5 2016, 4:43 PM
lancake added a subscriber: lancake.Mar 7 2016, 5:21 PM
lancake claimed this task.

-Validated-

Might be related to T834

lancake shifted this object from the S1 Public space to the S3 Starmade space.Mar 7 2016, 5:21 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake set Task Type to Bug.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake set Affected Gamemode(s) to Multiplayer.
lancake set Reproducible to uncertain.
lancake set Last tested (version) to 0.19595 (Dev).
lancake triaged this task as Urgent priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptMar 7 2016, 5:21 PM
Asypha added a subscriber: Asypha.Mar 8 2016, 6:23 AM

Ah forgot to put this one in queue, should be fixed in 0.19602.

Issue was caused ships that crossed multiple sectors, only really happens often for bigger ships after a move order. Fleet orders put them near a border so often a portion of your turrets would overlap, this would cause them to misalign and create all sorts of weird issues.

lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptMar 12 2016, 7:42 PM
lancake changed the task status from In Queue (Game) to Resolved.Mar 12 2016, 7:42 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 12 2016, 7:42 PM

Hi there
Tried to report the bug , but was somehow overhelmed to create a report here on this side.
so here is the Bug, cause somehow it´s cause of the same problem i guess. Sry when my english is bad , it´s not my first language. and i am not very good in explaining things :/ Hope you understand me still.

When you create a Dockingsystem(design!!!) in the shipyard , (i tested turrets)
then go to the testingside several times (the first time is not enough somehow ) leads to undocked and visuable but not interactable turretparts near the shipyard (the turretparts are not taken over to the testingside in those cases) ,
these turretparts are becomming existent and interactable after letting the area reload , for example , after leaving and comming back , rejoining the server and am not sure anymore but , in my memorys the testingside led to it too.
so after rejoining for example you can take the turretparts to the shipyard and deconstruct and you get the full amount of blocks.
i only tested it on multiplayerservers, didn´t test this yet on singleplayer, and just with 2 ships, one rly big one and one small one.
at the time i was using the starmade demo.
just bought the full version.
i will test it again when i have the time.

That belongs in T834

lancake changed the task status from Resolved to In Queue (Game).EditedMar 14 2016, 1:30 PM

-QA Testing-

The issue is that ships can be in 2 sectors at once, the docked entities that are not in the same sector as the main ship core have a chance to end up docked, in the wrong sector. Causing them to be non physical yet they still are attached to the main ship just in the wrong sector.

We had this issue when trying to dock to something in a different sector than you were originally, that is fixed now yet the stuff mentioned before still happens unfortunately.

There is however a behavior chance. If this happens, and then you make the main ship cross a sector, those misaligned entities become aligned again to the main ship and everything is fine. So perhaps this check isn't called immediately after loading and only on sector changes after that?

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 14 2016, 1:30 PM
lancake edited Steps to reproduce. (Show Details)Mar 14 2016, 1:31 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake edited Tester information (Internal use only). (Show Details)Mar 14 2016, 2:42 PM
schema added a subscriber: schema.Mar 17 2016, 10:25 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 17 2016, 10:25 PM
lancake closed this task as Closed.

-QA Testing-

Checked it multiple times in the past few days and never, ever saw it misaligned or undocked with ways I could reproduce it every time. This one is fixed.

It's possible there's a more rare issue that causes undocking, but that would have been there before this one popped up.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptMar 20 2016, 1:51 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Reproducible from uncertain to Yes.Mar 20 2016, 1:51 AM
lancake changed Last tested (version) from 0.19595 (Dev) to 0.19616 (Dev).
AndyP moved this task from Unclassed to Archived on the Starmade board.Mar 20 2016, 9:15 AM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:16 PM