Page MenuHomeSchine - Phabricator

Starmade | Replace tool doesn't always replace with correct orientation
Closed, FinishedPublic

Description

There are a few actions that cause the replaced block to have the incorrect orientation. The orientation that is replaced should always be the one of the original block if the replaced type is the same (Hepta ---> Hepta, Wedge ---> Wedge,...):

  1. 8 hull corner rotations are incorrectly replaced
    • before:
    • after:
  2. Replacing hull wedges with crystal wedges, or crystal wedges with hull wedges will use also are not replaced correctly. The same goes for teal and pink hull replacing other hull blocks.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.197.39
Category
Engine
First occurrence (version)
0.1703 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 9 2015, 8:36 AM
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.1703 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Normal.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJun 9 2015, 8:36 AM
lancake changed the task status from Open to In Queue (Game).Jun 10 2015, 9:27 AM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 10 2015, 9:27 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:33 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
lancake claimed this task.Sep 21 2015, 10:48 AM
lancake changed Last tested (version) from 0.19247 (Dev) to 0.19439 (Dev).Sep 26 2015, 11:35 AM

So what's your progress on a fix for this? Schine has known about this for almost 1 year now. It seems like this should be a fairly easy fix involving matching up block IDs and block orientations. This pretty much breaks the game, also, and destroys gameplay when using the advanced build mode and the remove / replace feature. Lots of players like to recolor their ships, and this prevents them from doing so.

Please take the time to make this a priority, especially since it's such an old bug.

It's about time this gets resolved, especially since it can't even be undone (T574).

schema added a commit: Restricted Diffusion Commit.Apr 15 2016, 1:07 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 15 2016, 1:07 AM
lancake changed the task status from Resolved to In Queue (Game).Apr 15 2016, 6:55 PM

-QA Testing-

Partially fixed:
Issue 2 isn't fixed but that's because those blocks have "orientation" set to true and it should be false.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptApr 15 2016, 6:55 PM
lancake changed Last tested (version) from 0.19439 (Dev) to 0.197.37.Apr 15 2016, 6:56 PM
schema added a commit: Restricted Diffusion Commit.Apr 15 2016, 8:08 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 15 2016, 8:08 PM
lancake closed this task as Closed.

-QA Testing-

This task is fixed, but the build helper remember sitting has an issue, going to make a new one for it.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 16 2016, 2:11 PM
lancake changed Last tested (version) from 0.197.37 to 0.197.39.Apr 16 2016, 2:11 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:49 PM