Page MenuHomeSchine - Phabricator
Create Task
Maniphest T849

Starmade | Ships cost credits to repair, even if SHOP_ARMOR_REPAIR_COST_PER_HITPOINT = 0.0
Closed, FinishedPublic
Actions

Description

just what it says on the tin, player stations repair costs are still costing credits when this value is set to 0.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.435
Category
Engine
First occurrence (version)
0.19488
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)

SHOP_ARMOR_REPAIR_COST_PER_HITPOINT = 0.0 //Cost to repair a ship's armor at a shop

Event Timeline

plusnine updated the task description. (Show Details)Nov 11 2015, 9:28 PM
plusnine changed Category from none/unspecified to Engine.
plusnine changed Affected Gamemode(s) from none/unspecified to Single and Multi.
plusnine changed Reproducible from uncertain to Yes.
plusnine set Last tested (version) to V0.19488.
plusnine edited Serverconfig (server.cfg). (Show Details)
plusnine edited Clientconfig (settings.cfg). (Show Details)
plusnine added a subscriber: plusnine.
plusnine created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptNov 11 2015, 9:28 PM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.Nov 12 2015, 4:34 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon set Task Type to Bug.
SmilingDemon set First occurrence (version) to V0.19488.
SmilingDemon set OS-Specific to No.
SmilingDemon set Hardware-Specific to No.
SmilingDemon set Video Card Vendor to uncertain.
SmilingDemon claimed this task.
SmilingDemon triaged this task as Normal priority.
SmilingDemon added a subscriber: SmilingDemon.Nov 12 2015, 4:39 PM
SmilingDemon removed SmilingDemon as the assignee of this task.

-Validated-

A station is not a ship .. in that regard this makes sense!
But a value to take a station (or planet) into account might be necessary

Open for Testing to see under what circumstances a setting might be needed here.

Chandler claimed this task.Nov 12 2015, 9:41 PM
Chandler added a comment.Nov 13 2015, 1:17 AM

Put the settings to 0. Damaged a station , repaired, no charge.

Are you able to show video of it happening, and then post it here?

Chandler added a comment.Nov 16 2015, 10:28 PM

-Confirmed-
It is with ship repair however, not station.
I tested with station got the expected result
I tested with a ship and had to pay to repair the ship..

Chandler moved this task from Feedback to Confirmed on the Issue Navigation board.Nov 16 2015, 10:28 PM
Chandler renamed this task from stations still cost credits to repair, even if SHOP_ARMOR_REPAIR_COST_PER_HITPOINT = 0.0 to Ships cost credits to repair, even if SHOP_ARMOR_REPAIR_COST_PER_HITPOINT = 0.0.
Chandler changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptNov 16 2015, 10:29 PM
lancake mentioned this in Unknown Object (Maniphest Task).Apr 17 2016, 10:01 PM
lancake added a subscriber: lancake.Dec 21 2016, 7:18 PM
lancake changed the task status from In Queue (Game) to Resolved.

Looks fine, needs someone else to double check. Maybe fixed a while ago or I just failed to reproduce

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 21 2016, 7:18 PM
lancake closed this task as Closed.Feb 7 2017, 3:07 PM

-QA Testing-

Still looks fine really, rebooting a station also refills the AHP so it should always do that for free anyways but it may not have been that way before?

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptFeb 7 2017, 3:07 PM
lancake changed Last tested (version) from V0.19488 to 0.199.435.Feb 7 2017, 3:08 PM
lancake changed First occurrence (version) from V0.19488 to 0.19488.
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:22 PM