Page MenuHomeSchine - Phabricator

Starmade | deleting shipyard core anchor when design is loaded, removes it from the database
Closed, FinishedPublic

Description

Removing a shipyard core anchor while a design is loaded, will delete that design entity from the database. The meta item in your shipyard computer remains though and when you try to load it, it will give you an error saying:

Cannot load design Entity for design not valid in database!

The design should unload, not get removed the database. This corrupts any loaded design. Sometimes a shipyard gets stuck (see T762/T752) and removing the shipyard core anchor usually gets rid of that. Doing that though will inevitably corrupt the design you had loaded at the time.

How to reproduce:

  1. create design in a shipyard
  2. delete the shipyard core anchor (in station build mode)
  3. place it back and link it to your shipyard computer
  4. try to load the previously loaded design, you can't

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19553 (Dev)
Category
Control Block System: Shipyards
First occurrence (version)
0.19431
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Oct 29 2015, 4:02 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Control Block System: Shipyards.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19431.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19452 (Dev).
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Urgent.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptOct 29 2015, 4:02 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake claimed this task.Oct 29 2015, 4:02 PM

-Confirmed-

lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake set Task Type to Bug.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptOct 29 2015, 4:02 PM
schema added a commit: Restricted Diffusion Commit.Nov 21 2015, 1:00 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 21 2015, 1:00 PM
lancake changed the task status from Resolved to In Queue (Game).Nov 21 2015, 1:15 PM

-QA Testing-

Partially fixed. The design remembers the mothership, but all its docks are gone when you load it again.

How to reproduce:

  1. make a design
  2. make a dock on that design
  3. remove shipyard core anchor
  4. put it back again
  5. load the design
  6. notice that the dock is gone.
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptNov 21 2015, 1:15 PM
lancake changed Last tested (version) from 0.19452 (Dev) to 0.19495 (Dev).Nov 21 2015, 1:15 PM
schema added a subscriber: schema.Jan 13 2016, 3:55 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJan 13 2016, 3:55 PM

The design becoming corrupt seems to be fixed. Now you can't build while a design is loaded although I did manage to do that after making a new shipyard anchor and using that. Still, even when I removed the core anchor then while it was in use, the design was still usable afterwards.

I'll have to check this again later.

lancake closed this task as Closed.Jan 30 2016, 1:09 AM

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 30 2016, 1:09 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.19495 (Dev) to 0.19553 (Dev).Jan 30 2016, 1:09 AM
Restricted Application added a project: CBS: Shipyards. · View Herald TranscriptMar 10 2017, 6:23 PM