Page MenuHomeSchine - Phabricator
Create Task
Maniphest T739

Launcher | "Determining files to download" triggers on the wrong event
Closed, FinishedPublic
Actions

Description

This event seems to trigger when it's not needed, preventing you from instantaneous playing the game.
It triggers when:

  • there is automatically a "Build version" selected or if you select another one yourself, same goes by changing build branches since it auto selects a version

It should only trigger when:

  • You press "Download selected build version" and "Force download all & overwrite"

Priority high since it's going to annoy a lot of people.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
Yes
Last tested (version)
0.0.5
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

lancake updated the task description. (Show Details)Oct 4 2015, 1:04 PM
lancake shifted this object from the S1 Public space to the Restricted Space space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Launcher.
lancake set Last tested (version) to launcher v0.0.2.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptOct 4 2015, 1:04 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake set Task Type to Bug.Oct 4 2015, 1:04 PM
lancake set Affected Gamemode(s) to none/unspecified.
lancake set Reproducible to uncertain.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Launcher).
lancake claimed this task.
Restricted Application edited projects, added Starmade, Launcher Development; removed Issue Navigation. · View Herald TranscriptOct 4 2015, 1:04 PM
lancake added a comment.Oct 4 2015, 1:09 PM

-Confirmed-

Megacrafter127 added a subscriber: Megacrafter127.Oct 5 2015, 1:56 PM

It should trigger when manually selecting a version different from the currently installed version though.

AndyP shifted this object from the Restricted Space space to the S5 Launcher space.Oct 26 2015, 10:17 PM
lancake updated the task description. (Show Details)Nov 5 2015, 4:03 PM
calani added a subscriber: calani.Jan 12 2016, 9:01 AM

Changing the selected version in the dropdown no longer triggers an immediate update, instead requiring you to manually click one of the update buttons (either in the build options window or the large orange [UPDATE] button in the lower corner of the launcher)

commit: 013102f4ef9f3ba6c0f97040d5c11de17028c84f

calani changed the task status from In Queue (Launcher) to Resolved.Jan 12 2016, 9:02 AM
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJan 12 2016, 9:02 AM
calani added a comment.Jan 12 2016, 11:02 PM

Removed the file check when changing the branch dropdown, and added a note above the [UPDATE] button that informs the user that clicking it will overwrite any installed mods.

lancake added a comment.Jan 13 2016, 11:28 AM

Sounds good, will check as soon as we get access to the latest version.

calani added a commit: Restricted Diffusion Commit.Jan 13 2016, 11:04 PM
lancake added a comment.Jan 20 2016, 7:23 PM

It's fine for windows and megacrafter127 checked linux.

No clue about mac just yet so waiting on confirmation.

lancake closed this task as Closed.Jan 20 2016, 8:53 PM

-QA Testing-

Also confirmed fix for mac, closing.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 20 2016, 8:53 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Reproducible from uncertain to Yes.Jan 20 2016, 8:53 PM
lancake changed Last tested (version) from launcher v0.0.2 to 0.0.5.
calani added a commit: Restricted Diffusion Commit.Jan 23 2016, 8:52 AM
calani reopened this task as Resolved by committing Restricted Diffusion Commit.
Restricted Application added a project: Quality Assurance. · View Herald TranscriptJan 23 2016, 8:52 AM
SmilingDemon added a subscriber: SmilingDemon.Jan 23 2016, 10:35 AM
SmilingDemon closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 23 2016, 10:35 AM