Page MenuHomeSchine - Phabricator
Create Task
Maniphest T658

Starmade | Shipyards cut off parts of a ship
Closed, FinishedPublic
Actions

Description

This has been present since shipyards were introduced. It was mentioned in task T551 but is still present in the current release.

In short; the shipyard will spawn a ship based on a blue print or design properly. BUT when you unload the sector, everything except the center section of the ship will be missing, Meaning only the "shipname".0.0.0.smd2 is properly saved to the data base and nothing else.

I would have included logs, but the logs do not show any kind of saving error that I could find. I am including the ship files and how to reproduce the bug.

So What I did was save a ship to blue print. name: LongShip I then loaded it into a shipyard via blue print and had the shipyard make it. It spawned from the shipyard correctly. I then exited the game, unloading the sector. When I logged back in the front section of the ship was gone.

I saved the bugged ship as "longshipBUGGED" now in this saved file the front section of the ship Longshipbugged.0.0.1.smd2 is there, and has the correct file size, but if you spawn the blue print the front section is missing.

To double check this I created a 3rd blueprint "LongshipDELETED" from the clean working blueprint "longship" and manually deleted the front section of the ship, just to make sure. It turns out looking the same as the "longshipBUGGED" blueprint.

I dug deeper and looked through the server database files. The front sections that are visibly missing are in the server database, and they are the same size as the unbugged version of the ship.

So I would have to assume this is some kind of database saving/loading error. AND yes the shipyard is more then long enough to spawn the ship :)

I have included pictures and blueprints of the ships I used to test this.

Go get um boys! Thanks for all your hard work =D

EDITED: I misread some of the file names in the database and thought the bugged ships files were smaller, but they were not. Now this happens with just about every ship I put into the shipyard that has more then one section. But when I built a ship in the shipyard that had multiple sections it turned out fine with no saving errors.

Longship.zip2 MBDownload

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19460 (Dev)
Category
Control Block System: Shipyards
First occurrence (version)
0.19431
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
User/Reporter/Contact
Username on Registry
timethatswasted
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

TIME updated the task description. (Show Details)Sep 12 2015, 9:48 PM
TIME changed Category from none/unspecified to Engine.
TIME changed Affected Gamemode(s) from none/unspecified to Single and Multi.
TIME set First occurrence (version) to .194.
TIME changed Reproducible from uncertain to Yes.
TIME set Last tested (version) to .19431.
TIME edited Serverconfig (server.cfg). (Show Details)
TIME edited Clientconfig (settings.cfg). (Show Details)
TIME set Username on Registry to timethatswasted.
TIME added a subscriber: TIME.
TIME created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 12 2015, 9:48 PM
TIME updated the task description. (Show Details)Sep 12 2015, 10:36 PM
TIME set Task Type to Bug.
TIME set OS-Specific to No.
TIME set Hardware-Specific to No.
TIME set Video Card Vendor to uncertain.
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.Sep 13 2015, 2:10 PM
AndyP moved this task from Open / Validated to Feedback on the Issue Navigation board.
AndyP moved this task from Feedback to Open / Validated on the Issue Navigation board.
AndyP claimed this task.
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Sep 13 2015, 2:12 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP changed First occurrence (version) from .194 to 0.19431.
AndyP changed Last tested (version) from .19431 to 0.19431.
AndyP triaged this task as Normal priority.
AndyP added subscribers: SmilingDemon, lancake.Sep 13 2015, 2:17 PM

-Validated-

We got a bug with ships being cut-off at some point, and had some ideas how to reproduce, but also a few attempts to fix it.

@SmilingDemon
@lancake

AndyP added a subscriber: AndyP.Sep 13 2015, 2:18 PM
AndyP removed AndyP as the assignee of this task.
Ithirahad added a subscriber: Ithirahad.Sep 24 2015, 11:52 AM

I've had this happen as well.

cyberus111 added a subscriber: cyberus111.Sep 25 2015, 1:37 AM

I've had this happen AFTER the ship was build and moved to its permanent dock. Came back the next day and the rear 50m of this ship was gone.

jzimmerman4 added a subscriber: jzimmerman4.Oct 1 2015, 12:00 AM

I am not seeing this happen in dev 0.19439 when I use a small shipyard that builds a shuttle

TIME added a comment.Oct 1 2015, 12:16 AM

the ship needs to be fairly long, or tall, so that it is saved with multiple sections into the data base.

I have not checked it in the recent DEV build, but make a ship that is between 150 and 200 meters long or tall, and see if it happens.

jzimmerman4 added a comment.Oct 1 2015, 4:15 AM

Confirmed

Tested with a 221m hull covered power core and after I built the design and then logged out and back in the last 91 meters was gone and the shipyard didn't even register that there was a ship docked there anymore (Place Order options were as if nothing was there). I then proceeded to construct the same design through the Place Order tab and the shipyard computer appeared to try and build it (all the buttons grayed out) but nothing happened until I undocked the broken ship and then the new ship loaded.

jzimmerman4 moved this task from Open / Validated to Confirmed on the Issue Navigation board.Oct 1 2015, 4:15 AM
jzimmerman4 changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptOct 1 2015, 4:15 AM
Zackey_TNT added a subscriber: Zackey_TNT.Oct 2 2015, 12:42 AM

A player on GenXnova reported that he had this very issue..

Half of his ship was missing and is likely related to this issue...

However interestingly the ship wasn't a design or a work in progress it was fully finished by the time he logged out..

And it wasn't docked to the shipyard..

Leading me to believe this is an issue where any ships constructed by the shipyard have this issue... A pretty major one to be sure.

After logging back in the front half of the ship was gone.

Zackey_TNT raised the priority of this task from Normal to High.Oct 2 2015, 12:44 AM

Increasing priority due to the following affects this has on gameplay:

Ships over about 100M are unusable in shipyards and will corrupt if sector is reloaded.

Block loss is major if trying to construct say a capital ship and the player is likely very frustrated by this.

Zackey_TNT lowered the priority of this task from High to Normal.Oct 3 2015, 12:32 AM
cyberus111 added a comment.Oct 4 2015, 2:14 AM

Why was this downgraded? Missing entire chunks of ships isn't important?

Zackey_TNT added a comment.Oct 4 2015, 9:32 AM
In T658#26603, @cyberus111 wrote:

Why was this downgraded? Missing entire chunks of ships isn't important?

Internal dispute.

lancake raised the priority of this task from Normal to Release Blocker.Oct 4 2015, 3:28 PM

Constructed ships will be cut off at the front and back (relative to the shipcore) when you reload the sector. From what I've seen it's 7.5 chunks at the front, and 8.5 at the back that remain.
Total ship length is 256meters or 16 chunks.

Side note, can't reproduce this for designs or just docked ships, only seems to happen for a constructed ship.

cyberus111 added a comment.Oct 4 2015, 7:16 PM

For me its happened with a ship designed and built in the shipyard.

I built the hull with some thrust and power then moved it to a station dock. After logging out and returning later that night it had 50+ meters gone from the rear section. No sector issues since another ship docked nearby sticks further out than the aft section oft he ship that had a chunk gone.

Zackey_TNT added a comment.Oct 5 2015, 1:59 AM

Basicly, The shipyard is not saving a smd2 file that is needed for over a set amount of distance from the core.

If your design has any parts of it that cross around about 120M (we think so far) and you construct it in the shipyard it will work fine for as long as the sector is loaded however because the game isn't saving the permanent data in the files for the ship once you relog/reload the sector anything in the area over 120M (again roughly) is cut off (I mean all of it) so any ship over 120M is basically not able to be constructed in the shipyard

This leads to a ship that appears to be corrupted but is in fact perfectly normal it just didn't save the right files.

This is 100% reproducible and any info you require to fix this you can simply ask here.

A reminder this bug will only happen to ships constructed in the shipyard not docked!

Comr4de added a subscriber: Comr4de.Oct 5 2015, 6:57 PM

Actually we ran into this bug a couple times on SS and Hypercore. We lost a musaka to this bug, the bow section (with the docking block) disappeared and the ship fell off of the dock it was on. We logged back in to find that we were missing a ship, which was later traced to another player's base (without the bow section)

Ithirahad added a comment.Oct 21 2015, 9:23 PM

I've lost an Avar-Kiaan to this bug, too - Twice. The nose and some of the tails are cut off every time.

lancake renamed this task from Ship Yards do not spawn ships properly to Shipyards cut off parts of a ship.Oct 22 2015, 8:18 AM
gaeasson added a subscriber: gaeasson.Oct 23 2015, 4:22 PM

I've observed this once but never been able to reproduce it.

AndyP changed Category from Engine to Control Block System: Shipyards.Oct 26 2015, 10:26 PM
schema added a commit: Restricted Diffusion Commit.Oct 28 2015, 2:42 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptOct 28 2015, 2:42 PM
lancake closed this task as Closed.Oct 31 2015, 5:44 PM

-QA Testing-

Checked out an entity that is 700 meters in every dimension. The design and both the constructed ship did not experience any cut off parts after unloading/loading the sector again. I've also checked a docked entity that was 600 meters long and it was fine too.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptOct 31 2015, 5:44 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.19431 to 0.19460 (Dev).Oct 31 2015, 5:45 PM
Restricted Application added a project: CBS: Shipyards. · View Herald TranscriptMar 10 2017, 6:26 PM