Page MenuHomeSchine - Phabricator

Launcher | Memory setting should be set in fixed steps, 512, 1g, 1.5g 2g etc + no option to go over 2g for x32
Closed, FinishedPublic

Description

preferred UI element: Slider between a min value, and current system max

Details

Commits
Restricted Diffusion Commit
Task Type
Feature
Testing Results
Affected Gamemode(s)
Launcher
Reproducible
uncertain
Last tested (version)
158 fe18f38
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

AndyP updated the task description. (Show Details)Aug 15 2015, 6:04 AM
AndyP shifted this object from the S1 Public space to the Restricted Space space.
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "All Users".
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP added subscribers: AndyP, schema.
AndyP created this task.
AndyP raised the priority of this task from to Urgent.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 15 2015, 6:04 AM
AndyP set Task Type to Bug.Aug 15 2015, 6:05 AM
AndyP set Category to none/unspecified.
AndyP set Affected Gamemode(s) to none/unspecified.
AndyP set Reproducible to uncertain.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP changed the task status from Open to In Queue (Launcher).
Restricted Application edited projects, added Starmade, Launcher Development; removed Issue Navigation. · View Herald TranscriptAug 15 2015, 6:05 AM
AndyP changed Task Type from Bug to Feature.Aug 15 2015, 6:05 AM
AndyP assigned this task to schema.Aug 15 2015, 6:10 AM

Feature request by: schema

sidenote, 32 bit java cannot handle more than 1GB of RAM, even though 32bit OS can handle up to 4GB of RAM

AndyP shifted this object from the Restricted Space space to the S5 Launcher space.Oct 26 2015, 10:17 PM
33Cav added a subscriber: 33Cav.Oct 27 2015, 9:31 AM

Is there some problem with having a textbox that is validated against system max RAM? I often set my RAM to values such as 5800MB, a value that is unlikely to be on the proposed slider.

Yes, java can only use powers of two, as valid steps, so 1100 for example will result in the next higher power of two as real max.
While the behaviour is very inconsistent on this. Depending on exact demand and stepping it goes up, the actual limit can be higher or lower than the one specified.

In general, a slider is easier to use, if it takes system memory into account. (However, a slider with textbox beside, representing the current value, and leaving the option to manually enter a number would not harm too... so depends on actual implementation it will get.)

  • Andy
In T506#28961, @AndyP wrote:

In general, a slider is easier to use, if it takes system memory into account. (However, a slider with textbox beside, representing the current value, and leaving the option to manually enter a number would not harm too... so depends on actual implementation it will get.)

  • Andy

For the 32 bit versions of the launcher, a slider will suffice, as the maximum is fixed at 1024Mb. In case of the 64bit version, the real maximum would be so large, it would be ridiculous to include in a slider, so I recommend to either:

  • have the maximum of the slider be the amount of physical RAM of the computer, if the launcher is able to detect it.
  • use a spinner instead of a slider. clicking the up button of the spinner will double the value(or add 1024, if the value is 1024 or higher), whereas the down button of the spinner will do the reverse, with a minimum value of 1.

As for what a spinner is: http://www.java2s.com/Code/JavaImages/SwingSpinnerTest.PNG

AndyP added a commit: Restricted Diffusion Commit.Apr 18 2016, 8:35 PM
AndyP changed the task status from In Queue (Launcher) to Resolved.

-Forward-

Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptApr 18 2016, 8:36 PM
calani added a subscriber: calani.EditedApr 18 2016, 10:08 PM

Expected behavior for this build:

  • Initial and Early Gen inputs are hidden behind a link
  • New max_memory slider snaps to powers of 2 (1024, 2048, 4096, 8192, 16384, 32768)
  • Slider's initial knob position should be correct (i.e. not always at the far-left)
  • Slider's bounds are 256mb(+) ... total_os_memory
  • Slider's lower bound is 256mb or (initial+earlyGen) rounded up to the next power of 2, whichever is larger. Ex: 128+128->256; 129+128->512
  • Increasing initial/earlyGen values should automatically increase the max_memory textbox value (if needed) and the slider's lower bound (if needed).
  • max_memory input box overrides the slider, allowing users to enter a specific value
  • max_memory input box has spinner controls with a 256mb step for quicker changes
  • Saving changes to max_memory with a non-multiple-of-256 value should not show a warning/error in the console.
  • Saving changes should (obviously) save the changes :p

Known flaws:

  • Cannot (easily) select total memory via input box's spinner buttons if it is not a multiple of 256 (very likely will not fix)
  • Cannot select max memory via slider if it is not at or near a power of 2
  • Slider jumps past total memory if total memory is near a power of 2 boundary

Expected behavior is there for windows 64 bit.

SmilingDemon closed this task as Closed.
SmilingDemon claimed this task.

closing this as being implemented

remaining problems have been solved or reported elswhere

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptAug 1 2016, 1:26 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Launcher.Aug 1 2016, 1:27 PM
SmilingDemon set Last tested (version) to 158 fe18f38 .
SmilingDemon changed Category from none/unspecified to Launcher.