Page MenuHomeSchine - Phabricator

Starmade | Undo doesn't restore logic connections properly
Confirmed task for development, NormalPublic

Description

It only happens if you remove more than 1 logic block at a time, and only with specific logic chains.
The undo action only remembers all the links from 1 block at a time, it removes all the others.

  • Example 1: linking 1 activator to 1000 delays, deleting 400 delays and undoing that will preserve all links. Deleting 400 delays including that activator will however only preserve 1 of the 400 links after undoing.
  • Example 2: (A stands for activators, -> is a C -> V link) A -> A -> A -> A -> A, removing one of them at a time preserves the link on undo. Deleting the last 3 of the 5 and undoing will result in only the 2 -> 3 link coming back.

Someone made a youtube video about it too: http://youtu.be/woIa0JlMIkE

There's another issue too, if you copy paste overlapping logic blocks and then undo your change, the overlapping links will stay

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19247 (Dev)
Category
Engine
First occurrence (version)
0.19226
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 6 2015, 11:14 AM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19226.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Normal.
lancake changed the task status from Open to In Queue (Game).Jun 6 2015, 8:47 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 6 2015, 8:47 PM
lancake updated the task description. (Show Details)Jul 4 2015, 9:54 AM
lancake set Task Type to Bug.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake renamed this task from Undo doesn't restore all logic connections to Undo doesn't restore logic connections properly.
AeonOfTime added a subscriber: AeonOfTime.EditedJul 24 2015, 6:14 PM

Possibly also related: Deleting a weapon effect computer block and restoring it with undo will restore all its logic connections to the effect modules, but does not reconnect it to the tertiary weapon slot it was connected in.

AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 9:01 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
lancake claimed this task.Sep 21 2015, 10:48 AM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:22 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:22 PM
AndyP moved this task from Backlog / Unclassed to Building on the Engine board.Mar 24 2017, 9:28 PM
AndyP edited projects, added Engine (Building); removed Engine.