Page MenuHomeSchine - Phabricator

Starmade | planet plate alignment odd when astronaut logout restart on planet surface
Closed, DuplicatePublic

Description

singleplayer starmade

  1. be on planet surface as astronaut and be in the planets gravity
  2. close and restart game

your astronaut may or may not be on the planet cores surface upon restart but at least one planet plate will be at a drastically different angle to normal plate alignment

tab f6 and warping away and back will have no effect on correcting the planet

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19401
Category
Engine
First occurrence (version)
0.19354
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
AMD/ATI
Video Card Model
amd hd 6870 saphire
Detected video (Graphicsinfo.txt)

Running on thread: ClientThread
Adapter: null
Driver Version: null
Vendor: ATI Technologies Inc.
OpenGL Version: 4.5.13397 Compatibility Profile Context 15.200.1046.0
Renderer: AMD Radeon HD 6800 Series
GLSL Ver: 4.40

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
AndyP edited Clientconfig (settings.cfg). (Show Details)Jul 31 2015, 2:51 PM
AndyP added a subscriber: AndyP.
AndyP removed AndyP as the assignee of this task.

Validated

AndyP triaged this task as Normal priority.Aug 1 2015, 10:45 PM
jzimmerman4 changed Last tested (version) from 0.19354 to 0.19358.Aug 1 2015, 10:57 PM
jzimmerman4 changed the task status from Open to In Queue (Game).

Confirmed

Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptAug 1 2015, 10:58 PM
SmilingDemon changed Affected Gamemode(s) from Singleplayer to Single and Multi.Aug 2 2015, 1:36 PM
SmilingDemon changed Last tested (version) from 0.19358 to 0.19359 (Dev).
SmilingDemon added a parent task: Unknown Object (Maniphest Task).
SmilingDemon raised the priority of this task from Normal to Release Blocker.

The Problem also affects Multiplayer server.


Effect after restarting the Testserver while standing on the Planet Plate affected


and the effect persists between server restarts

for that i did increase the priority

schema added a commit: Restricted Diffusion Commit.Aug 2 2015, 2:03 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 2 2015, 2:03 PM
schema added a subscriber: schema.Aug 2 2015, 2:04 PM

should be fixed with 0.19361

the spawn recorder inverted the matrix of the entity. and since invert(invert) == original it's a 50-50 chance of the plate being inverted on save.

Good catch. That one would have been horrible in release

spunkie added a subscriber: jzimmerman4.EditedAug 2 2015, 2:06 PM
spunkie claimed this task.

update

logging out:

safe

  • near planet outside its gravity
  • on ship docked to planet surface
  • within build block on planet surface

unsafe

  • while standing on ship docked to planet surface
  • while standing on ship resting undocked on planet surface while in planet gravity
  • while not on surface yet within planet gravity

also upon logging in, after logging out in one of the above unsafe methods, you'll have the grapple warning popup.


the planet plate behavior might be related to the staying with ship while logged out feature

spunkie removed spunkie as the assignee of this task.Aug 2 2015, 2:07 PM
Restricted Application added a subscriber: Megacrafter127. · View Herald TranscriptAug 2 2015, 2:07 PM
schema added a comment.Aug 2 2015, 2:32 PM

fix needs confirmation

spunkie claimed this task.Aug 2 2015, 3:17 PM

retested and seems to be all clear for singleplayer and testing on my own multiplayer

spunkie changed Last tested (version) from 0.19359 (Dev) to 0.19361 (Dev).Aug 2 2015, 3:18 PM
spunkie removed spunkie as the assignee of this task.
AndyP closed this task as Closed.Aug 2 2015, 4:12 PM
AndyP assigned this task to spunkie.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptAug 2 2015, 4:12 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
Matt_Bradock reopened this task as Open.

Needs to be reopened, these screenshots were made in last public release:

Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 2 2015, 10:51 PM

Matt:
was that in Single or Multiplayer ?
was a Devbuild installed prior to the Release build?

Multiplayer, latest official release (right after updating, actually, last logout happened on previous release), clean new install, no devbuild ever used. Backup was used to restore the planet, no more experiments were made as it is a faction homebase and we didn't want to screw around with anything someone worked days for.

Retested and unable to get planet plate to inverted since last fix using all above steps.

Possibly, Matt it broke prefix and won't happen again

I'll try this using Spunkie's "unsafe" methods, also, since a server reboot happened between logout and login, that could also be interesting to try.

spunkie added a comment.EditedAug 3 2015, 1:09 PM

Ok, my guess is in this instance a player was on the planets surface in a version previous to the fixed version when the server was shutdown to apply the newest version. When the server was started back up, the bug was noticed in the fixed version, leading people to believe the problem was not fixed ,when instead, it was just a bug saved from the previous version. This means that the bug has been narrowed down to logging out on a planets surface (saving) and not logging in (loading).

I'll test this by logging out on planet surface in fixed version and loading in known bugged version, this should prove it's the saving, not loading, that causes the derp, and just to be thorough, I'll also test logging out in bugged version and logging in with fixed version (all of this occurring in astronaut mode on planet surface).

Well i would have tested but the save is not backward compatible. game saved in 0.19361 attempted to load previous release version 0.1932 failed to load.

update: tested out release version 0.19320 and cant get a plate to bug out
procedure
1 loaded new world in old version (release 0.19320)
2 start dedicated server
3 connect with client
4 land on planet as astronaut
5 close the server with client still connected
6 load up release version 0.19361
7 start dedicated server
8 connect with client

the planet loaded without any plates bugged

thakyZ added a subscriber: thakyZ.Aug 3 2015, 9:23 PM

No I cannot get this to work either...+

spunkie removed spunkie as the assignee of this task.Aug 3 2015, 10:43 PM
thakyZ added a comment.Aug 4 2015, 3:56 AM

Never mind I did it some how after my whole GPU crashed

And this is on Windows 10 and Java 8 and AMD Radeon HD 7800. Also latest stable build!

thakyZ it looks like your missing a plate entirely, is this true or was the plate still there but misaligned?

thakyZ added a comment.Aug 4 2015, 4:18 PM

It was in the planet...

AndyP added a subscriber: AndyP.Aug 7 2015, 10:23 AM

So this is fixed, invalid then, right?

no .. we do not know how this did happen in release.
and we couldnt reproduce it.
might not be an issue at all, but if reports are correct it still did happen at least twice

spunkie added a comment.EditedAug 7 2015, 8:11 PM

matt bradocks occurrence happened on the planet in the shattered skies server at sector -89 5 -55 im going to go sit on that planet before its scheduled restart to see if bug still happens

update

the planet surface misaligned on login for me, but the admin said the planet looked normal to himself, however, repeated logging did not fix it until i was able to get the admin to tp me out. when i was off the planet then i was able to relog and fix the planets misalignment.

the previous version of this bug would cause the planet plate to misalign and stay that way regardless of relogging or teleporting to other sectors, this is no longer the case.

this server has some custom blocks and the server spawn is not at default sector 2 2 2. The player spawns with a custom blueprint that is filled and ready to spawn a ship.

https://youtu.be/BIGyk_jlFC8

Shattered Skies has a default block config, the only differences are sector sizes (and thus, weapon ranges) and warp gate ranges in the block config. Spawn is a custom-built island at 7 70 7 but the sector is locked with a warpgate leading to 2 2 2.

AndyP added a comment.Aug 8 2015, 11:27 AM

Did you clear your client cache?
To get a fresh server state?

After this the error should be gone, or permanent.

Similar effect as in T264 now maybe

Yep, looks like it, but only making sure its not a different cause.

AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 11:38 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Sors added a subscriber: Sors.Aug 18 2015, 10:10 PM

Had this bug, too.
I started playing with 0.19361 and never had any previous version installed, so any conversion mistakes should be excludable.
Restarting the Client didn't fix my planet, only server restart did.

I can provide logs if any more are needed.

The only thing special to my planet is many auto rotating 1000-3000 objects on poles. When it happened i was standing on the surface.

My planet looked pretty much like Matt's.

Needs to be reopened, these screenshots were made in last public release:


thakyZ claimed this task.Aug 21 2015, 8:40 PM
thakyZ changed the task status from Open to In Queue (Game).Aug 22 2015, 5:45 PM

I was able to reproduce this multiple times on all occurrences it was because I loaded the planet after it was unloaded (i.e. Joining and going to the sector). So this would have to be because of the universe generation when joining.

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptAug 22 2015, 5:45 PM
thakyZ changed Last tested (version) from 0.19361 (Dev) to 0.19401.Aug 22 2015, 5:46 PM
Zyrenica added a subscriber: Zyrenica.EditedAug 22 2015, 6:59 PM

This issue seems to be on initial login, It is crashing the starside server whenever someone logs out on a planet then logs back in, the plate is shifted into the planet core and kills the server, although relogging fixes the orientation of the plate.

I have server logs from just before the crash showing that it happens right as someone logs in from what I can see at least.

Its happened twice to us since the latest patch, But was not occuring in the previous patch.

Edit:
Example sector that was crashing every time we tried to load it:


Crash logs:

Both files of which have also been sent to Schema.

Edit 2: In addition, the crash logs -always- reference a player logging in and a planet name just before the crash, then the server goes unresponsive and the logs fill with 'client has not sent login information' messages. As well the server dies to 0% CPU and no threads processing at all.

Usually when arriving at a planet causing the issue one of the plates is misaligned, and there is almost always a ship rail docked on the plate somewhere. Or in the case of the last time it crashed, just sitting on the surface.

In all cases the player that logged in had logged out on the planet plate in question.

Also a picture from one of our admins:

This has been a major issue today, crashing our server around once every hour or so as people login.

AndyP added a comment.Aug 23 2015, 1:01 PM

@Zyrenica may you (if allowed to) attach those logs here?
If not send them to me by mail, or direct message in phabricator.

Raiben added a subscriber: Raiben.Aug 24 2015, 1:23 PM

@AndyP those should be contained in the "crash logs.zip" above, there is also an example planet that was broken above as well. I hop this helps!

New information:
Almost every time it crashes I have the same section in the logs just before it goes unresponsive, 2 examples below:

[2015-08-23 16:48:26] [RAIL] Server(0) RECREATING RAIL FROM ROOT: Ship[TDF-1 Liberty Cruiser](29809)
[2015-08-23 16:48:26] [RAIL] Server(0) removeObjectPhysicsRecusively() removed physics for Ship[TDF-1 Liberty Cruiser](29809)
[2015-08-23 16:48:26] [RAIL] Server(0) removeObjectPhysicsRecusively() removed physics for Ship[F-302 1](29804)
[2015-08-23 16:48:26] [RAIL] Server(0) recreateRootObjectPhysics() added physics for Ship[TDF-1 Liberty Cruiser](29809)
[2015-08-23 16:48:26] [RAIL] Server(0) RECREATING RAIL FROM ROOT DONE: Ship[TDF-1 Liberty Cruiser](29809); DOCKED AND EXECUTED: false; DOCKED OR DIRTY: false
[2015-08-23 16:48:26] Server(0) PlayerCharacter[(ENTITY_PLAYERCHARACTER_2marko)(29817)] HANDLE SCHEDULED GRAVITY (0.0, 0.0, 0.0), Planet(29810)[s29799]Planet Planet Sandy Flaps (r114)[10000000hp]
[2015-08-23 16:48:26] [GRAVITY] PlayerCharacter[(ENTITY_PLAYERCHARACTER_2marko)(29817)] Server(0) SOURCE CHANGE null -> Planet(29810)[s29799]Planet Planet Sandy Flaps (r114)[10000000hp]
[2015-08-23 16:48:26] [SIMPLETRANSFORMABLE] Server(0) PlayerCharacter[(ENTITY_PLAYERCHARACTER_2marko)(29817)] gravity change sent
[2015-08-23 16:48:35] [SERVERPROCESSOR][WARNING} PING timeout warning. resending ping to RegisteredClient:

[2015-08-24 17:05:28] [RAIL] Server(0) RECREATING RAIL FROM ROOT: Planet(99599)[s99589]Planet DreeedxPlanet (r218)[10000000hp]
[2015-08-24 17:05:28] [RAIL] Server(0) removeObjectPhysicsRecusively() removed physics for Planet(99599)[s99589]Planet DreeedxPlanet (r218)[10000000hp]
[2015-08-24 17:05:28] [RAIL] Server(0) removeObjectPhysicsRecusively() removed physics for Ship[ZeldrenMk1](99601)
[2015-08-24 17:05:28] [RAIL] Server(0) removeObjectPhysicsRecusively() removed physics for Ship[TurretMk2](99592)
[2015-08-24 17:05:28] [RAIL] Server(0) removeObjectPhysicsRecusively() removed physics for Ship[TurretMk1](99594)
[2015-08-24 17:05:28] [RAIL] Server(0) recreateRootObjectPhysics() added physics for Planet(99599)[s99589]Planet DreeedxPlanet (r218)[10000000hp]
[2015-08-24 17:05:28] [RAIL] Server(0) RECREATING RAIL FROM ROOT DONE: Planet(99599)[s99589]Planet DreeedxPlanet (r218)[10000000hp]; DOCKED AND EXECUTED: false; DOCKED OR DIRTY: false
[2015-08-24 17:05:28] [AI] Setting callback Server(0) Ship[TurretMk2](99592) Executing send callback: true
[2015-08-24 17:05:28] [AI] Setting callback Server(0) Ship[TurretMk1](99594) Executing send callback: true
[2015-08-24 17:05:28] Server(0) PlayerCharacter[(ENTITY_PLAYERCHARACTER_Dreeedx)(99606)] HANDLE SCHEDULED GRAVITY (0.0, 0.0, 0.0), Planet(99599)[s99589]Planet DreeedxPlanet (r218)[10000000hp]
[2015-08-24 17:05:28] [GRAVITY] PlayerCharacter[(ENTITY_PLAYERCHARACTER_Dreeedx)(99606)] Server(0) SOURCE CHANGE null -> Planet(99599)[s99589]Planet DreeedxPlanet (r218)[10000000hp]
[2015-08-24 17:05:28] [SIMPLETRANSFORMABLE] Server(0) PlayerCharacter[(ENTITY_PLAYERCHARACTER_Dreeedx)(99606)] gravity change sent
[2015-08-24 17:05:36] [SERVERPROCESSOR][WARNING} PING timeout warning. resending ping to RegisteredClient:

This may not be related to this bug afer all and may be its own thing as the plate being misaligned is client side and seems to only occasionally happen.

AndyP claimed this task.Aug 25 2015, 6:49 PM

Will retest this in the next days, as we are in contact via SMD anyway. =)

AndyP reassigned this task from AndyP to thakyZ.Aug 25 2015, 6:50 PM

oh wait, thakyz could reproduce it, nothing more to do, lol

According to a support ticket, this should also happen when returning from the test-sector of a planetary shipyard.
(so restart is not a main factor, but the reload from disk)

isnt persistent as the original problem was. so no panic ;)

and all reports i have read so far on forum and here are load related

Phocian added a subscriber: Phocian.EditedOct 1 2015, 6:51 AM

Just to add, I have logged into the test server (build 0.19439) im stuck on Andy's planets core.
I have cleared the cache, I had to reload the custom textures so I know it cleared but im still on the planets core.

Also in the release version (0.19431) as an admin, if I admin warp via the galaxy map to a player on or near a planet I end up on the core.
Same thing happens if I /tp_to PLAYER and if I tp to a planet that has been selected.

AndyP added a comment.Oct 1 2015, 8:06 AM

Yeah, once you fall through the surface you cant really exit anymore.

However, if you teleport in any admin way, collision avoidance is off, to make sure you only relocate the sector, and not position in sector.
So, in this case the problem should be related to being catched in gravity before the surface was loaded.

AndyP changed Category from Engine to Control Block System: Shipyards.Oct 26 2015, 10:26 PM
AndyP changed Category from Control Block System: Shipyards to Engine.
Restricted Application removed a project: Game Development. · View Herald TranscriptNov 29 2015, 1:59 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:29 PM