Page MenuHomeSchine - Phabricator

Starmade | Removing containers places there content in an offset position
Closed, FinishedPublic

Description

on removal of any container its content gets spawned in an offset direction instead of the place where the container was originally placed. might be in context with the wrong drop spawn on player death fix.

i did set this to high because someone loosing on accident a big part of his survival game progress
is likely very unhappy. see also T101

to reproduce use supplied station and after filling the containers remove them to see where they drop the content

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19432
Category
Engine
First occurrence (version)
0.19289
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain

Related Objects

Event Timeline

SmilingDemon updated the task description. (Show Details)Jul 3 2015, 10:40 AM
SmilingDemon changed Category from none/unspecified to Engine.
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Single and Multi.
SmilingDemon set First occurrence (version) to 0.19289.
SmilingDemon changed Reproducible from uncertain to Yes.
SmilingDemon set Last tested (version) to 0.19304 (Dev).
SmilingDemon edited a custom field.
SmilingDemon edited Serverconfig (server.cfg). (Show Details)
SmilingDemon edited Clientconfig (settings.cfg). (Show Details)
SmilingDemon added a subscriber: SmilingDemon.
SmilingDemon created this task.
SmilingDemon raised the priority of this task from to High.
SmilingDemon changed the task status from Open to In Queue (Game).Jul 3 2015, 10:44 AM
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJul 3 2015, 10:44 AM
AndyP changed the visibility from "Custom Policy" to "Starmade (Project)".Jul 3 2015, 11:10 AM
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP changed the visibility from "Starmade (Project)" to "Public (No Login Required)".
AndyP added a subscriber: AndyP.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.
Restricted Application added a commit: Restricted Diffusion Commit.Jul 18 2015, 6:37 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 18 2015, 6:37 AM
SmilingDemon changed the task status from Resolved to In Queue (Game).Jul 19 2015, 8:12 PM

Containers now drop there content again where they get removed

but this seems to be connected to the fix for dropping inventory on death

because that is now again offset ... credits drop at place of death but items do not

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 19 2015, 8:12 PM
Restricted Application added a subscriber: Megacrafter127. · View Herald Transcript
Restricted Application added a commit: Restricted Diffusion Commit.Jul 20 2015, 4:24 PM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 20 2015, 4:24 PM
lancake changed the task status from Resolved to In Queue (Game).

Containers now drop there content again where they get removed

This was perhaps the case before, but now they all drop their contents right next to/on the nav marker, no matter where the chest is placed.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 24 2015, 9:02 PM
lancake changed Last tested (version) from 0.19304 (Dev) to 0.19339 (Dev).Jul 24 2015, 9:02 PM
Restricted Application added a commit: Restricted Diffusion Commit.Jul 25 2015, 5:50 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 25 2015, 5:50 AM
SmilingDemon changed Last tested (version) from 0.19339 (Dev) to 0.1935 (Dev).Jul 29 2015, 6:32 PM
SmilingDemon changed the task status from Resolved to In Queue (Game).Jul 29 2015, 6:38 PM

Containers still drop there content on the position of the station nav marker

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 29 2015, 6:38 PM
Restricted Application added a commit: Restricted Diffusion Commit.Jul 29 2015, 9:44 PM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 29 2015, 9:44 PM

For some reason the commit I made was wiped, should hopefully be in the next dev build.

SmilingDemon changed Last tested (version) from 0.1935 (Dev) to 0.19354 (Dev).Jul 30 2015, 4:40 PM
SmilingDemon closed this task as Closed.Jul 30 2015, 4:52 PM
SmilingDemon claimed this task.

OK fixed ... drops content at the proper place ... and drop on death is also good, checked that too

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 30 2015, 4:52 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
SmilingDemon reopened this task as In Queue (Game).Aug 2 2015, 12:39 PM
Restricted Application added a project: Game Development. · View Herald TranscriptAug 2 2015, 12:39 PM

sadly this happens in a specific limited way still on planets

How i did reproduce it

  1. placed 3 chest and a build block in the aproximate center of a Planet plate
  2. put in some blocks in every chest

  1. Removed the chest in the middle while in build mode (see that it drops the content right on spot)

  1. remove the remaining chest as astronaut and see ther is no drop
  2. Find the chests drop down in the Planets core offset to one side and in distance to each other as the chest have been.

found by spunkie

spunkie claimed this task.

just tested in singleplayer on all 12 planet sides and had no issues with large offset drops to the planet core.

procedure
1 place 6 storage blocks 1 block away from all other blocks
2 place 1 block in the upper left most slot in all storage blocks
3 removed 3 of the chests using build mode and 3 using astronaut mode

repeat for all 12 sides of planet

all tests resulted with items dropping no further than half a block from storage block position

so i guess the bug is gone until it isn't. *shrugs*

spunkie changed Last tested (version) from 0.19354 (Dev) to release 0.19361 .Aug 3 2015, 11:47 PM
spunkie removed spunkie as the assignee of this task.
Megacrafter127 shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:57 PM
Megacrafter127 changed the edit policy from "Starmade (Project)" to "All Users".
Megacrafter127 edited Serverconfig (server.cfg). (Show Details)
Megacrafter127 edited Clientconfig (settings.cfg). (Show Details)
Megacrafter127 claimed this task.
Megacrafter127 removed Megacrafter127 as the assignee of this task.

respacing

Can this be re-tested? It's possible that the fix I pushed did not get into the build that was used when this was considered unfixed.

problem is with this bug when i was showing it to smilingdemon on the test server it wouldn't always happen but once it did it would be reproducible several times and on other plates on same planet it wouldn't happen so it might take a while to get it to occur.

spunkie claimed this task.Sep 10 2015, 10:26 AM

-QA Testing-?

ok as far as spawning in an offset location from the containers original position this no longer happens

-storage blocks drop contents at their location when the block is removed in build or astronaut mode

-factories seem to take their inventory with them when removed and if you place another factory or a storage block in its place that block will have the previous factory's inventory in it

https://youtu.be/xyDMemfGe-M

AndyP added a subscriber: AndyP.Sep 10 2015, 10:33 AM

Right, noticed that factory thing too, but was not sure If I was confusing something and removed/replaced a different block.

Looks like factories do not eject contents at all when being removed.

Restricted Application added a commit: Restricted Diffusion Commit.Sep 10 2015, 3:42 PM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 10 2015, 3:42 PM

Okay, it appears that factory inventories were not being removed at all since the shipyard update. This should be fixed now. If there are any other recent issues about factory inventories not working correctly they are likely fixed as well.

-QA Testing-

Fix confirmed, factories now dropping their contents on removal.

https://youtu.be/SFO1WAYTwDs

spunkie closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptSep 12 2015, 3:24 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
spunkie changed Last tested (version) from release 0.19361 to 0.19432.Sep 12 2015, 3:25 AM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:31 PM