Page MenuHomeSchine - Phabricator

Starmade | SHOP_SPAWNING_PROBABILITY not working for trading guild shop stations
Confirmed task for development, LowPublic

Description

At least it does not appear like that. I put it on 0.0 and the custom trading guild stations with shop modules still spawn.

How to reproduce:

  1. put that server config value on 0.0
  2. find new stations and notice how trading guild stations still spawn (even the ones with shop modules)

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19291 (Dev)
Category
Universe
First occurrence (version)
0.18
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 25 2015, 12:45 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Universe.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.18.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19291 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Low.
Restricted Application added projects: Issue Navigation, Starmade. · View Herald TranscriptJun 25 2015, 12:45 PM
lancake set Task Type to Bug.Jun 25 2015, 12:46 PM
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 25 2015, 12:46 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 11:22 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
lancake claimed this task.Sep 21 2015, 10:48 AM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:09 PM
Restricted Application added a project: Universe. · View Herald TranscriptMar 10 2017, 5:09 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the Universe board.Mar 15 2017, 4:13 PM
Valck added a subscriber: Valck.EditedNov 3 2017, 12:11 PM

May have been fixed in the meantime?

I have SHOP_SPAWNING_PROBABILITY = 1.0E-4 //(must be between 0 and 1): 0 is no shops spawned in asteroid sectors, 1 is shop spawned in everyone (default: 8% -> 0.08), and I have a hard time finding any stick shops (as was intended by setting it that low)

Another possibility might be that a value of plain zero didn't work as intended, however with 0.0001, virtually no stick shops spawn anywhere.

Can't remember what version I was on when I modified that setting, but it can't have been very long after custom stations were implemented in 0.1595. It definitely seemed to be working in the latest stable 0.199.654, and long before that, too.
I have now set it specifically to 0.0 in 0.200.151, and haven't found any stick shops in a survey of about ten systems, besides the spawn shop at 2,2,2.

EDIT:
It may be worth noting that shops on custom stations do spawn, but I never expected them to be affected by that setting anyway, as there are other ways to prevent that (ie. don't have shop modules on custom station blueprints)