Page MenuHomeSchine - Phabricator

Starmade | (Turret) Remote Control active prevents normal usage
Closed, FinishedPublic

Description

All entities have "Remote Control" on true as default, which is fine.

The issue here is that turrets don't behave normally with "Remote Control" active.
They should behave according to their normal settings (target: any, selected, ...). Only when you have the "Turret Control" hotbar item selected should they switch over to remote control as only then the setting is relevant.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.289
Category
Control Block System: Rails/Docking
First occurrence (version)
0.200.2xx
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. make a shipcore with a power and rail turret axis
  2. dock a simple turret to it
  3. make sure its settings are "remote control: true", "active: true" and "target: any"
  4. spawn in an (unarmed) pirate target
  5. turret does not fire at it.
  6. turn off "remote control" and now it fires
Tester information (Internal use only)

Now it refuses to use its normal AI settings entirely if remote control is active, with "turret control" not selected.

Serverconfig (server.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>

Event Timeline

lancake created this task.Jan 3 2018, 4:50 PM
lancake created this object in space S3 Starmade.
lancake created this object with visibility "Public (No Login Required)".
lancake created this object with edit policy "Starmade (Project)".
Restricted Application added a project: CBS: Rails. · View Herald TranscriptJan 3 2018, 4:50 PM
schema added a commit: Restricted Diffusion Commit.Jan 4 2018, 11:27 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJan 4 2018, 11:27 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
schema added a subscriber: schema.Jan 4 2018, 11:27 AM

turret should now only not fire if icon is selected in the hotbar

lancake changed the task status from Resolved to In Queue.Jan 4 2018, 5:35 PM

-QA Testing-

Partial fix.

The AI refuses to switch to remote control if it already acquired a target to shoot at. It will continue to do so till the target is dead/gone and only then will switch over to remote control.
If you already start in remote control before it finds a target of its own, it works fine.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJan 4 2018, 5:36 PM
lancake edited Tester information (Internal use only). (Show Details)Jan 4 2018, 5:36 PM
schema added a commit: Restricted Diffusion Commit.Jan 5 2018, 4:14 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJan 5 2018, 4:14 PM
lancake changed the task status from Resolved to In Queue.Jan 7 2018, 7:22 PM

-QA Testing-

Now it refuses to use its normal AI settings entirely if remote control is active, with "turret control" not selected.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJan 7 2018, 7:22 PM
lancake edited Tester information (Internal use only). (Show Details)Jan 7 2018, 7:23 PM
lancake changed Last tested (version) from 0.200.277 to 0.200.282.
schema added a commit: Restricted Diffusion Commit.Jan 8 2018, 10:55 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJan 8 2018, 10:55 AM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 13 2018, 6:16 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.200.282 to 0.200.289.Jan 13 2018, 6:17 PM