Page MenuHomeSchine - Phabricator

Starmade | New/edited weapons start out with full charge
Closed, FinishedPublic

Description

Weapon computers that are newly placed, or are unlinked -> linked to the ship core again, or are edited in general, are fully charged and can fire once immediately.

Weapons should always start with 0 charge, and increasing weapon size should require you to charge the extra amount needed (starting from the amount already in it).

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.277
Category
Control Block System: Weapons
First occurrence (version)
0.200.215
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Build a weapon that is oversized for your reactor
  2. Notice you can immediately fire it, full charge from the get go.
  3. Either C + V the ship core to the computer again, or increase/decrease the weapon size
  4. Notice you can fire it once again.
Tester information (Internal use only)

Partial fix. It's fine for cannons, missiles and damage pulse.

It's not fine for Beams (damage beam, salvage, support), relinking/removing/adding blocks does still reset the charge to full for it.

Serverconfig (server.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>

Event Timeline

lancake created this task.Dec 5 2017, 4:02 PM
lancake created this object in space S3 Starmade.
lancake created this object with visibility "Public (No Login Required)".
lancake created this object with edit policy "Starmade (Project)".
Restricted Application added a project: CBS: Weapons. · View Herald TranscriptDec 5 2017, 4:02 PM
lancake updated the task description. (Show Details)Dec 5 2017, 4:02 PM
schema added a commit: Restricted Diffusion Commit.Dec 5 2017, 5:22 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 5 2017, 5:22 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Resolved to In Queue.Dec 7 2017, 1:55 PM

-QA Testing-

All new weapon types start with 0 charge, relinking the ship core to the weapon computer does not change that either so those 2 issues are fixed.

The other issues, relinking/removing/adding blocks does still reset the charge to full for:

  1. Beams
  2. Missiles
  3. Damage Pulse

It's completely fine for cannons though (as far as I can see).

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptDec 7 2017, 1:55 PM
lancake edited Tester information (Internal use only). (Show Details)Dec 7 2017, 1:56 PM
lancake changed Last tested (version) from 0.200.215 to 0.200.224.
lancake set First occurrence (version) to 0.200.215.
schema added a commit: Restricted Diffusion Commit.Dec 7 2017, 2:42 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptDec 7 2017, 2:42 PM
lancake changed the task status from Resolved to In Queue.Dec 9 2017, 9:28 PM

-QA Testing-

Partial fix. It's fine for cannons, missiles and damage pulse.

It's not fine for Beams (damage beam, salvage, support), relinking/removing/adding blocks does still reset the charge to full for it.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptDec 9 2017, 9:28 PM
lancake edited Tester information (Internal use only). (Show Details)Dec 9 2017, 9:28 PM
lancake changed Last tested (version) from 0.200.224 to 0.200.233.
schema added a commit: Restricted Diffusion Commit.Dec 10 2017, 2:26 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptDec 10 2017, 2:26 PM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 4 2018, 4:31 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.200.233 to 0.200.277.Jan 4 2018, 4:31 PM