Page MenuHomeSchine - Phabricator

Starmade | toggle charge issues
Closed, FinishedPublic

Description

The toggle charge mechanic, that is used in a few modules such as Thrust Blast, Scanner, ... has at least 2 issues, 1 of which is :


Issue 1

Left mouse clicks do multiple things, possibly causing issue 2 too in the process.
Left mouse click should only enable/disable the auto charge.

What it does additionally and that should be removed:

  1. Left mouse triggers the module (activates it, just like right click does)
  2. When disabled, Holding left mouse button for a bit too long, will charge it for that period instead of toggling the auto charge. It should never do this as it constantly clashes with the auto charge function.

Issue 2

The charge of a module is set and/or displayed incorrectly. Often you'll see it skip charges, or snap back to a previous state. Easy to see if you toggle it multiple times in a 10-20 seconds (I used thrust blast as example). Issue 1.2. is most likely interfering with this, this issue may not happen after that is fixed.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.233
Category
Control Block System: Functional
First occurrence (version)
0.200.191
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

Thrust blast and Reactor boost were used to test this, both display the same behavior.
Cannot reproduce this with the normal jump drive (as that is not toggle charge as default).

  1. When a toggle charge module is fully charged, left click once more and it will activate
  2. When a toggle charge is currently disabled, left click and hold it for a few seconds. It will charge while you hold it till you let go
  3. Trigger toggle charge multiple times in a short time span and you'll see the charge jump back and forth, skipping or reverting to a previous state.
Tester information (Internal use only)

Almost fixed, remaining issue is with normal charging. Not sure if that was the case before...but Left click charging (without toggle charge) activates the module too.

Easy to see with jump drive, make sure you do not use the "jump autocharge" chamber.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

StatusAssignedTask
Closedlancake
Closedlancake

Event Timeline

lancake created this task.Dec 4 2017, 7:24 PM
Restricted Application added a project: CBS: Functional. · View Herald TranscriptDec 4 2017, 7:24 PM
schema added a commit: Restricted Diffusion Commit.Dec 5 2017, 2:57 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 5 2017, 2:57 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Resolved to In Queue.Dec 9 2017, 12:03 AM

-QA Testing-

Almost fixed, remaining issue is with normal charging. Not sure if that was the case before...but Left click charging (without toggle charge) activates the module too.

Easy to see with jump drive, make sure you do not use the "jump autocharge" chamber.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptDec 9 2017, 12:03 AM
lancake edited Tester information (Internal use only). (Show Details)Dec 9 2017, 12:04 AM
lancake changed Last tested (version) from 0.200.214 to 0.200.228.
schema added a commit: Restricted Diffusion Commit.Dec 9 2017, 4:42 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptDec 9 2017, 4:42 PM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 9 2017, 8:40 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.200.228 to 0.200.233.Dec 9 2017, 8:40 PM