Page MenuHomeSchine - Phabricator

Starmade | Inner Ship Remotes register clicks in build mode
Closed, FinishedPublic

Description

If you have an inner ship remote selected on the flight interface hotbar and switch to build mode, it reacts to clicks anywhere in the interface.

Confirmed working as intended before the 0.200 series; tested with 0.199.654, 0.200.154 and .156

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.228
Category
Input/Controls
First occurrence (version)
0.200.156
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. spawn core
  2. add inner ship remote, name it and add it to the hotbar
  3. for demonstration purposes, add a cube light and connect it to the remote
  4. enter flight mode if not already there
  5. select inner ship remote hotbar button, click to confirm it works
  6. switch to build mode
  7. (left-)click on the ship or the UI; result: inner ship remote registers click, light toggles
  8. expected result: inner ship remote ignores clicks

Observations: The clicks don't seem to always register if you click on some UI elements, but usually the second or at most third click on that same element goes through to the remote. Clicks that would place blocks (regardless of whether a block is actually placed, e.g. if you click into empty space, or if the selected slot isn't a placeable block) always register.

Tester information (Internal use only)

2 ship hotbar items that still react to mouse clicks outside ship mode:

  1. Inner remote (as reported above)
  2. Rail turret axis

The inner remote toggles with your mouse clicks even outside ship mode, assuming you have that slot selected before you go to build mode or menus.
Rail turret axis does not fire with mouse clicks, but turrets still follow your mouse cursor in build mode.

Event Timeline

Valck created this task.Nov 7 2017, 5:08 PM
Valck added a comment.Nov 7 2017, 11:18 PM

More testing reveals the issue is not restricted to build mode only; it also occurs when entering the pause menu ([ESC]) from flight mode, and even another level further down, in the options menu.
Similar but not identical issues I found while searching before reporting this bug were T57 and T2422, both presumed fixed.

lancake added a subscriber: lancake.
lancake changed the task status from Open to In Queue.
lancake claimed this task.

-validated- & -confirmed-

2 ship hotbar items that still react to mouse clicks outside ship mode:

  1. Inner remote (as reported above)
  2. Rail turret axis

The inner remote toggles with your mouse clicks even outside ship mode, assuming you have that slot selected before you go to build mode or menus.
Rail turret axis does not fire with mouse clicks, but turrets still follow your mouse cursor in build mode.

Restricted Application removed a project: Issue Navigation. · View Herald TranscriptNov 13 2017, 4:10 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.Nov 13 2017, 4:11 PM
lancake updated the task description. (Show Details)
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake changed Last tested (version) from 0.200.156 to 0.200.164.
lancake changed First occurrence (version) from 0.200 to 0.200.156.
lancake raised the priority of this task from Normal to Pre-Release Quality Assurance.
Restricted Application added projects: Game Development, Controls. · View Herald TranscriptNov 13 2017, 4:11 PM
schema added a commit: Restricted Diffusion Commit.Nov 13 2017, 11:50 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 13 2017, 11:50 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 9 2017, 12:12 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.200.164 to 0.200.228.Dec 9 2017, 12:12 AM