Page MenuHomeSchine - Phabricator

Starmade | reactor HP does not trigger HP conditions
Closed, FinishedPublic

Description

It seemingly worked before but I can't see it work properly now, consists of multiple issues.


Issue 1
HPConditionTriggerList does not work anymore: the current config has it set that you overheat and lose shields/thrust/power at 50% reactor HP. You lose control at 55% reactor HP too. None of these conditions seem to trigger.

The only time when you overheat, is when the ship core is 'destroyed'. No matter what your reactor HP is currently at.


Issue 2
The last shot that takes down the remaining reactor HP blocks, will not correctly change the reactor HP.

Instead, the reactor HP will go to 0 HP out of previously max as it should, only to be set a new current and max value immediately after that. The current and max HP that is set, corresponds with the reactor HP contributing blocks that were all destroyed in the last shot.

For example:
10 reactor blocks => 400 HP / 400 HP
-> Kill 8 blocks
2 reactor blocks => 80 HP / 400 HP
-> Kill the last 2 blocks with a single projectile (penetration kills the 2nd one)
0 reactor blocks => 0 HP /. 400 HP that is immediately set to 80 HP / 80 HP. The HP value of those 2 remaining blocks that were destroyed.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.199
Category
Control Block System: Systems
First occurrence (version)
0.200.148
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. make a ship core and put down some reactor blocks on it
  2. put some shields on it too to check its HP values
  3. kill reactor blocks with your (overpowered) pistol, try to prevent killing multiple blocks with a single shot
  4. go below 50% reactor HP, notice how it does not overheat or set the shield HP to 0
  5. keep going till there are no reactor blocks remaining
  6. reactor HP should be 40 HP out of 40 HP now, or more if you killed multiple blocks with a single shot
  7. do the same test again but kill the ship core immediately before doing anything else, you'll overheat
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Nov 4 2017, 4:26 PM
Restricted Application added a project: CBS: Systems. · View Herald TranscriptNov 4 2017, 4:26 PM
schema added a commit: Restricted Diffusion Commit.Nov 6 2017, 9:51 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 6 2017, 9:51 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript

-QA Testing-

They trigger alright, can see some more issues related to it now but should be unrelated with this one.
Fix confirmed.

lancake changed Last tested (version) from 0.200.153 to 0.200.199.Dec 1 2017, 10:18 PM
lancake closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 1 2017, 10:18 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript