Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2623

Starmade | Conduit sanity check not working properly
Closed, FinishedPublic
Actions

Description

Description of Craft: A basic ship with a 5 block, tier 0 reactor.

Note: Chamber Tier shall be used to refer to the order in which chambers are connected. A Chamber Tier of 1 is a chamber that is connected directly by conduit to the reactor. A Chamber Tier of 2 is a chamber that is connected by conduit to another matching chamber.

Description of Bug: When adding a chamber block to a chamber setup in which the added chamber block would make one chamber tree a Chamber Tier 2, if the added chamber block touches a chamber block of the same type that is part of a Chamber Tier 1 chamber tree, then the game crashes. If the game does not crash immediately, attempting to remove one of the chamber blocks will crash the game. I have tested this with both Stealth Chambers and with Defence Chambers.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.233
Category
Control Block System: Functional
First occurrence (version)
0.200.121
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Build a chamber tree that would be considered to consist of a Chamber Tier 1
  1. Build a chamber tree that would be considered to consist of a Chamber Tier 2 wherein the chamber block that connects to the second conduit of the Chamber Tier 2 chamber system also touches a chamber block of the same type that connects to a conduit directly into the ship (Chamber Tier 1).

Note: Specifically tested with Stealth, and Defence Chambers. May apply to other chambers as well, but I cannot speak for those.

Tester information (Internal use only)

-QA Testing-

Not fixed:


Normal situation, 1 chamber connected.


Invalid situation, connecting 2 different chamber types with each other, issues here are:

  1. It shows up as seemingly valid in the Tree GUI
    1. You can click on the invalid chamber and you are able to click on Specify Chamber too, you are not able to select anything though so you can't make it work.
    2. The invalid chamber should appear Red as it normally does when it's invalid (not a big enough chamber for example)
    3. The invalid chamber tooltip does not point out the chamber is invalid -> "Click to select and specify"


Invalid situation, one conduit leads to 2 different chamber types, issue here is:

  1. It appears double, standalone and linked to the other chamber.

You can also specify chambers individually, then connect them up like the previous example to achieve this:

Related Objects
Search...

Event Timeline

petlahk created this task.Oct 14 2017, 4:37 AM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 14 2017, 9:13 AM
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP changed Affected Gamemode(s) from Singleplayer to Single and Multi.
AndyP edited SMC-Report. (Show Details)
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP shifted this object from the S1 Public space to the S3 Starmade space.
AndyP claimed this task.
AndyP updated the task description. (Show Details)Oct 14 2017, 9:16 AM
AndyP edited Tester information (Internal use only). (Show Details)
AndyP moved this task from New / Unconfirmed to Confirmed on the Issue Navigation board.
AndyP changed the task status from Open to In Queue.
AndyP raised the priority of this task from Normal to Pre-Release Quality Assurance.

-Confirmed-

Forwarding.

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptOct 14 2017, 9:17 AM
petlahk added a comment.Oct 14 2017, 6:22 PM

Here's a visual for better clarification of what was happening. It seems that you figured out what I meant based on the fact that you marked it as confirmed. But, I figure the visual won't hurt.

AndyP added a comment.Oct 14 2017, 7:16 PM

Yeah, the same problem should apply,
I just narrowed down the few cases where it fails to work properly in the GUI, I assume with those base problems fixed,
it should not happen deeper in the tree too.

However, chambers being directly adjacent while belonging to different tree-arms would for sure be something to check at a later point.

schema added a commit: Restricted Diffusion Commit.Oct 31 2017, 12:38 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptOct 31 2017, 12:38 PM
lancake added subscribers: AndyP, lancake.Nov 2 2017, 4:19 PM
lancake changed the task status from Resolved to In Queue.
lancake claimed this task.

-QA Testing-

Not fixed:


Normal situation, 1 chamber connected.


Invalid situation, connecting 2 different chamber types with each other, issues here are:

  1. It shows up as seemingly valid in the Tree GUI
    1. You can click on the invalid chamber and you are able to click on Specify Chamber too, you are not able to select anything though so you can't make it work.
    2. The invalid chamber should appear Red as it normally does when it's invalid (not a big enough chamber for example)
    3. The invalid chamber tooltip does not point out the chamber is invalid -> "Click to select and specify"


Invalid situation, one conduit leads to 2 different chamber types, issue here is:

  1. It appears double, standalone and linked to the other chamber.

You can also specify chambers individually, then connect them up like the previous example to achieve this:

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptNov 2 2017, 4:19 PM
lancake edited Tester information (Internal use only). (Show Details)Nov 2 2017, 4:20 PM
lancake changed Last tested (version) from 0.200.121 to 0.200.151.
lancake changed Category from none/unspecified to Control Block System: Functional.
lancake set First occurrence (version) to 0.200.121.
lancake renamed this task from [Dev Build] 0.200.121 - Mixing Second Tier Chambers on one tree and First Tier Chambers on another tree does not end well. to Conduit sanity check not working properly.
Restricted Application added a project: CBS: Functional. · View Herald TranscriptNov 2 2017, 4:20 PM
schema added a commit: Restricted Diffusion Commit.Nov 3 2017, 12:55 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptNov 3 2017, 12:55 PM
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Dec 9 2017, 8:46 PM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 9 2017, 8:46 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.200.151 to 0.200.233.Dec 9 2017, 8:46 PM