Starmade | A few null pointers
Closed, FinishedPublic
Actions

Description

If a station has a shop module

java.lang.NullPointerException
	at org.schema.game.client.view.gui.shop.shopnew.ShopPanelNew$32.toString(ShopPanelNew.java:1076)
	at org.schema.schine.graphicsengine.forms.gui.GUITextOverlay.setTextSimple(GUITextOverlay.java:824)
	at org.schema.game.client.view.gui.shop.shopnew.ShopPanelNew.createBlockDescriptionPanel(ShopPanelNew.java:1066)
	at org.schema.game.client.view.gui.shop.shopnew.ShopPanelNew.createShopPane(ShopPanelNew.java:583)
	at org.schema.game.client.view.gui.shop.shopnew.ShopPanelNew.recreateTabs(ShopPanelNew.java:212)
	at org.schema.game.client.view.gui.shop.shopnew.ShopPanelNew.draw(ShopPanelNew.java:140)
	at org.schema.game.client.view.gui.PlayerPanel.draw(PlayerPanel.java:275)
	at org.schema.game.client.view.gui.GuiDrawer.draw(GuiDrawer.java:195)
	at org.schema.game.client.view.WorldDrawer.drawGUI(WorldDrawer.java:837)
	at org.schema.game.client.view.MainGameGraphics.framebufferPass(MainGameGraphics.java:910)
	at org.schema.game.client.view.MainGameGraphics.draw(MainGameGraphics.java:454)
	at org.schema.schine.graphicsengine.core.GLFrame.draw(GLFrame.java:502)
	at org.schema.schine.graphicsengine.core.GLFrame.render(GLFrame.java:546)
	at org.schema.schine.graphicsengine.core.GLFrame.doFrameAndUpdate(GLFrame.java:693)
	at org.schema.schine.graphicsengine.core.GraphicsContext.mainLoop(GraphicsContext.java:808)
	at org.schema.schine.graphicsengine.core.GraphicsContext.startUp(GraphicsContext.java:705)
	at org.schema.game.client.controller.GameMainMenuController.startGraphics(GameMainMenuController.java:1148)
	at org.schema.game.common.Starter.startMainMenu(Starter.java:1452)
	at org.schema.game.common.Starter.main(Starter.java:996)

If you get in a build block on a station

java.lang.NullPointerException
	at org.schema.game.common.controller.elements.ManagerContainer.handleControl(ManagerContainer.java:844)
	at org.schema.game.common.controller.elements.ManagerContainer.handle(ManagerContainer.java:819)
	at org.schema.game.common.controller.SpaceStation.handleControl(SpaceStation.java:341)
	at org.schema.game.common.data.player.ControllerState.handleClientControllerStateFor(ControllerState.java:165)
	at org.schema.game.common.data.player.ControllerState.update(ControllerState.java:660)
	at org.schema.game.common.data.player.PlayerState.updateLocal(PlayerState.java:1677)
	at org.schema.game.server.controller.GameServerController.update(GameServerController.java:1364)
	at org.schema.schine.network.server.ServerController.run(ServerController.java:275)
	at java.lang.Thread.run(Thread.java:745)

java.lang.NullPointerException
	at org.schema.game.common.controller.elements.ManagerContainer.handleControl(ManagerContainer.java:844)
	at org.schema.game.common.controller.elements.ManagerContainer.handle(ManagerContainer.java:819)
	at org.schema.game.common.controller.SpaceStation.handleControl(SpaceStation.java:341)
	at org.schema.game.common.data.player.ControllerState.handleClientControllerStateFor(ControllerState.java:165)
	at org.schema.game.common.data.player.ControllerState.update(ControllerState.java:660)
	at org.schema.game.common.data.player.PlayerState.updateLocal(PlayerState.java:1677)
	at org.schema.game.client.controller.GameClientController.updateOthers(GameClientController.java:3176)
	at org.schema.game.client.controller.GameClientController.update(GameClientController.java:1346)
	at org.schema.schine.graphicsengine.core.GLFrame.update(GLFrame.java:842)
	at org.schema.schine.graphicsengine.core.GLFrame.doFrameAndUpdate(GLFrame.java:702)
	at org.schema.schine.graphicsengine.core.GraphicsContext.mainLoop(GraphicsContext.java:808)
	at org.schema.schine.graphicsengine.core.GraphicsContext.startUp(GraphicsContext.java:705)
	at org.schema.game.client.controller.GameMainMenuController.startGraphics(GameMainMenuController.java:1148)
	at org.schema.game.common.Starter.startMainMenu(Starter.java:1452)
	at org.schema.game.common.Starter.main(Starter.java:996)

Full logs:

logstarmade.0.log1 MBDownload

Getting in a ship that is docked

java.lang.NullPointerException
	at org.schema.game.common.controller.elements.thrust.ThrusterElementManager.handle(ThrusterElementManager.java:403)
	at org.schema.game.common.controller.elements.thrust.ThrusterCollectionManager.handleControl(ThrusterCollectionManager.java:141)
	at org.schema.game.common.controller.elements.ManagerContainer.handleControl(ManagerContainer.java:844)
	at org.schema.game.common.controller.elements.ManagerContainer.handle(ManagerContainer.java:819)
	at org.schema.game.common.controller.Ship.handleControl(Ship.java:770)
	at org.schema.game.common.data.player.ControllerState.handleClientControllerStateFor(ControllerState.java:165)
	at org.schema.game.common.data.player.ControllerState.update(ControllerState.java:660)
	at org.schema.game.common.data.player.PlayerState.updateLocal(PlayerState.java:1677)
	at org.schema.game.server.controller.GameServerController.update(GameServerController.java:1364)
	at org.schema.schine.network.server.ServerController.run(ServerController.java:275)
	at java.lang.Thread.run(Thread.java:745)

Details

Commits: Restricted Diffusion Commit
Task Type: Bug

Testing Results

Affected Gamemode(s): Single and Multi
Reproducible: Yes
Last tested (version): 0.200.114
Category: Control Block System: Systems
First occurrence (version): 0.199.654

Hardware/Software/System

OS-Specific: No
Hardware-Specific: No
Video Card Vendor: uncertain

Steps to reproduce

make a station with build block
put a shop block on it and add to trade network (not needed for the crash though)
/force_save just in case
get in build block

-> crash

dock a ship to a rail / get in a ship that is docked

-> crash

Serverconfig (server.cfg)

<replace this line with the file content>

Clientconfig (settings.cfg)

<replace this line with the file content>

Related Objects
Search...

		Status	Assigned	Task
		Closed	lancake	T2720 Master task power 2.0
		Closed	lancake	T2563 A few null pointers

Event Timeline

lancake created this task.Sep 4 2017, 2:25 PM

lancake created this object in space Restricted Space.

Restricted Application added a project: CBS: Systems. · View Herald TranscriptSep 4 2017, 2:25 PM

schema added a commit: Restricted Diffusion Commit.Sep 5 2017, 11:34 PM

schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 5 2017, 11:34 PM

Restricted Application added a subscriber: AndyP. · View Herald Transcript

lancake shifted this object from the Restricted Space space to the S3 Starmade space.Oct 6 2017, 2:20 PM

lancake renamed this task from New Power: A few null pointers to A few null pointers.

-QA Testing-

All of the previously mentioned nullpointers are gone, needs new task(s) for any other exceptions that occur.

lancake closed this task as Closed.Oct 6 2017, 2:23 PM

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptOct 6 2017, 2:23 PM

Restricted Application removed a subscriber: AndyP. · View Herald Transcript

lancake changed Last tested (version) from 0.199.654 to 0.200.114.Oct 6 2017, 2:26 PM

lancake added a parent task: T2720: Master task power 2.0.Dec 8 2017, 11:50 PM

Starmade | A few null pointersClosed, FinishedPublicActions