Page MenuHomeSchine - Phabricator

Starmade | Fill tool allows replacing with non cubic shapes
Closed, FinishedPublic

Description

Not sure if this is intended behavior, but you can replace normal blocks with wedges/heptas and any other shape.
It really has no use, and these shapes have issues with undo/redo actions as mentioned in T2431 which makes me to believe it's not intended.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.633
Category
Engine
First occurrence (version)
0.199.618
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Place fill origin on any block
  2. Select a shape in your hotbar (wedge)
  3. Use fill
Tester information (Internal use only)

Same behavior as before except that the undo/redo actions don't record the non cubic replacing (good thing).
I did notice another issue though:

If you don't replace, but just do a normal fill with non cubic shapes. It doesn't fill (which is good) but it still acts as "progress" and moves on the to be filled blocks to the next step. When you after a few tries, use a cubic block, you'll have an area that doesn't get filled.
Undo and Redo actions don't record the fake filling with non cubic shapes though, so that's good.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jul 4 2017, 11:17 AM
Restricted Application added a project: Engine. · View Herald TranscriptJul 4 2017, 11:17 AM
schema added a commit: Restricted Diffusion Commit.Jul 5 2017, 10:07 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 5 2017, 10:07 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript

-QA Testing-

Same behavior as before except that the undo/redo actions don't record the non cubic replacing (good thing).
I did notice another issue though:

If you don't replace, but just do a normal fill with non cubic shapes. It doesn't fill (which is good) but it still acts as "progress" and moves on the to be filled blocks to the next step. When you after a few tries, use a cubic block, you'll have an area that doesn't get filled.
Undo and Redo actions don't record the fake filling with non cubic shapes though, so that's good.

lancake edited Tester information (Internal use only). (Show Details)Jul 6 2017, 3:09 PM
lancake changed Last tested (version) from 0.199.629 to 0.199.633.
lancake changed the task status from Resolved to In Queue.
Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJul 6 2017, 3:09 PM
schema added a commit: Restricted Diffusion Commit.Jul 7 2017, 2:49 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJul 7 2017, 2:49 PM
AndyP moved this task from Backlog / Unclassed to Building on the Engine board.Jul 20 2017, 11:09 PM
AndyP edited projects, added Engine (Building); removed Engine.
AndyP moved this task from Backlog / Unclassed to Alpha on the Engine (Building) board.
lancake closed this task as Closed.Jul 21 2017, 3:54 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 21 2017, 3:54 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 22 2017, 9:53 PM