Page MenuHomeSchine - Phabricator

Starmade | Fill tool doesn't adjust fill step after undo
Closed, FinishedPublic

Description

If you undo a step of the fill tool, the next fill will just pick off where it ended up last time. This can lead to unwanted behavior where the fill tool keeps filling as if all steps before are still there, leading to hollow structures.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.618
Category
Engine
First occurrence (version)
0.199.611
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce



Tester information (Internal use only)

Works absolutely fine when it comes to the normal placement filling (replacing air with block).

Has 2 issues remaining if you replace fill an existing block with another one

Issue 1

If you completely undo the replacement fill steps (so it's back at the very beginning), the next fill step you do will not replace the first block where the fill tool has been set. Really trivial as the next step after that will fill/replace it just fine.

Issue 2

Step is set incorrectly, just like in the description if you:

  1. do 2 fill steps
  2. undo
  3. redo
  4. undo

do another fill step and it puts it on the wrong spot does it at the wrong spot.
I do not notice this issue if i replace air blocks with the fill tool, only happens when they're replacing real blocks.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jun 19 2017, 9:10 AM
Restricted Application added a project: Engine. · View Herald TranscriptJun 19 2017, 9:10 AM
lancake raised the priority of this task from Normal to Pre-Release Quality Assurance.Jun 19 2017, 5:25 PM
schema added a commit: Restricted Diffusion Commit.Jun 21 2017, 10:19 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 21 2017, 10:19 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Resolved to In Queue.Jun 21 2017, 7:57 PM

-QA Testing-

Works absolutely fine when it comes to the normal placement filling (replacing air with block).

Has 2 issues remaining if you replace fill an existing block with another one

Issue 1

If you completely undo the replacement fill steps (so it's back at the very beginning), the next fill step you do will not replace the first block where the fill tool has been set. Really trivial as the next step after that will fill/replace it just fine.

Issue 2

Step is set incorrectly, just like in the description if you:

  1. do 2 fill steps
  2. undo
  3. redo
  4. undo

do another fill step and it puts it on the wrong spot does it at the wrong spot.
I do not notice this issue if i replace air blocks with the fill tool, only happens when they're replacing real blocks.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJun 21 2017, 7:57 PM
lancake edited Tester information (Internal use only). (Show Details)Jun 21 2017, 7:57 PM
lancake changed Last tested (version) from 0.199.611 to 0.199.614.
schema added a commit: Restricted Diffusion Commit.Jun 23 2017, 1:08 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJun 23 2017, 1:08 PM

-QA Testing-

Both issues are fixed, but undo/redo doesn't work properly if you replace fill cubic blocks with any other shape. Normally this should do nothing but for some reason it works now, will make a separate task for that.

lancake changed Last tested (version) from 0.199.614 to 0.199.618.Jun 27 2017, 1:11 PM
lancake closed this task as Closed.Jul 7 2017, 12:34 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 7 2017, 12:34 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 20 2017, 10:40 PM