Starmade | Shipyard fails to load design: "Overlaps with Structure"
Confirmed task for development, HighPublic

Description

When loading a 3k mass ship in a shipyard (that was built in said shipyard), I get the error "Removing Design because it overlaps with Structure"

I know it doesnt.

Another 3k mass design fails too, but if I repeat the process 4-5 times it loads. On this design though, it fails over and over. The problematic design is essentially a single big turret (ie. it has large docked entities). As thats the main difference between the two designs, I wonder if thats causing the error...

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.200.335
Category
Control Block System: Shipyards
First occurrence (version)
0.198.xxx
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Make a shipyard
  2. Dock a tiny ship to the shipyard that has one or more docks of its own, also take a blueprint for later use
  3. Deconstruct the ship to design
  4. Confirm that you can load/unload the design. Should fail to do so at least once
  5. Try the same steps as above without docks on the tiny ship, should never fail to load
Tester information (Internal use only)

This is an issue related to have docks on your design. Ship size does not matter as this even occurs on the smallest of examples.

If you deconstruct or unload a design of a ship that has docks on it, not everything of that ship gets wiped properly after it is finished deconstructing. I believe the shipyard will still think the docks are there, giving a false positive for designs you're trying to load that have their own docks overlapping with them.

It should load the design still most of the time, but you will often fail first and then succeed on the 2nd attempt. I'm not sure if that's because a failure to load wipes the bad stuff already, or that it is just a coincidence of my test setup. Should be absolutely fine if you try to load a design that has no docks at all though.

The issue itself can be worked around by unloading/loading the sector again.
You can also construct/deconstruct a tiny ship without docks to wipe the old data and reset it back to a normal state. Loading/unloading the design multiple times should work too but might depend on ship size and dock count.

Serverconfig (server.cfg)
 <replace this block with the file content, 
but do not remove the first and last line. 
Before using the paste function, mark the area from the 
opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
 <replace this block with the file content, 
but do not remove the first and last line. 
Before using the paste function, mark the area from the 
opening angle bracket to the closing angle bracket>
5ilence created this task.Apr 19 2017, 5:54 AM
lancake claimed this task.Apr 23 2017, 10:05 AM
lancake moved this task from New / Unconfirmed to Confirmed on the Issue Navigation board.
lancake added a subscriber: lancake.

-validated-

Apparently there is no existing task of this issue. It's one of the older shipyard issues most likely going back to its dev builds.
There's some issue with loading/unloading designs where the game still thinks an older design is loaded, thus "overlaps with structure" as it is part of the shipyard.

Usually waiting a minute or so after unloading the last ship to load a new design should do the trick. Will have to look into it again to get a reliable way to reproduce.

lancake shifted this object from the S1 Public space to the S3 Starmade space.Apr 23 2017, 10:06 AM
lancake changed the title from "Shipyard fails to load ship: "Overlaps with Structure"" to "Shipyard fails to load design: "Overlaps with Structure"".
lancake raised the priority of this task from "Normal" to "High".
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
Restricted Application added a subscriber: AndyP. · View Herald TranscriptApr 23 2017, 10:06 AM
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.Apr 23 2017, 10:06 AM
lancake changed Reproducible from uncertain to Yes.
lancake changed Category from none/unspecified to Control Block System: Shipyards.
lancake set First occurrence (version) to 0.198.xxx.
lancake changed the task status from "Open" to "In Queue".Apr 1 2018, 4:15 PM
lancake edited Steps to reproduce. (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
lancake set Last tested (version) to 0.200.335.
Restricted Application edited projects, added Game Development, CBS: Shipyards; removed Issue Navigation. · View Herald TranscriptApr 1 2018, 4:15 PM

-confirmed-

This is an issue related to have docks on your design. Ship size does not matter as this even occurs on the smallest of examples.

If you deconstruct or unload a design of a ship that has docks on it, not everything of that ship gets wiped properly after it is finished deconstructing. I believe the shipyard will still think the docks are there, giving a false positive for designs you're trying to load that have their own docks overlapping with them.

It should load the design still most of the time, but you will often fail first and then succeed on the 2nd attempt. I'm not sure if that's because a failure to load wipes the bad stuff already, or that it is just a coincidence of my test setup. Should be absolutely fine if you try to load a design that has no docks at all though.

The issue itself can be worked around by unloading/loading the sector again.
You can also construct/deconstruct a tiny ship without docks to wipe the old data and reset it back to a normal state. Loading/unloading the design multiple times should work too but might depend on ship size and dock count.