Page MenuHomeSchine - Phabricator

Starmade | Replace helper not re-applying connections
Confirmed task for development, NormalPublic

Description

When using the replace tool on salvage modules to mass-link them to a controller, the slaving isn't applied to the area when there were some modules slaved already, or on subsequent replacement actions.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.472
Category
Control Block System: Functional
First occurrence (version)
0.199.466
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  • Create an array of salvaging modules, slave some to a salvage computer.

  • Configure the replace tool to replace salvage modules with the salvage modules on the hotbar

(pressing F5 reset the selection of the salvage module)

  • Try to replace
  • The existing slave links get removed

  • The salvage modules in this area can't be linked any more with the replace tool, but can be linked manually.

I tried to unselect the computer to see if this was just a graphical issue, but this doesn't seem to be the case.

Tester information (Internal use only)

Doesn't really feel like a bug to me, it's just that the replace filter doesn't auto link anything that you're linked to with C, nor does it keep the link in if you replace a linked block with the same block type since it's basically removing the original one (which includes the connections) and replaces it with whatever you have selected.

It's unwanted behavior though, improvements:

  • if you have a C connection, putting down a block through replacing should auto link it if possible
  • if you don't have one and the block to be replaced is linked, and you replace it by the same block, the link should not be removed
Serverconfig (server.cfg)
 <replace this block with the file content, 
but do not remove the first and last line. 
Before using the paste function, mark the area from the 
opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
 <replace this block with the file content, 
but do not remove the first and last line. 
Before using the paste function, mark the area from the 
opening angle bracket to the closing angle bracket>

Event Timeline

lancake added a subscriber: lancake.Mar 8 2017, 1:46 PM

-validated- & -confirmed-

Doesn't really feel like a bug to me, it's just that the replace filter doesn't auto link anything that you're linked to with C, nor does it keep the link in if you replace a linked block with the same block type since it's basically removing the original one (which includes the connections) and replaces it with whatever you have selected.

It's unwanted behavior though, improvements:

  • if you have a C connection, putting down a block through replacing should auto link it if possible
  • if you don't have one and the block to be replaced is linked, and you replace it by the same block, the link should not be removed
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake changed Last tested (version) from 0.199.466 to 0.199.472.
lancake set First occurrence (version) to 0.199.466.
lancake renamed this task from Replace helper not re-applying slaving to Replace helper not re-applying connections.
lancake changed the task status from Open to In Queue (Game).
lancake claimed this task.
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptMar 8 2017, 1:47 PM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:15 PM
Restricted Application added a project: CBS: Functional. · View Herald TranscriptMar 10 2017, 5:15 PM