Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2100

Starmade | Sell available and price updates at the wrong time
Closed, FinishedPublic
Actions

Description

CONTEXT: Only applies when their are trade orders underway

It is fine for the BUY Tab, not for the SELL Tab

The problem here is that when you SELL to the target shop, they don't have the blocks yet so they recalculate the prices and sell limit on their current stock, not on the stock they'll have after that trade order finishes which is partially fine.

As long as the trade is on its way:

  1. BUY Available and price doesn't get adjusted(which is FINE)
  2. SELL Available and price doesn't get adjusted (which is NOT FINE)

If SELL Available and its price doesn't get adjusted to the "promised" amount ,I could keep selling those 107 785 blocks till the first Trade order arrives.

You don't have this if you BUY from the target shop, their stock immediately goes down and the buy/sell limit gets adjusted after the order has been placed so for them it's fine.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.344
Category
Tradenetwork/Shops
First occurrence (version)
0.199.342
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Buy enough blocks from a shop so that it wants to buy these blocks again
  2. Sell that amount
  3. Before that trade order finishes, make a new sell order to them with the same amount

Repeat a few times and notice how you've sold them blocks above their actual limit.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

lancake created this task.Dec 16 2016, 2:27 PM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptDec 16 2016, 2:27 PM
lancake updated the task description. (Show Details)Dec 16 2016, 2:29 PM
lancake updated the task description. (Show Details)Dec 16 2016, 2:35 PM
schema changed the task status from In Queue (Game) to Resolved.Dec 16 2016, 4:09 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 16 2016, 4:09 PM
lancake added a comment.Dec 16 2016, 8:27 PM

-QA Testing-

Looks fine in SP but it does require multiplayer testing with multiple trade nodes trying to sell the same block to the same trade node.

lancake changed Last tested (version) from 0.199.342 to 0.199.344.Dec 16 2016, 8:27 PM
Restricted Application added a project: Tradenetwork. · View Herald TranscriptMar 10 2017, 6:06 PM
AndyP added a comment.Mar 14 2017, 11:10 PM

Oh, yeah, we tried that with a few people back then

AndyP moved this task from Backlog / Unclassed to Alpha on the Tradenetwork board.Mar 15 2017, 4:10 PM
lancake closed this task as Closed.Apr 28 2017, 1:24 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 28 2017, 1:24 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript