Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2087

Starmade | Prices don't update after trade order
Closed, FinishedPublic
Actions

Description

Can be found by doing multiple buy or sell orders of the same block type to a trade node.

The 1st time you do it, the price you're buying is the actual price and you don't notice an issue.
The 2nd time, the price didn't update in the UI but it did in reality. So you end up with a price that's higher or lower than what you're shown.

Because of that, the trade order menu shows you the wrong credits but completing the order will use the correct amount of credits (or the shop will complain you don't have enough credits).

Restarting the server updated the prices again for me.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.342
Category
Tradenetwork/Shops
First occurrence (version)
0.199.334
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Buy 10000 Thrusters from trading guild, only fill the shop with the money it needs.
  2. Buy 10000 Thrusters more from the trading guild, fill with the same amount as shown.
  3. Try to complete the order but it will fail, the price of thrusters is higher now than what you put in the shop.
Tester information (Internal use only)

Price changes don't update for your client. It will still display the old price in both the Trade menu and in the Trade order dialog.
Finalizing a trade offer does require the actual amount of credits needed though, so on the server the price is fine.

Restarting the server or reloging both update the prices for the UI.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

lancake created this task.Dec 13 2016, 12:42 AM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptDec 13 2016, 12:42 AM
schema changed the task status from In Queue (Game) to Resolved.Dec 13 2016, 3:53 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 13 2016, 3:53 PM
lancake changed the task status from Resolved to In Queue (Game).Dec 15 2016, 12:09 AM

-QA Testing-

Not fixed, see Tester Information.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptDec 15 2016, 12:09 AM
lancake edited Tester information (Internal use only). (Show Details)Dec 15 2016, 12:30 AM
lancake changed Last tested (version) from 0.199.334 to 0.199.336.
schema changed the task status from In Queue (Game) to Resolved.Dec 15 2016, 11:25 AM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 15 2016, 11:25 AM
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Dec 16 2016, 4:27 PM
lancake closed this task as Closed.

-QA Testing-

Seems OK now, there's another issue (T2100) I noticed while testing this but it's unrelated to the fix.
Some display issue with the debug inventories but it's OK server side so doesn't need to be fixed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 16 2016, 4:27 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.199.336 to 0.199.342.Dec 16 2016, 4:27 PM
Restricted Application added a project: Tradenetwork. · View Herald TranscriptMar 10 2017, 6:06 PM