Page MenuHomeSchine - Phabricator

Starmade | Derelict stations get false positive removal for "ship only blocks"
Closed, FinishedPublic

Description

Ran across bug that would load a default derelict station in the first time but a second visit would cause several warnings and the station would poof but leave its turrets.

https://youtu.be/8RrshXF1NL4
warning windows occur @ 7:40

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.199.357
Category
Engine
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. find a default derelict ( in my case it was an Eta station)
  2. leave the sector far enough for it to unload
  3. fly back to the station

Upon loading the station sector, several warning windows will show up and the station will be gone, leaving behind its turrets should it have had any.

Tester information (Internal use only)

Screen:

Log:

[2017-01-03 17:49:28] [SERVER] Ship SpaceStation[ENTITY_SPACESTATION_Station_Derelict Alpha_9_-35_132_1483487087388(110313)]
used a block type that is not allowed on space stations:
Rammet Crystal(452)
It will be removed!
[2017-01-03 17:49:28] [SERVER] Ship SpaceStation[ENTITY_SPACESTATION_Station_Derelict Alpha_9_-35_132_1483487087388(110313)]
used a block type that is not allowed on space stations:
Purple Weeds(105)
It will be removed!
[2017-01-03 17:49:28] [SERVER] Ship SpaceStation[ENTITY_SPACESTATION_Station_Derelict Alpha_9_-35_132_1483487087388(110313)]
used a block type that is not allowed on space stations:
Red Wood Leaves(288)
It will be removed!

Required setting for this to happen:
REMOVE_ENTITIES_WITH_INCONSISTENT_BLOCKS = true //This will remove ships that have blocks that are normally disallowed (e.g. space station blocks on ships)

Serverconfig (server.cfg)
REMOVE_ENTITIES_WITH_INCONSISTENT_BLOCKS = true //This will remove ships that have blocks that are normally disallowed (e.g. space station blocks on ships)

Event Timeline

spunkie created this task.Oct 13 2016, 5:04 PM
spunkie updated the task description. (Show Details)Oct 13 2016, 5:08 PM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.Oct 13 2016, 5:11 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Single and Multi.
SmilingDemon changed Category from none/unspecified to Typos/Content.
SmilingDemon claimed this task.
SmilingDemon triaged this task as High priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptOct 13 2016, 5:13 PM

Here are the stations that disappear on my server. This is only happening to the neutral stations but I provided all the defaults just in case.

spunkie claimed this task.
spunkie edited Steps to reproduce. (Show Details)Oct 13 2016, 5:32 PM
spunkie changed Affected Gamemode(s) from Single and Multi to Multiplayer.
spunkie changed Reproducible from uncertain to Yes.
spunkie set Last tested (version) to 0.199.253 rel.
spunkie updated the task description. (Show Details)Oct 13 2016, 6:35 PM
spunkie reassigned this task from spunkie to SmilingDemon.
AndyP edited Tester information (Internal use only). (Show Details)Jan 4 2017, 11:13 AM
AndyP changed Last tested (version) from 0.199.253 rel to 0.199.357.
AndyP changed Category from Typos/Content to Engine.
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP updated the task description. (Show Details)
AndyP moved this task from Open / Validated to Confirmed on the Issue Navigation board.
AndyP changed the task status from Open to In Queue (Game).
AndyP claimed this task.
AndyP reassigned this task from AndyP to SmilingDemon.

-Confirmed-

Validated this to happen via a support ticket on a server,
also could reproduce this on my local machine, as well as on the testserver.

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJan 4 2017, 11:14 AM
AndyP updated the task description. (Show Details)Jan 4 2017, 11:17 AM
AndyP edited Tester information (Internal use only). (Show Details)
AndyP renamed this task from Derelict station trouble to Derelict stations get false positive removal for "ship only blocks".
AndyP claimed this task.
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:04 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:04 PM
schema changed the task status from In Queue to Resolved.Mar 14 2017, 11:50 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 14 2017, 11:50 PM
AndyP moved this task from Backlog / Unclassed to General on the Engine board.Mar 15 2017, 6:26 PM
AndyP edited projects, added Engine (General); removed Engine.
AndyP moved this task from General to Data on the Engine board.Mar 15 2017, 7:57 PM
AndyP edited projects, added Engine (Data); removed Engine (General).
lancake added a subscriber: lancake.
lancake claimed this task.

-QA Testing-

Fix confirmed, can't reproduce it anymore.

lancake closed this task as Closed.Apr 28 2017, 1:24 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 28 2017, 1:24 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript